Thanks Stephan for fixing the build failures (https://webkit.org/b/202879 and https://webkit.org/b/202893). Both EWS and build.webkit.org are green again for WinCairo. e.g.: https://ews-build.webkit.org/#/builders/12/builds/7577 and https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Build... Thanks Aakash

On Oct 12, 2019, at 2:43 AM, Aakash Jain <aakash_jain@apple.com> wrote:

Tracking in https://bugs.webkit.org/show_bug.cgi?id=202879 <https://bugs.webkit.org/show_bug.cgi?id=202879>. Probably broken in https://bugs.webkit.org/show_bug.cgi?id=202780 <https://bugs.webkit.org/show_bug.cgi?id=202780>

Unfortunately, as WinCairo EWS bots aren't in a good shape, it's probably easy to accidentally break WinCairo (WinCairo EWS didn't run properly in above case as well).

-Aakash

...

On Oct 12, 2019, at 2:33 AM, Aakash Jain <aakash_jain@apple.com <mailto:aakash_jain@apple.com>> wrote:

Hello All,

Wincairo build seems to be broken. EWS and build.webkit.org <http://build.webkit.org/> seems to be failing with below build error, e.g.: https://ews-build.webkit.org/#/builders/12/builds/7400/steps/9/logs/stdio <https://ews-build.webkit.org/#/builders/12/builds/7400/steps/9/logs/stdio>, https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Build... <https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Build%29/builds/11035/steps/compile-webkit/logs/stdio>

Can someone have a look?

[1854/5075] Linking CXX shared library bin64\libGLESv2.dll FAILED: bin64/libGLESv2.dll lib64/libGLESv2.lib cmd.exe /C "cd . && C:\tools\cmake\bin\cmake.exe -E vs_link_dll --intdir=Source\ThirdParty\ANGLE\CMakeFiles\GLESv2.dir --rc="C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x64\rc.exe" --mt="C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x64\mt.exe" ... ... ... winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:bin64\libGLESv2.dll.manifest" failed (exit code 1120) with the following output: Creating library lib64\libGLESv2.lib and object lib64\libGLESv2.exp

LINK : warning LNK4217: symbol 'ANGLEGetDisplayPlatform' defined in 'ANGLE.lib(Platform.cpp.obj)' is imported by 'proc_table_egl_autogen.cpp.obj' in function ...

LINK : warning LNK4217: symbol 'ANGLEResetDisplayPlatform' defined in 'ANGLE.lib(Platform.cpp.obj)' is imported by 'proc_table_egl_autogen.cpp.obj' in function ...

ANGLE.lib(Renderer11.cpp.obj) : error LNK2019: unresolved external symbol CreateDXGIFactory1 referenced in function ...

bin64\libGLESv2.dll : fatal error LNK1120: 1 unresolved externals

[1858/5075] Building CXX object Source\WebCore\PAL\pal\CMakeFiles\PAL.dir\FileSizeFormatter.cpp.obj ninja: build stopped: subcommand failed.

Thanks Aakash