Remove the version labels in GitHub
Hi folks. I understand it can be super critical to understand what version someone was testing when reporting a WebKit bug. But I, at least, haven’t found the version field at bugs.webkit.org useful in the 20+ years I have been working on this project. Now we have that same noise in GitHub. All my pull requests have the label WebKit Nightly Build on them when I use the “git webkit pr” command to create them. And we have lots of labels with various version numbers, such as “Safari 8” and “417.x". Can we just get rid of all this? Is there anyone who’s finding these labels useful in GitHub? I suggest we remove these labels from the project. No objections to leaving the version field in bugs.webkit.org for the time being, but eventually I think we should probably get rid of that too. — Darin
Indeed, I'd love it those didn't exist. (I always imagined them to be exclusively intended for bug reports originating from non-contributors, but I'm not even certain how much they've been used in that scenario.) ________________________________ From: Michael Catanzaro via webkit-dev <webkit-dev@lists.webkit.org> Sent: Saturday, October 22, 2022 11:43:51 PM To: Darin Adler <darin@apple.com> Cc: webkit-dev@lists.webkit.org <webkit-dev@lists.webkit.org> Subject: Re: [webkit-dev] Remove the version labels in GitHub On Sat, Oct 22 2022 at 07:31:06 AM -0700, Darin Adler via webkit-dev <webkit-dev@lists.webkit.org> wrote:
Can we just get rid of all this?
That would be nice. These labels are not useful for pull requests. _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://urldefense.com/v3/__https://lists.webkit.org/mailman/listinfo/webkit...
Would it make sense to, rather than referring to downstream browsers, have a canonical WebKit version number that could be exposed in about:version or something? A friendly semver-ish thing + short git hash could be a lot more useful for doing things like bisecting. I think part of the reason the version numbers havent been useful is they are very detached from the actual open source product, and don't necessarily help with triage or reproduction, or hint at a cause.
On Oct 22, 2022, at 10:31 AM, Darin Adler via webkit-dev <webkit-dev@lists.webkit.org> wrote:
Hi folks.
I understand it can be super critical to understand what version someone was testing when reporting a WebKit bug. But I, at least, haven’t found the version field at bugs.webkit.org useful in the 20+ years I have been working on this project.
Now we have that same noise in GitHub. All my pull requests have the label WebKit Nightly Build on them when I use the “git webkit pr” command to create them. And we have lots of labels with various version numbers, such as “Safari 8” and “417.x".
Can we just get rid of all this? Is there anyone who’s finding these labels useful in GitHub?
I suggest we remove these labels from the project. No objections to leaving the version field in bugs.webkit.org for the time being, but eventually I think we should probably get rid of that too.
— Darin _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
On Oct 22, 2022, at 12:11 PM, Caitlin Potter <caitp@igalia.com> wrote:
Would it make sense to, rather than referring to downstream browsers, have a canonical WebKit version number that could be exposed in about:version or something? A friendly semver-ish thing + short git hash could be a lot more useful for doing things like bisecting.
I think part of the reason the version numbers havent been useful is they are very detached from the actual open source product, and don't necessarily help with triage or reproduction, or hint at a cause.
I personally am not looking to add something. I’d rather remove the thing we currently have that is not useful. I am definitely open to adding something later if we come up with something great. It’s not clear how easy it would be to improve things by adding more than the git hashes and the commit.webkit.org increasing numbers we already have. On Apple’s platforms there are already both Safari version numbers and WebKit version numbers and it’s not clear where an additional WebKit open source reference version number would go, and how to best express the effects of branching. — Darin
A couple days ago I created a pull request for part of this: https://github.com/WebKit/WebKit/pull/6434 Don't convert the bugs.webkit.org version to a label when creating a pull request by darinadler · Pull Request #6434 · WebKit/WebKit github.com Anyone interested in reviewing? — Darin
I also would like to propose removing Version label asking in git-webkit when creating a bugzilla entry. This was not happening when using webkit-patch. Given that we have no consensus on adding this, I think this is a regression. -Yusuke
On Nov 14, 2022, at 2:38 PM, Darin Adler via webkit-dev <webkit-dev@lists.webkit.org> wrote:
A couple days ago I created a pull request for part of this:
https://github.com/WebKit/WebKit/pull/6434 Anyone interested in reviewing?
— Darin _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Right, I thought that was the point of the above discussion so I was surprised to see that the prompt hasn't been removed. ________________________________ From: Yusuke Suzuki via webkit-dev <webkit-dev@lists.webkit.org> Sent: Monday, November 21, 2022 12:51:42 PM To: WebKit Development <webkit-dev@lists.webkit.org> Cc: Darin Adler <darin@apple.com> Subject: Re: [webkit-dev] Remove the version labels in GitHub I also would like to propose removing Version label asking in git-webkit when creating a bugzilla entry. This was not happening when using webkit-patch. Given that we have no consensus on adding this, I think this is a regression. -Yusuke On Nov 14, 2022, at 2:38 PM, Darin Adler via webkit-dev <webkit-dev@lists.webkit.org> wrote: A couple days ago I created a pull request for part of this: <https://urldefense.com/v3/__https://github.com/WebKit/WebKit/pull/6434__;!!JmoZiZGBv3RvKRSx!7SytV3Jiytv8Ymxt3yW1kKeUygTrozTd6bQhM2f9JJn6npJtRQf0xZdaaUbWaIHLMTahdRom7jHDY1Er9J2U7vMIhwQ$> <6434.png> Don't convert the bugs.webkit.org version to a label when creating a pull request by darinadler · Pull Request #6434 · WebKit/WebKit<https://urldefense.com/v3/__https://github.com/WebKit/WebKit/pull/6434__;!!JmoZiZGBv3RvKRSx!7SytV3Jiytv8Ymxt3yW1kKeUygTrozTd6bQhM2f9JJn6npJtRQf0xZdaaUbWaIHLMTahdRom7jHDY1Er9J2U7vMIhwQ$> github.com<https://urldefense.com/v3/__https://github.com/WebKit/WebKit/pull/6434__;!!JmoZiZGBv3RvKRSx!7SytV3Jiytv8Ymxt3yW1kKeUygTrozTd6bQhM2f9JJn6npJtRQf0xZdaaUbWaIHLMTahdRom7jHDY1Er9J2U7vMIhwQ$> Anyone interested in reviewing? — Darin _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev<https://urldefense.com/v3/__https://lists.webkit.org/mailman/listinfo/webkit-dev__;!!JmoZiZGBv3RvKRSx!7SytV3Jiytv8Ymxt3yW1kKeUygTrozTd6bQhM2f9JJn6npJtRQf0xZdaaUbWaIHLMTahdRom7jHDY1Er9J2UUQHuYAI$>
Uploaded a patch. https://github.com/WebKit/WebKit/pull/6692 Remove version requirement in git-webkit for bugzilla and github by Constellation · Pull Request #6692 · WebKit/WebKit github.com -Yusuke
On Nov 20, 2022, at 7:56 PM, Kirsling, Ross <Ross.Kirsling@sony.com> wrote:
Right, I thought that was the point of the above discussion so I was surprised to see that the prompt hasn't been removed. From: Yusuke Suzuki via webkit-dev <webkit-dev@lists.webkit.org> Sent: Monday, November 21, 2022 12:51:42 PM To: WebKit Development <webkit-dev@lists.webkit.org> Cc: Darin Adler <darin@apple.com> Subject: Re: [webkit-dev] Remove the version labels in GitHub
I also would like to propose removing Version label asking in git-webkit when creating a bugzilla entry. This was not happening when using webkit-patch. Given that we have no consensus on adding this, I think this is a regression.
-Yusuke
On Nov 14, 2022, at 2:38 PM, Darin Adler via webkit-dev <webkit-dev@lists.webkit.org> wrote:
A couple days ago I created a pull request for part of this:
<6434.png> Don't convert the bugs.webkit.org version to a label when creating a pull request by darinadler · Pull Request #6434 · WebKit/WebKit github.com <https://urldefense.com/v3/__https://github.com/WebKit/WebKit/pull/6434__;!!JmoZiZGBv3RvKRSx!7SytV3Jiytv8Ymxt3yW1kKeUygTrozTd6bQhM2f9JJn6npJtRQf0xZdaaUbWaIHLMTahdRom7jHDY1Er9J2U7vMIhwQ$>Don't convert the bugs.webkit.org version to a label when creating a pull request by darinadler · Pull Request #6434 · WebKit/WebKit <https://urldefense.com/v3/__https://github.com/WebKit/WebKit/pull/6434__;!!JmoZiZGBv3RvKRSx!7SytV3Jiytv8Ymxt3yW1kKeUygTrozTd6bQhM2f9JJn6npJtRQf0xZdaaUbWaIHLMTahdRom7jHDY1Er9J2U7vMIhwQ$> github.com <https://urldefense.com/v3/__https://github.com/WebKit/WebKit/pull/6434__;!!JmoZiZGBv3RvKRSx!7SytV3Jiytv8Ymxt3yW1kKeUygTrozTd6bQhM2f9JJn6npJtRQf0xZdaaUbWaIHLMTahdRom7jHDY1Er9J2U7vMIhwQ$> Anyone interested in reviewing?
— Darin _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev <https://urldefense.com/v3/__https://lists.webkit.org/mailman/listinfo/webkit-dev__;!!JmoZiZGBv3RvKRSx!7SytV3Jiytv8Ymxt3yW1kKeUygTrozTd6bQhM2f9JJn6npJtRQf0xZdaaUbWaIHLMTahdRom7jHDY1Er9J2UUQHuYAI$>
participants (5)
-
Caitlin Potter
-
Darin Adler
-
Kirsling, Ross
-
Michael Catanzaro
-
Yusuke Suzuki