Hi, While working with (non-legacy) WebKit for WinCairo, we realized that we need to support loading the missingImage and similar resources. On https://bugs.webkit.org/show_bug.cgi?id=188175#c6, Fujii-san mentioned that it'd probably be the time to fix the fixme at https://github.com/WebKit/webkit/blob/c4b88ee56e4f77201ffdcaf6a5988cbc43e199... for loadResourceIntoBuffer. Is there any reason that sharing the loading code, the actual resource files, rc file or resource.h would be a problem (especially for AppleWin)? And, if we want to share them, are there suggestions about where to move those files? Could we move it down to WebCore to be shared? Thanks, Stephan
I don’t think there’s a fundamental reason why the resources and code can’t be moved. Just make sure everything still works
On Jan 7, 2019, at 10:45 AM, Stephan.Szabo@sony.com wrote:
Hi,
While working with (non-legacy) WebKit for WinCairo, we realized that we need to support loading the missingImage and similar resources.
On https://bugs.webkit.org/show_bug.cgi?id=188175#c6 <https://bugs.webkit.org/show_bug.cgi?id=188175#c6>, Fujii-san mentioned that it’d probably be the time to fix the fixme at https://github.com/WebKit/webkit/blob/c4b88ee56e4f77201ffdcaf6a5988cbc43e199... <https://github.com/WebKit/webkit/blob/c4b88ee56e4f77201ffdcaf6a5988cbc43e199f3/Source/WebKitLegacy/win/WebKitDLL.cpp#L171> for loadResourceIntoBuffer. Is there any reason that sharing the loading code, the actual resource files, rc file or resource.h would be a problem (especially for AppleWin)? And, if we want to share them, are there suggestions about where to move those files? Could we move it down to WebCore to be shared?
Thanks, Stephan _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org <mailto:webkit-dev@lists.webkit.org> https://lists.webkit.org/mailman/listinfo/webkit-dev <https://lists.webkit.org/mailman/listinfo/webkit-dev>
participants (2)
-
Alex Christensen
-
Stephan.Szabo@sony.com