What is the correct way to skip a layout test on Chromium now that platform/chromium/Skipped has been removed? eric
We never had platform/chromium/Skipped, as far as I know. Instead, we use the expectations file: http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium/test_expe... Instead of skipping tests, we still run them, but expect them to fail. This allows for both being able to see how the test fails and pulling down baselines when it just needs to be updated. :DG< On Mon, Aug 30, 2010 at 8:52 AM, Eric Carlson <eric.carlson@apple.com> wrote:
What is the correct way to skip a layout test on Chromium now that platform/chromium/Skipped has been removed?
eric
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
On Aug 30, 2010, at 8:59 AM, Dimitri Glazkov wrote:
We never had platform/chromium/Skipped, as far as I know.
Ah, I saw that platform/chromium/Skipped was removed in r66261 and assumed it was a change.
Instead, we use the expectations file: http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium/test_expe...
Instead of skipping tests, we still run them, but expect them to fail. This allows for both being able to see how the test fails and pulling down baselines when it just needs to be updated.
What is the correct METADATA for a new media test that doesn't apply to Chromium (it is for a QuickTime specific behavior)? I think the test will fail because it uses a movie you probably don't support, so filing a bug seems like unnecessary busy work. I think the test will time out but I don't know so what is the correct EXPECTATIONS? eric
// Doesn't apply to Chromium (QuickTime-specific behavior) WONTFIX SKIP : test/name = TIMEOUT :DG< On Mon, Aug 30, 2010 at 9:43 AM, Eric Carlson <eric.carlson@apple.com> wrote:
On Aug 30, 2010, at 8:59 AM, Dimitri Glazkov wrote:
We never had platform/chromium/Skipped, as far as I know.
Ah, I saw that platform/chromium/Skipped was removed in r66261 and assumed it was a change.
Instead, we use the expectations file: http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium/test_expe...
Instead of skipping tests, we still run them, but expect them to fail. This allows for both being able to see how the test fails and pulling down baselines when it just needs to be updated.
What is the correct METADATA for a new media test that doesn't apply to Chromium (it is for a QuickTime specific behavior)? I think the test will fail because it uses a movie you probably don't support, so filing a bug seems like unnecessary busy work. I think the test will time out but I don't know so what is the correct EXPECTATIONS?
eric
participants (2)
-
Dimitri Glazkov
-
Eric Carlson