Removing the ENABLE(CSS_SCROLL_SNAP) flag
Recently, css-scroll-snap was enabled on all ports. The implementation has also been extended to be mostly platform-independent. Since all ports are compiling this code and it's a fairly basic CSS feature should we go ahead and remove the ENABLE(CSS_SCROLL_SNAP) build flag? I think this would greatly simplify the scrolling code. Thanks! --Martin
Hi Martin! My $0.02: when all ports have the feature enabled and the code is cross-platform, it's usually best to remove the build flag unless there's a particular strong reason to keep it around. We have more than enough build flags, and if you get to delete old code that just makes it even better! Michael
Sounds fine. Simon
On Jun 15, 2021, at 5:04 AM, Martin Robinson via webkit-dev <webkit-dev@lists.webkit.org> wrote:
Recently, css-scroll-snap was enabled on all ports. The implementation has also been extended to be mostly platform-independent. Since all ports are compiling this code and it's a fairly basic CSS feature should we go ahead and remove the ENABLE(CSS_SCROLL_SNAP) build flag? I think this would greatly simplify the scrolling code.
Thanks!
--Martin _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
participants (3)
-
Martin Robinson
-
Michael Catanzaro
-
Simon Fraser