Can we remove XXX.order files in the tree
Hello WebKittens! Our XXX.order file (e.g. JavaScriptCore.order) is not updated so long. The content is already stale, and I think this is no longer effective. Can we just remove these XXX.order files? -Yusuke
Can we measure the performance impact of doing this? If it's neutral, I think we should remove it. - Saam
On Oct 17, 2019, at 3:05 PM, Yusuke Suzuki <ysuzuki@apple.com> wrote:
Hello WebKittens!
Our XXX.order file (e.g. JavaScriptCore.order) is not updated so long. The content is already stale, and I think this is no longer effective. Can we just remove these XXX.order files?
-Yusuke _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
I put up patches a few year ago: <https://webkit.org/b/174344> [Cocoa] Remove or update order files It was approved at the time, but I was asked to measure performance and I'm still not sure how to do that. I'm still in favor of removing them! - Joe
On Oct 17, 2019, at 3:06 PM, Saam Barati <sbarati@apple.com> wrote:
Can we measure the performance impact of doing this?
If it's neutral, I think we should remove it.
- Saam
On Oct 17, 2019, at 3:05 PM, Yusuke Suzuki <ysuzuki@apple.com> wrote:
Hello WebKittens!
Our XXX.order file (e.g. JavaScriptCore.order) is not updated so long. The content is already stale, and I think this is no longer effective. Can we just remove these XXX.order files?
-Yusuke _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
These files haven't been updated in years so I doubt they're particularly helpful. They were at one time measurable launch time wins for hdd machines and thats what we need to validate won't regress. -- Stephanie
On Oct 17, 2019, at 3:05 PM, Yusuke Suzuki <ysuzuki@apple.com> wrote:
Hello WebKittens!
Our XXX.order file (e.g. JavaScriptCore.order) is not updated so long. The content is already stale, and I think this is no longer effective. Can we just remove these XXX.order files?
-Yusuke _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
What benchmark do we use to track this order files’ improvement? If I just remove these files now, can perf bot tell us the results? Best regards, Yusuke Suzuki
On Oct 17, 2019, at 15:42, Stephanie <slewis@apple.com> wrote:
These files haven't been updated in years so I doubt they're particularly helpful. They were at one time measurable launch time wins for hdd machines and thats what we need to validate won't regress.
-- Stephanie
On Oct 17, 2019, at 3:05 PM, Yusuke Suzuki <ysuzuki@apple.com> wrote:
Hello WebKittens!
Our XXX.order file (e.g. JavaScriptCore.order) is not updated so long. The content is already stale, and I think this is no longer effective. Can we just remove these XXX.order files?
-Yusuke _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
participants (4)
-
Joseph Pecoraro
-
Saam Barati
-
Stephanie
-
Yusuke Suzuki