Hi guys.

I've noticed recently that a bunch of bugs fixes are going in without regression tests. We must not do that. We need these regression tests so that WebKit keeps getting better instead of playing "Whac-a-Mole" <http://en.wikipedia.org/wiki/Whac-a-Mole#Colloquial_usage>.

    People investigating bugs:
    - Please make a reduced test case into a standalone test. This can help us figure out what the bug is, and saves the person fixing the bug precious time.

    People fixing bugs:
    - Please write a test. Anders even suggests writing the test before fixing the bug, which I think is a great idea. And if you can't write a test, please make a note in the change log explaining why.

    Reviewers reviewing patches:
    - Please do review-minus if there's no test, even if the fix is otherwise correct.

    Committers checking in patches:
    - If the reviewer forgot to ask for a test, mark the bug review-minus.

I am one of the recent offenders here! At the end of the message I list eleven recent check-ins that:

    1) look to me like bug fixes
    2) don't mention any new tests that were added (either manual tests or tests in LayoutTests)
    3) don't give any excuse for the lack of tests

For these we should write some tests now, or update the change log to show the tests we did land and forgot to mention or to give excuses.

    -- Darin

2006-01-24  Darin Adler  <darin@apple.com>

    - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6696
      REGRESSION: JavaScript window.opener set incorrectly

2006-01-24  Darin Adler  <darin@apple.com>

    - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6753
      REGRESSION (r12282-12292): Crash loading TinyMCE test app

2006-01-24  Darin Adler  <darin@apple.com>

    - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6732
      REGRESSION: Repro crash at Google Maps

2006-01-24  Maciej Stachowiak  <mjs@apple.com>

    - fixed crash if a node is removed from the DOM before being reparented due to residual style
    http://bugzilla.opendarwin.org/show_bug.cgi?id=6778

2006-01-24  Tim Omernick  <timo@apple.com>

    <rdar://problem/4339024>
    <http://bugzilla.opendarwin.org/show_bug.cgi?id=6785> "Fix for possible leak of applet, object, or emb
ed
    (and plugin view)"

2006-01-25  Adele Peterson  <adele@apple.com>

    http://bugzilla.opendarwin.org/show_bug.cgi?id=6816
    Crash in dispatchMouseEvent - Missing nil check

2006-01-25  Alexander Kellett  <lypanov@kde.org>

    Percentage values for width, height are not rendered correctly.
    http://bugzilla.opendarwin.org/show_bug.cgi?id=5331

2006-01-26  Eric Seidel  <eseidel@apple.com>

    SVG shows up blank in WebKit+SVG
    http://bugzilla.opendarwin.org/show_bug.cgi?id=6620

2006-01-26  Adele Peterson  <adele@apple.com>

    - fix for <rdar://problem/4422624> REGRESSION: crash loading webmail.mac.com

2006-01-26  Alexander Kellett  <lypanov@kde.org>

    <text> elements with a scale on a parent <g> breaks nodeAtPoint
    Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6843

2006-01-26  Beth Dakin  <bdakin@apple.com>

    Fix for <rdar://problem/4256504> khtml::RenderBlock::skipWhitespace
    crashes upon interaction with radio buttons.