Hi guys.
People investigating bugs:
- Please make a reduced test case into a standalone test. This can help us figure out what the bug is, and saves the person fixing the bug precious time.
People fixing bugs:
- Please write a test. Anders even suggests writing the test before fixing the bug, which I think is a great idea. And if you can't write a test, please make a note in the change log explaining why.
Reviewers reviewing patches:
- Please do review-minus if there's no test, even if the fix is otherwise correct.
Committers checking in patches:
- If the reviewer forgot to ask for a test, mark the bug review-minus.
I am one of the recent offenders here! At the end of the message I list eleven recent check-ins that:
1) look to me like bug fixes
2) don't mention any new tests that were added (either manual tests or tests in LayoutTests)
3) don't give any excuse for the lack of tests
For these we should write some tests now, or update the change log to show the tests we did land and forgot to mention or to give excuses.
-- Darin
REGRESSION: JavaScript window.opener set incorrectly
REGRESSION (r12282-12292): Crash loading TinyMCE test app
REGRESSION: Repro crash at Google Maps
- fixed crash if a node is removed from the DOM before being reparented due to residual style
ed
(and plugin view)"
Crash in dispatchMouseEvent - Missing nil check
Percentage values for width, height are not rendered correctly.
SVG shows up blank in WebKit+SVG
<text> elements with a scale on a parent <g> breaks nodeAtPoint
crashes upon interaction with radio buttons.