On Jun 26, 2018, at 18:55, Michael Catanzaro <mcatanzaro@igalia.com> wrote:
Hi,
We're a lot closer after r233227!
There is still IsSecureContextAttributeEnabled. Shall we switch the default value of that one to use DEFAULT_EXPERIMENTAL_FEATURES_ENABLED instead of true?
Not sure, waiting for other people to get back to me. There’s some indication that this one, indeed, should follow DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, but I want to make sure :)
We should also move CSSAnimationTriggersEnabled to the experimental features section of the file, and add the category tag. FullScreenEnabled and EncryptedMediaAPIEnabled should also be moved down in the file.
Will have to peek at these!
Then we can just update the comment to indicate that custom values like DEFAULT_SERVICE_WORKERS_ENABLED are fine as long as they're thoughtful and consider ENABLE(EXPERIMENTAL_FEATURES), and that will take care of the other cases.
Makes sense.
Michael