On it
On Dec 6, 2018, at 4:44 PM, Andy Estes <aestes@apple.com> wrote:
On Dec 6, 2018, at 4:37 PM, Chris Fleizach <cfleizach@apple.com <mailto:cfleizach@apple.com>> wrote:
On Dec 6, 2018, at 4:37 PM, Ryan Haddad <ryanhaddad@apple.com <mailto:ryanhaddad@apple.com>> wrote:
Chris,
I'm assuming that this is in reference to the patch in https://bugs.webkit.org/show_bug.cgi?id=192373 <https://bugs.webkit.org/show_bug.cgi?id=192373>. My guess is that something about the changes to Source/WebKit/WebKit.xcodeproj/project.pbxproj is causing an issue with unified sources.
The commit-queue itself has been landing other patches without issue and the build isn't broken on trunk bots. CC'ing Tim in case he can help point out the issue.
Yea must be. Any ideas why this wouldn’t build? I moved this .h/.mm to another folder (from Mac -> Cocoa)
Looks like we need to forward-declare class WebKit::SafeBrowsingWarning in WebViewImpl.h. Can you try that in your patch and see if that fixes it?
Andy