I think it’s fine to not have a shorthand. I can just make an alias for the shorthand version myself. Cheers, Keith
On Aug 23, 2017, at 12:11 PM, Aakash Jain <aakash_jain@apple.com> wrote:
We can have "--wip" flag equivalent to " --no-review --no-ews".
But I feel that it might not be clear to many people that it also means skip EWS. Many people might expect EWS to be run while passing --wip flag. The name "wip" doesn't clear imply skipping EWS. Maybe we can come up with a better name, or probably the current --no-ews flag is good enough.
-Aakash
On Aug 23, 2017, at 11:56 AM, Ryosuke Niwa <rniwa@webkit.org> wrote:
On Wed, Aug 23, 2017 at 9:11 AM, Andy Estes <aestes@apple.com> wrote:
On Aug 22, 2017, at 8:10 PM, Keith Miller <keith_miller@apple.com> wrote:
Does it make sense to have a --wip option that’s basically --no-review / don’t run EWS? There are times I upload clearly broken patches for early analysis that don’t need to be run on EWS.
`webkit-patch --no-review --no-ews` should do what you want.
I think Keith was asking about adding a shorthand for that combination.
I'm not certain if the most common workflow of uploading a WIP patch to Bugzilla involves not triggering EWS. I feel like I upload WIP patches to test out EWS but that could be just me.
- R. Niwa _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev