On Dec 4, 2005, at 11:39 AM, George Staikos wrote:
On Sunday 04 December 2005 08:31, Eric Seidel wrote:
Hi all-
I've been attempting to do some code cleanup in WebCore as of late. I've removed several dead (and rotted) sections of #ifdef'd code, and am about make patches to remove some more #ifdef'd sections and I wanted to make sure there were no complaints.
CACHE_DEBUG PARSER_DEBUG TOKEN_DEBUG DEBUG_LAYOUT FORMS_DEBUG KJS_VERBOSE CSS_DEBUG CSS_STYLESHEET_DEBUG
is the list of ifdefs (and associated code) which I plan to post patches to remove. kdWarning, kdDebug, kdError are all noops in WebCore, thus these #ifdefs are useless (without defining your own local kdDebug, etc.)
Any complaints?
Any ifdefs which I haven't listed there which you'd like to make sure we don't remove?
I object as well. This is just making it even harder to merge things with our tree, and we definitely use them.
As I mentioned in my previous email to Alexey, I think there are smaller, cleaner ways of achieving the same goal. Unfortunately the "it's hard to merge between khtml" isn't a very strong argument anymore, given how far we've diverged in the last 4.5 years. (RefPtr, #APPLE_CHANGES, JSC gc changes, QualifiedName being just a few on a long list). The goal here is to make the source as clean and readable as possible. Perhaps then merging at a file-level (as we're currently attempting with kdom/ksvg2) will be a more viable approach. -eric