I suspect that Maciej is right and whatever speedup we would see would be inconsequential. It's still a slightly cleaner design to not have to shell out to Ruby from Python, jumping from one scripting language to another. The deadlocking issue is a serious issue, blocking us from increasing our usage of new-run-webkit-tests, but simply porting PrettyPatch isn't going to fix it (for the record, I am actively working on fixing the deadlocking issue). But until we can put a stake into old-run-webkit-tests, we can't delete the ruby version anyway (well, I guess we could shell out from Perl to Python, but that would be only slightly less goofy). -- Dirk On Wed, Sep 1, 2010 at 11:30 PM, Ryosuke Niwa <rniwa@webkit.org> wrote:
Oh, I didn't see your second post either. Sounds like porting everything into Python would speed up new-run-webkit-tests? Then I'm all for it. I think other folks would be equally convinced as well if you could kindly measure the time difference between Ruby + Python + shell script implementation vs Python implementation. - Ryosuke
On Wed, Sep 1, 2010 at 9:28 PM, Dirk Pranke <dpranke@chromium.org> wrote:
Hi Sam,
Did you see the reply I sent on this thread? There are actually decent reasons to rewrite the code into Python, to simplify and speed up the new-run-webkit-tests implementation. Given that, do you still object to the patch landing (since the work has already been done)?
-- Dirk
On Wed, Sep 1, 2010 at 7:40 PM, Sam Weinig <sam.weinig@gmail.com> wrote:
Sorry, I seemed to have missed this thread. Please do not rewrite scripts just to rewrite them in a language you like. WebKit's dependency on Ruby is here to stay. Just because python is common at Google does not make it universal. -Sam
On Wed, Sep 1, 2010 at 4:48 PM, TAMURA, Kent <tkent@chromium.org> wrote:
Thanks. So porting PrettyPatch to Python will make good benefit and should have no drawbacks. I should go ahead.
On Wed, Sep 1, 2010 at 09:21, William Siegrist <wsiegrist@apple.com> wrote:
On Aug 31, 2010, at 4:43 PM, TAMURA, Kent wrote:
Can we run python scripts on bugs.webkit.org server?
Yes.
-Bill
-- TAMURA Kent Software Engineer, Google
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev