On Fri, Jul 30, 2010 at 7:55 PM, Eric Seidel <eric@webkit.org> wrote:
On Fri, Jul 30, 2010 at 5:42 AM, Jeremy Orlow <jorlow@chromium.org> wrote:
Why wasn't it done that way originally? That sounds (to my uneducated ear) much better than what's done today.
The world was very different back then. :)
- WebKit was only on one platform (Mac). - Much of what is now WebCore, was up in WebKit. - (As Adam also mentions) LayoutTestController was initially more about faking click events, etc.
A lot has changed in 6, 7, 8.. whatever it is now... years.
I agree, I think that a better modern solution would be to move huge chunks of DRT into WebCore itself, and have them compiled in Debug and Release builds and removed from Production builds (controlled by some flag).
WebKit ports would just pipe another method "exposeTestObjectsToJavaScript" or similar up to the various DRT ports.
We could get rid of a huge amount of boiler-plate DRT code (much of which deals with type conversions).
Mr. Seidel, we might have found our next project. Adam