Hi Zoltan. Sounds like a bug. (I tend to dislike #ifdefs like JIT_OPTIMIZE_CALL because of their tendency to fall prey to bit rot like this.) Loading the callee into regT1, regT0 is best. I'd recommend changing ! JIT_OPTIMIZE_CALL to respect that convention. Geoff On Oct 7, 2009, at 6:54 AM, Zoltan Herczeg wrote:
Hi,
I am not sure this is a bug, so I am curios about your opinion. Currently, I am trying to enable JSVALUE32_64 on ARM. First step, as usual, with all optimizations disabled. Unfortunately, I got a crash. If JIT_OPTIMIZE_CALL is disabled, callee is loaded to regT1 and regT2, while if enabled, to regT0 and regT1. However, there is only one type of compileOpCallSetupArgs, which presumes that callee is in regT0 and regT1. If this is indeed a bug, which way should I choose: change compileOpCall or put ifdef-s to compileOpXXXSetupArgs functions?
Zoltan
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev