On Saturday, August 1, 2009 10:16:39 AM, Adam Barth wrote:
On Sat, Aug 1, 2009 at 8:43 AM, tonikitoo (Antonio Gomes)wrote:
Adam, as I suggedted previously, bugzilla supports KEYWORDs, so that would be a matter of adding a special support for bugs where patches are ready to go in.
'checkin-needed' keyword would work , i believe. What do you think ?
In addition to the point Ojan made about applying to individual patches, a flag also has the advantage that it implicates who approved the patch to be committed. Sure, the information is available for keywords if you dig deep enough, but the system has more accountability if the name is right there.
Bugzilla has the ability to create additional 4-state flags at both the attachment level and at the bug level. (Note that bugs.webkit.org does not have bug-level flags enabled.) For example, we could create a "commit" attachment flag which would have four states (just like the "review" flag): <none>, commit?, commit+, commit-. I'm not sure if this helps or hurts, though it would have made abarth's desired workflow much nicer. Mozilla also uses a "superreview" flag and various "approval" flags as seen on the attachments on this bug: <https://bugzilla.mozilla.org/show_bug.cgi?id=342677> Dave