Hi Hajime, I was looking to implement EditorClientQt::checkSpellingOfString() stub for the qt port. This is part of an effort to enable red squiggle markers for misspelled text. We'd like to show the markers for any editable content when rendering with qtwebkit based browsers. This would rely on a spelling engine but, as qt has no spell checker, Hunspell integration to WebCore seems appealing. I was headed in this direction when I found this thread and I wonder if you are still pursuing this. Can you tell me if it is a worthwhile pursuit, or if you had problems? I'm interested in continuing, but give me a "heads up" if you were blocked for some reason. Thanks! Fabrizio On Nov 16, 2010, at 8:52 PM, Hajime Morita wrote:
Hi WebKit folks,
I'm thinking about porting Hunspell-based spellchecking code from Chromium to WebKit/WebCore.
Although it's unclear whether the porting is feasible, I'd like to hear how much interest is there from other ports before starting actual work.
Because the main goal is to make spellcheck available for more ports, It would be just a waste if there is no demand.
For example, I heard that GTK+ has GtkSpell, which is based on Enchant. Because our code is based on Hunspell, GtkSpell based integration is out of scope of this proposal... I have no idea about Qt, EFL, etc.
BTW, here is an under-half-baked-rough plan:
- Extract spellcheck related methods on EditorClient, to interface (or abstract class) named, say, platform/text/TextChecker. - with keeping existing method, for compatibility - Add a getter like "TextChecker* textChecker() = 0;" to EditorClient. - Implement TextCheckerHunspell, a subclass of TextCheckerHunspell - TextCheckerHunspellChromium and some other variants will also be added, to make Chromium specific hooks. - (optional) Move Mac's spellchecker implementation from WebCoreSupport/WebEditorClient to platform/text/TextCheckerCocoa, another subclass of TextChecker. - (optional) Remove legacy methods on EditorClient
This approach would make spellchecker pluggable, so WebKit can choose preferable spellchecker at runtime with this. (For example, Chromium port wants to use both Hunspell and system spellchecker. GTK port might want use Enchant and Hunspell.)
Is this beneficial for your port? Are there other design possibilities? Any feedback is welcome.
-- morrita _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev