On Sat, Aug 1, 2009 at 12:53 PM, Jeremy Orlow<jorlow@chromium.org> wrote:
Btw, I see one downside to a commit queue: When you manually commit something, you're supposed to watch the build bots for breakage. If the submit queue is running all the tests on all the platforms then it doesn't really matter, but if not there'll need to be automated rollbacks when things break on the waterfall build bots. This could easily become complicated if the commit queue can submit multiple patches before the waterfall bots show green for the previous patch.
We're a ways from having a fully automated commit queue. When I run the commit-queue script, I also watch the bots and clean up manually as needed. (So far this hasn't been necessary, but I'm sure it will be at some point.) Adam