Sorry, Private instead of Project. Public would put it in the public framework headers. WebCore has no public headers only Private headers which are exposed to WebKit. -eric On Thu, Sep 2, 2010 at 4:36 AM, Eric Seidel <eric@webkit.org> wrote:
You need to modify the WebCore target settings to have that header marked as "Private" intead of public. There are various ways to do that, either via the Targets area of the left side bar, or by getting info on the header in the project file.
On Thu, Sep 2, 2010 at 4:29 AM, Yuzo Fujishima <yuzo@google.com> wrote:
Hi, webkit developers,
I locally changed WebCore/platform/graphics/FontFallbackList.h such that it includes SegmentedFontData.h in the same directory [1]. Since then build-webkit complains that SegmentedFontData.h cannot be found [2]. Actually I don't see SegmentedFontData.h in WebKitBuild/.../PrivateHeaders/ directory. How can I specify that SegmentedFontData.h must be copied to the directory?
Yuzo
[1] diff --git a/WebCore/platform/graphics/FontFallbackList.h b/WebCore/platform/graphics/FontFallbackList.h index a0b94dd..d3409f9 100644 --- a/WebCore/platform/graphics/FontFallbackList.h +++ b/WebCore/platform/graphics/FontFallbackList.h @@ -22,6 +22,7 @@ #define FontFallbackList_h
#include "FontSelector.h" +#include "SegmentedFontData.h" #include "SimpleFontData.h" #include <wtf/Forward.h> ...
[2] ... CompileC <WebKitSrc>/WebKitBuild/WebKit.build/Debug/WebKit.build/Objects-normal/x86_64/WebRenderNode.o mac/WebView/WebRenderNode.mm normal x86_64 objective-c++ com.apple.compilers.gcc.4_2 cd <WebKitSrc>/WebKit /Developer/usr/bin/gcc-4.2 -x objective-c++ -arch x86_64 -fmessage-length=0 -pipe -Wno-trigraphs -fno-exceptions -fno-rtti -fpascal-strings -fasm-blocks -O0 -Werror -Wmissing-prototypes -Wnon-virtual-dtor -Wnewline-eof -DDISABLE_THREAD_CHECK -DENABLE_WEBKIT_UNSET_DYLD_FRAMEWORK_PATH -DENABLE_3D_CANVAS -DENABLE_3D_RENDERING -DENABLE_BLOB -DENABLE_CHANNEL_MESSAGING -DENABLE_CLIENT_BASED_GEOLOCATION -DENABLE_DATABASE -DENABLE_DATALIST -DENABLE_DOM_STORAGE -DENABLE_EVENTSOURCE -DENABLE_FILTERS -DENABLE_FULLSCREEN_API -DENABLE_GEOLOCATION -DENABLE_ICONDATABASE -DENABLE_JAVASCRIPT_DEBUGGER -DENABLE_MATHML -DENABLE_METER_TAG -DENABLE_OFFLINE_WEB_APPLICATIONS -DENABLE_PROGRESS_TAG -DENABLE_RUBY -DENABLE_SANDBOX -DENABLE_SHARED_WORKERS -DENABLE_SVG -DENABLE_SVG_ANIMATION -DENABLE_SVG_AS_IMAGE -DENABLE_SVG_DOM_OBJC_BINDINGS -DENABLE_SVG_FONTS -DENABLE_SVG_FOREIGN_OBJECT -DENABLE_SVG_USE -DENABLE_VIDEO -DENABLE_WEB_SOCKETS -DENABLE_WORKERS -DENABLE_XPATH -DENABLE_XSLT -DFRAMEWORK_NAME=WebKit -DWEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST -fobjc-gc -fvisibility-inlines-hidden -fno-threadsafe-statics -mmacosx-version-min=10.6 -gdwarf-2 -I<WebKitSrc>/WebKitBuild/WebKit.build/Debug/WebKit.build/WebKit.hmap -Wall -Wextra -Wchar-subscripts -Wextra-tokens -Wformat-security -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wno-unused-parameter -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wcast-align -F<WebKitSrc>/WebKitBuild/Debug -F/System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks -F/System/Library/Frameworks/ApplicationServices.framework/Frameworks -F/System/Library/Frameworks/Carbon.framework/Frameworks -F/System/Library/Frameworks/Quartz.framework/Frameworks -F/System/Library/PrivateFrameworks -I<WebKitSrc>/WebKitBuild/Debug/include -I<WebKitSrc>/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/ForwardingHeaders -I<WebKitSrc>/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/icu -I<WebKitSrc>/WebKitBuild/Debug/usr/local/include -I<WebKitSrc>/WebKitBuild/Debug/DerivedSources/WebKit -I<WebKitSrc>/WebKitBuild/WebKit.build/Debug/WebKit.build/DerivedSources/x86_64 -I<WebKitSrc>/WebKitBuild/WebKit.build/Debug/WebKit.build/DerivedSources -include /var/folders/++/++-8Jk++6+0++4RjPqRgNE++GZQ/-Caches-/com.apple.Xcode.19031/SharedPrecompiledHeaders/WebKitPrefix-cejasxonupvwgnfamqhxhbfgzugy/WebKitPrefix.h -c <WebKitSrc>/WebKit/mac/WebView/WebRenderNode.mm -o <WebKitSrc>/WebKitBuild/WebKit.build/Debug/WebKit.build/Objects-normal/x86_64/WebRenderNode.o
In file included from <WebKitSrc>/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/Font.h:30, from <WebKitSrc>/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/RenderStyle.h:47, from <WebKitSrc>/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/RenderObject.h:36, from <WebKitSrc>/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/RenderText.h:26, from <WebKitSrc>/WebKit/mac/WebView/WebRenderNode.mm:34: <WebKitSrc>/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/FontFallbackList.h:25:31: error: SegmentedFontData.h: No such file or directory ... _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev