So, I have two thoughts on that: 1) We can certainly do that. The trick will be making it discoverable. 2) I'd like the tool to read back in the state from the bug comments and re-populate the comments inline in the diff. That way you'll keep the context and can have threaded conversations in the diff. Adam On Sun, Aug 29, 2010 at 12:01 PM, Oliver Hunt <oliver@apple.com> wrote:
It would be nice if you could select a block of code and have the comment be for that block -- last i looked the line by line review basically loses context for reviews as it pushes the comments to the bottom and only includes a single line of context.
--Oliver
On Aug 29, 2010, at 11:13 AM, Adam Barth wrote:
Based on some feedback, I'm going to try to improve the line-by-line review tool. I've landed the first iteration of the new design, which should be usable and have roughly the same functionality as the old design. I'll be adding new features shortly.
The main difference is you now access the line-by-line review feature using the "Formatted Diff" link in bugs.webkit.org instead of the "Review Patch" link. I made this change so that folks who like the old "Review Patch" tool won't be bothered by the new tool. If you have feature requests, let me know. I'll post an update once the tool is awesomified.
Thanks, Adam _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev