27 Jul
2007
27 Jul
'07
9:09 p.m.
On Friday 27 July 2007 21:15:27 Lars Knoll wrote:
On Friday 27 July 2007 21:05:00 Darin Adler wrote:
On Jul 27, 2007, at 11:53 AM, Lars Knoll wrote:
I'm fine with moving to this approach (even though it'll still lead to some code duplication if we do it the easy way without refactoring).
I don't think we should insist on doing it without refactoring. It seems good to add private member functions as necessary so we can share as much of the code as possible.
Good, I was just under the impression that you wanted to avoid these kind of changes at the moment. I'll prepare a patch then.
Patch is in http://bugs.webkit.org/show_bug.cgi?id=14791 . Please review. Cheers, Lars