Revision

71570

Author

abarth@webkit.org

Date

2010-11-08 14:18:05 -0800 (Mon, 08 Nov 2010)

Log Message

2010-11-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Restore normal meaning of double-click on patch review page?
        https://bugs.webkit.org/show_bug.cgi?id=47641

        After this patch, you need to click on the line numbers to add a
        comment.

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

Modified Paths

• trunk/BugsSite/ChangeLog
• trunk/BugsSite/PrettyPatch/PrettyPatch.rb
• trunk/BugsSite/code-review.js

Diff

--- trunk/BugsSite/ChangeLog	2010-11-08 22:10:51 UTC (rev 71569)
+++ trunk/BugsSite/ChangeLog	2010-11-08 22:18:05 UTC (rev 71570)
@@ -1,3 +1,16 @@
+2010-11-08  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Restore normal meaning of double-click on patch review page?
+        https://bugs.webkit.org/show_bug.cgi?id=47641
+
+        After this patch, you need to click on the line numbers to add a
+        comment.
+
+        * PrettyPatch/PrettyPatch.rb:
+        * code-review.js:
+
 2010-10-09  Adam Barth  <abarth@webkit.org>
 
         Reviewed by Alexey Proskuryakov.

--- trunk/BugsSite/PrettyPatch/PrettyPatch.rb	2010-11-08 22:10:51 UTC (rev 71569)
+++ trunk/BugsSite/PrettyPatch/PrettyPatch.rb	2010-11-08 22:18:05 UTC (rev 71570)
@@ -312,7 +312,7 @@
 }
 </style>
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script> 
-<script src="code-review.js?version=13"></script> 
+<script src="code-review.js?version=14"></script> 
 EOF
 
     def self.revisionOrDescription(string)

--- trunk/BugsSite/code-review.js	2010-11-08 22:10:51 UTC (rev 71569)
+++ trunk/BugsSite/code-review.js	2010-11-08 22:18:05 UTC (rev 71570)
@@ -253,7 +253,7 @@
   }
 
   function crawlDiff() {
-    $('.Line').each(idify).each(hoverify).dblclick(addCommentField);
+    $('.Line').each(idify).each(hoverify);
     $('.FileDiff').each(function() {
       var file_name = $(this).children('h1').text();
       files[file_name] = this;