On Sep 1, 2017, at 9:30 AM, Brady Eidson <beidson@apple.com> wrote:
I recently worked on a patch where - because of the organic refactoring of the patch over its development - I ended up with a std::optional<Ref> instead of a RefPtr.
A followup review after it had already landed pointed this out, and it got me to thinking:
Does RefPtr do anything for us today that std::optional<Ref> doesn’t?
Simpler syntax.
I kind of like the idea of replacing RefPtr with std::optional<Ref>. It makes it explicitly clear what object is actually holding the reference, and completely removes some of the confusion of “when should I use Ref vs RefPtr?”
There are many places in JSC where we don’t even consider using Ref. -Filip
Thoughts?
Thanks, ~Brady _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev