9 Apr
2012
9 Apr
'12
10:02 p.m.
3) Don't use test_expectations.txt to suppress failures across a single cycle of the bot, just so you can gather updated baselines without the tree going red. While it might seem that you're doing tree maintainers a favor, in my experience this just makes things confusing and it's better to let the tree go red until you can actually rebaseline things. It's too easy to add a suppression "for now" and then forget about it.
How would you suggest someone contribute a patch that changes layout test results, if not by marking the test as failing? - James