Question answered (in irc): WebKit2 files should have config.h<div><br></div><div>Thanks!<br><br><div class="gmail_quote">On Mon, Apr 11, 2011 at 9:58 AM, David Levin <span dir="ltr">&lt;<a href="mailto:levin@google.com">levin@google.com</a>&gt;</span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Hi,<div>I was looking at a patch (<a href="https://bugs.webkit.org/show_bug.cgi?id=57535" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=57535</a>) in which it uses the OS() macro in some headers (to add a conditional include to define time_t).</div>

<div><br></div><div>Unfortunately, when these headers are included from WebKit2 files, the build breaks (on various platforms) because OS() isn&#39;t defined. Typically OS() is defined by including config.h but that file doesn&#39;t seem to be in the cpp files for WebKit2.</div>

<div><br></div><div>What is the proper way of fixing this?</div><div><ul><li>include wtf/Platform.h directly in the header files affected (which seem wrong to me).</li><li>include config.h in WebKit2 files (but this appears not to be done).</li>

<li>other?</li></ul></div></blockquote></div></div>