Ok.  I see the &quot;commit-queue&quot; as orthogonal to the discussion.  It&#39;s just a means of automating patch commits.<div><br></div><div>You&#39;re asking that committers not commit patches containing &quot;ChromiumBridge.h&quot;, which I think is fair to ask, but I&#39;m just pointing out that I don&#39;t think folks will necessarily remember if contributers don&#39;t remind us in the bugs.  Keeping up with the to-be-committed seems to keep us plenty busy without a list of special exceptions. :)<div>
<br></div><div>I will certainly endeavor to avoid patches containing ChromiumBridge.h</div><div><br></div><div>-eric<br><br><div class="gmail_quote">On Sat, Sep 5, 2009 at 3:16 PM, Darin Fisher <span dir="ltr">&lt;<a href="mailto:darin@chromium.org">darin@chromium.org</a>&gt;</span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">That&#39;s why I started this thread.  The process may be a bit unfamiliar to some<div>patch contributors (especially new ones), and so I wanted reviewers to be in</div>
<div>the know that changes to ChromiumBridge.h should not be committed using</div>
<div>the commit queue.</div><div><br></div><font color="#888888"><div>-Darin</div></font><div><div></div><div class="h5"><div><br></div><div><div><br><div class="gmail_quote">On Sat, Sep 5, 2009 at 1:45 AM, Eric Seidel <span dir="ltr">&lt;<a href="mailto:eric@webkit.org" target="_blank">eric@webkit.org</a>&gt;</span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Agreed.  It&#39;s the submitters responsibility to make it clear that they don&#39;t want their patch committed immediately after review.  Current assumption is that all committers don&#39;t want their patches committed after review, but all non-committers do.<div>


<div><br></div><div><font color="#888888">-eric</font><div><div></div><div><br><br><div class="gmail_quote">On Fri, Sep 4, 2009 at 7:12 PM, David Levin <span dir="ltr">&lt;<a href="mailto:levin@chromium.org" target="_blank">levin@chromium.org</a>&gt;</span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Even better if the person submitting the patch marks it as commit-queue- when they do the r? (as Jian does for example) to prevent this from happening.  <div><br></div><div>Just do this for any patch that you want to be in control of landing.</div>



<div><br></div><div>dave</div><div><br><div class="gmail_quote"><div><div></div><div>On Fri, Sep 4, 2009 at 11:04 AM, Darin Fisher <span dir="ltr">&lt;<a href="mailto:darin@chromium.org" target="_blank">darin@chromium.org</a>&gt;</span> wrote:<br>


</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div></div><div>
<span style="font-family:arial, sans-serif;font-size:13px;border-collapse:collapse;white-space:pre">Please do not commit-queue+ changes to ChromiumBridge.h</span><div>
<font face="arial, sans-serif"><span style="border-collapse:collapse;white-space:pre"><br>
</span></font></div><div><font face="arial, sans-serif"><span style="border-collapse:collapse;white-space:pre">These changes by definition break the Chromium build because they require corresponding changes in the Chromium repository.  Please leave such CLs to a Chromium developer to commit because they can then coordinate the landing of the other side of the patch.</span></font></div>




<div><font face="arial, sans-serif"><span style="border-collapse:collapse;white-space:pre"><br>
</span></font></div><div><font face="arial, sans-serif"><span style="border-collapse:collapse;white-space:pre">Also, if you are wondering about the impact of a WebKit patch on the Chromium build, please see our integration bots here:  <a href="http://tinyurl.com/md47pk" target="_blank">http://tinyurl.com/md47pk</a></span></font></div>




<div><font face="arial, sans-serif"><span style="border-collapse:collapse;white-space:pre"><br>
</span></font></div><div><span style="font-family:arial, sans-serif;border-collapse:collapse;white-space:pre">Thanks!</span></div>
<div><font face="arial, sans-serif"><span style="border-collapse:collapse;white-space:pre">-Darin</span></font></div>
<br></div></div>_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
<br></blockquote></div><br></div></div></div></div>
</blockquote></div><br></div></div>
</div></div></blockquote></div><br></div></div>