15 Apr
2009
15 Apr
'09
8:17 p.m.
On Apr 15, 2009, at 3:48 PM, Sverrir Á. Berg wrote:
Working on a change in FrameTree and noticed that the checks in top() and parent() for 'checkForDisconnectedFrame' rely on a flag in Frame that as far as I can tell is never set. So my naive question is: Can I remove the corresponding code from Frame and FrameTree? If not I would like if somebody could explain how they are used so I don't break anything with my change.
More detail: * My search for calls to Frame::setIsDisconnected reveals no callers in WebKit, Chromium or Google code search.
There are two callers: http://trac.webkit.org/browser/trunk/WebKit/mac/WebView/WebFrame.mm?rev=4245... and http://trac.webkit.org/browser/trunk/WebKit/win/WebFrame.cpp?rev=42451#L283 -Adam