August 2024 - webkit-dev - lists.webkit.org

InjectedBundle deprecation
by Alex Christensen 01 Aug '25

01 Aug '25

Hello WebKit developers! We are ramping up to do some serious work on Site Isolation which includes putting cross-origin iframes in a different process than the parent frame. Similar efforts have been done in other browser engines and some related work has already been done in WebKit, but not enough. This will do strange things to the InjectedBundle APIs, which have fundamental assumptions that the whole DOM is in one process and that communication only happens with one process at a time. We have never exposed InjectedBundle APIs as public API, but some other distributors of WebKit have. As we make progress on this project, we anticipate that anything in Source/WebKit/WebProcess/InjectedBundle/API is subject to deprecation and removal. This will also allow us to tighten the sandbox on the web process, resolve security and performance issues, and have cleaner code. Would the maintainers of the GTK and WPE APIs be willing to assist in migrating from those APIs and designing replacements in the UI process? Alex Christensen

5 17

Site isolation
by Alex Christensen 01 Aug '25

01 Aug '25

The SiteIsolation feature is beginning to work in the simplest of cases, but I had to do some work in the Source/WebKit/Shared/RemoteLayerTree directory, which is platform-specific. Basically all the use of LayerHostingContextIdentifier in that directory needs an equivalent implementation for other graphics implementations, like in the CoordinatedGraphics directories. There is one layout test in LayoutTests/http/tests/site-isolation/basic-iframe.html that is currently skipped on all non-Cocoa platforms. Is someone willing to collaborate to design and implement the feature in non-Cocoa ports? We are in the early stages of the project and have a long way to go, so I imagine things will continue to come up, like deciding how to implement event handling and other platform dependent features. Alex

3 6

Site isolation platform code
by Alex Christensen 14 Jan '25

14 Jan '25

Hey everyone! I’ve been doing a bunch of work on site isolation recently, and I’ve been doing my best to make all my changes platform-independent so it just works for everyone. However, there are two places I could use some collaboration with other WebKit developers: 1. createNewPage in WebKitUIClient.cpp needs some hooking up of the API::PageConfiguration in a way I couldn’t figure out in the few minutes I looked at it. This should be pretty straightforward to someone who knows the glib code better than I do. 2. We have a growing number of tests in LayoutTests/http/tests/site-isolation that exercise drawing code, which will take a significant amount of work to get implemented on non-Cocoa platforms. A lot of changes are happening in this area right now with the adoption of Skia, and it would be great if it were done in a way that could support site isolation. Thanks, Alex

2 2

Problems with injecting js-code on first load
by Erik Lundin 29 Aug '24

29 Aug '24

Hi, I'm trying to inject javascript code on each page load but it fails on the first load every time. If I reload the page it works. How do I fix this? Is there something I've missed in the code below? The printfs work but the js-code does not get injected. #include <gtk/gtk.h> #include <webkit/webkit.h> GtkWidget *window; GtkWidget *webview; static void handle_script_message(WebKitUserContentManager *manager, JSCValue* value, gpointer user_data) { printf("handle_script_message()%s\n", value); } static void web_view_load_changed(WebKitWebView *web_view, WebKitLoadEvent load_event, gpointer user_data) { switch(load_event) { case WEBKIT_LOAD_FINISHED: printf("WEBKIT_LOAD_FINISHED %s\n", webkit_web_view_get_uri(web_view)); WebKitUserScript *script = webkit_user_script_new( "window.test = 12345; console.log(window.test);", WEBKIT_USER_CONTENT_INJECT_ALL_FRAMES, WEBKIT_USER_SCRIPT_INJECT_AT_DOCUMENT_END, NULL, NULL ); WebKitUserContentManager *manager = webkit_web_view_get_user_content_manager(web_view); webkit_user_content_manager_add_script( manager, script ); webkit_user_script_unref(script); printf("SCRIPTS LOADED\n"); break; } } static void activate(GtkApplication* app, gpointer user_data) { window = gtk_application_window_new (app); gtk_window_set_title(GTK_WINDOW (window), "Webkit Test"); gtk_window_set_default_size(GTK_WINDOW (window), 800, 600); // Create a browser instance webview = webkit_web_view_new(); WebKitSettings *settings = webkit_web_view_get_settings (WEBKIT_WEB_VIEW(webview)); g_object_set(G_OBJECT(settings), "enable-developer-extras", TRUE, NULL); WebKitUserContentManager *manager = webkit_web_view_get_user_content_manager(WEBKIT_WEB_VIEW(webview)); g_signal_connect(manager, "script-message-received::testjs", G_CALLBACK(handle_script_message), NULL); webkit_user_content_manager_register_script_message_handler(manager, "testjs", NULL); g_signal_connect(webview, "load-changed", G_CALLBACK(web_view_load_changed), NULL); webkit_web_view_load_uri(WEBKIT_WEB_VIEW(webview), "https://mytestserver"); gtk_window_set_child(GTK_WINDOW (window), webview); gtk_window_present(GTK_WINDOW(window)); WebKitWebInspector *inspector = webkit_web_view_get_inspector (WEBKIT_WEB_VIEW(webview)); webkit_web_inspector_show (WEBKIT_WEB_INSPECTOR(inspector)); } int main(int argc, char *argv[]) { GtkApplication *app; int status; app = gtk_application_new ("my.test.app", G_APPLICATION_DEFAULT_FLAGS); g_signal_connect (app, "activate", G_CALLBACK (activate), NULL); status = g_application_run (G_APPLICATION (app), argc, argv); g_object_unref (app); return status; } Regards, Erik

2 1

macOS Intel WK2 Tests on EWS
by Brianna Fan 26 Aug '24

26 Aug '24

Hi all, macOS Intel WK2 tests are live on EWS! The mac-intel-wk2 status bubble will appear for any changes uploaded after 1:15pm PT. Earlier this year, we replaced older Intel-based Mac Pro hardware with M1 and M2 Apple Silicon devices. With the exception of the JSC stress test queue, this upgrade meant that we had no Intel coverage for Apple platforms on EWS even though it remains a supported configuration post-commit. We have now added a mac-intel-wk2 queue that will run release WK2 layout tests on Ventura. Cheers, Brianna F

1 0