June 2024 - webkit-dev - lists.webkit.org

InjectedBundle deprecation
by Alex Christensen 01 Aug '25

01 Aug '25

Hello WebKit developers! We are ramping up to do some serious work on Site Isolation which includes putting cross-origin iframes in a different process than the parent frame. Similar efforts have been done in other browser engines and some related work has already been done in WebKit, but not enough. This will do strange things to the InjectedBundle APIs, which have fundamental assumptions that the whole DOM is in one process and that communication only happens with one process at a time. We have never exposed InjectedBundle APIs as public API, but some other distributors of WebKit have. As we make progress on this project, we anticipate that anything in Source/WebKit/WebProcess/InjectedBundle/API is subject to deprecation and removal. This will also allow us to tighten the sandbox on the web process, resolve security and performance issues, and have cleaner code. Would the maintainers of the GTK and WPE APIs be willing to assist in migrating from those APIs and designing replacements in the UI process? Alex Christensen

5 17

Site isolation
by Alex Christensen 01 Aug '25

01 Aug '25

The SiteIsolation feature is beginning to work in the simplest of cases, but I had to do some work in the Source/WebKit/Shared/RemoteLayerTree directory, which is platform-specific. Basically all the use of LayerHostingContextIdentifier in that directory needs an equivalent implementation for other graphics implementations, like in the CoordinatedGraphics directories. There is one layout test in LayoutTests/http/tests/site-isolation/basic-iframe.html that is currently skipped on all non-Cocoa platforms. Is someone willing to collaborate to design and implement the feature in non-Cocoa ports? We are in the early stages of the project and have a long way to go, so I imagine things will continue to come up, like deciding how to implement event handling and other platform dependent features. Alex

3 6

Site isolation platform code
by Alex Christensen 14 Jan '25

14 Jan '25

Hey everyone! I’ve been doing a bunch of work on site isolation recently, and I’ve been doing my best to make all my changes platform-independent so it just works for everyone. However, there are two places I could use some collaboration with other WebKit developers: 1. createNewPage in WebKitUIClient.cpp needs some hooking up of the API::PageConfiguration in a way I couldn’t figure out in the few minutes I looked at it. This should be pretty straightforward to someone who knows the glib code better than I do. 2. We have a growing number of tests in LayoutTests/http/tests/site-isolation that exercise drawing code, which will take a significant amount of work to get implemented on non-Cocoa platforms. A lot of changes are happening in this area right now with the adoption of Skia, and it would be great if it were done in a way that could support site isolation. Thanks, Alex

2 2

DO NOT USE JSC::Strong in WebCore
by Ryosuke Niwa 27 Jun '24

27 Jun '24

Please don’t use `JSC::Strong` in WebCore. Such a code often leads to memory leaks, and it’s almost always wrong. Often times, the correct solution is to use `JSC::Weak` and either visit children or opaque roots to keep it alive: https://docs.webkit.org/Deep%20Dive/Architecture/JSWrappers.html#opaque-roo… If you’re not sure or don’t know how to use them correctly, come talk to me or anyone else familiar with JS DOM bindings. Reviewers, please don’t r+ a patch which uses JSC::Strong unless you’re absolutely confident that it does not lead to a memory leak. The vast majority of PRs that use JSC::Strong should be outright r-'ed. - R. Niwa

1 0

Code Style Guideline entry about a space in empty braces
by Kohei.Asano＠sony.com 19 Jun '24

19 Jun '24

Hi. I'm now working on clang-format refinement for WebKit style. Although pre-set for WebKit is unused on WebKit/WebKit itself as we see https://github.com/WebKit/WebKit/blob/e91b9416d35d02968ccb1554d14e94568c762…, I'll add missing features of clang-format itself to make consistent with WebKit code style. A maintainer catches that we should take care about WebKit Code Style Guideline, in the patch that adds a missed feature https://github.com/llvm/llvm-project/pull/93634#discussion_r1632439352. So I wouldn't update WebKit pre-set on clang-format. I found Code Style Guideline misses an entry about empty braces, while check-webkit-style catches. I also created bugzilla ticket https://bugs.webkit.org/show_bug.cgi?id=275309 and candidate doc update patch https://github.com/WebKit/WebKit/pull/29668 Which is better to update Code Style Guideline or check-webkit-style? Thanks in advance. Kohei

3 3