November 2024 - webkit-dev - lists.webkit.org

InjectedBundle deprecation
by Alex Christensen 01 Aug '25

01 Aug '25

Hello WebKit developers! We are ramping up to do some serious work on Site Isolation which includes putting cross-origin iframes in a different process than the parent frame. Similar efforts have been done in other browser engines and some related work has already been done in WebKit, but not enough. This will do strange things to the InjectedBundle APIs, which have fundamental assumptions that the whole DOM is in one process and that communication only happens with one process at a time. We have never exposed InjectedBundle APIs as public API, but some other distributors of WebKit have. As we make progress on this project, we anticipate that anything in Source/WebKit/WebProcess/InjectedBundle/API is subject to deprecation and removal. This will also allow us to tighten the sandbox on the web process, resolve security and performance issues, and have cleaner code. Would the maintainers of the GTK and WPE APIs be willing to assist in migrating from those APIs and designing replacements in the UI process? Alex Christensen

5 17

Site isolation
by Alex Christensen 01 Aug '25

01 Aug '25

The SiteIsolation feature is beginning to work in the simplest of cases, but I had to do some work in the Source/WebKit/Shared/RemoteLayerTree directory, which is platform-specific. Basically all the use of LayerHostingContextIdentifier in that directory needs an equivalent implementation for other graphics implementations, like in the CoordinatedGraphics directories. There is one layout test in LayoutTests/http/tests/site-isolation/basic-iframe.html that is currently skipped on all non-Cocoa platforms. Is someone willing to collaborate to design and implement the feature in non-Cocoa ports? We are in the early stages of the project and have a long way to go, so I imagine things will continue to come up, like deciding how to implement event handling and other platform dependent features. Alex

3 6

Site isolation platform code
by Alex Christensen 14 Jan '25

14 Jan '25

Hey everyone! I’ve been doing a bunch of work on site isolation recently, and I’ve been doing my best to make all my changes platform-independent so it just works for everyone. However, there are two places I could use some collaboration with other WebKit developers: 1. createNewPage in WebKitUIClient.cpp needs some hooking up of the API::PageConfiguration in a way I couldn’t figure out in the few minutes I looked at it. This should be pretty straightforward to someone who knows the glib code better than I do. 2. We have a growing number of tests in LayoutTests/http/tests/site-isolation that exercise drawing code, which will take a significant amount of work to get implemented on non-Cocoa platforms. A lot of changes are happening in this area right now with the adoption of Skia, and it would be great if it were done in a way that could support site isolation. Thanks, Alex

2 2

Naming scheme for fooIfExists/ensureFoo - Round 2
by Ryosuke Niwa 08 Jan '25

08 Jan '25

Hi all, We discussed this topic 11 years ago in https://lists.webkit.org/pipermail/webkit-dev/2013-June/025056.html but we seem to have never codified it in our coding style guideline. It really bothers me that we have a mixture of two styles so I’d like to propose that we pick one style and put that into style guideline & style checker. The question is as follows. A pair of functions which lazily construct an object and one which returns nullptr if the object had not already been constructed can be named: StyleResolver* styleResolver(); StyleResolver& ensureStyleResolver(); or: StyleResolver* styleResolverIfExists(); StyleResolver& styleResolver(); Which one should we use? - R. Niwa

7 7

std::optional: * or value()?
by Anne van Kesteren 25 Nov '24

25 Nov '24

https://commits.webkit.org/238290@main seemed to express a preference for using * over value(), but the Code Style Guidelines are silent on this. Is this something we can establish a guideline for? I personally think * makes the code slightly more readable due to it being more concise.

2 1

An EWS for PlayStation, at last
by Kirsling, Ross 19 Nov '24

19 Nov '24

Hi everyone, As those of you who were at the recent contributor’s meeting are aware, we’re planning to launch a PlayStation EWS in the near future! We’ve had post-merge buildbots running for years, but we’ve not been able to have an EWS until now due to the potential for malicious PRs. As such, this EWS will involve a new feature: it will only run when the PR author is in some sense a “known contributor”. Specifically, our current plan is to check that the GitHub user belongs to the committers<https://github.com/orgs/WebKit/teams/committers> team. This is an imperfect definition, but it allows the EWS to be as secure as a post-merge buildbot, by letting “mergeable” imply “non-malicious”. If you have any questions or comments, please feel free to reach out here or on Slack! Thanks, Ross

2 1

Set once pointer types and static analysis
by Ryosuke Niwa 13 Nov '24

13 Nov '24

Hi all, In WebKit, it’s fairly common to write a member variable as RefPtr or std::unique_ptr that later gets lazily initialized to some value but never unset or assigned of a different value after that. e.g. class Foo { Bar& bar() { if (!m_bar) m_bar = Bar::create(); return *m_bar; } Ref<Bar> protectedBar() { return bar(); } RefPtr<Bar> m_bar; } Assuming there is no other code modifying m_bar, foo->bar()->method() is always safe to call even if method wasn’t a trivial function. Right now, static analyzer doesn’t recognize this pattern so we’d be forced to write code like this: foo->protectedBar()->method() where ensureProtectedBar is a wrapper around ensureBar which returns Ref<Bar>. A suggestion was made that static analyzer can recognize this patten. Specifically, if we introduced a new smart pointer types that only allow setting the value once, static analyzer can allow foo->bar()->method()and avoid ref-churn in some cases: e.g. class Foo { Bar& bar() { if (!m_bar) m_bar = Bar::create(); return *m_bar; } SetOnceRefPtr<Bar> m_bar; } SetOnceRefPtr::operator=(T*) release asserts that m_ptr isn’t set, and doesn’t have a move constructor, operator=(nullptr_t), leakRef(), releaseNonNull(), etc… which can override the value of m_ptr after setting the value via operator= or in constructor. We could create various variants: SetOnceRef, SetOnceUniquePtr, SetOnceUniqueRef. Do you think this will be useful? - R. Niwa

5 9

merge-queue / commit-queue downtime starting Friday November 8, 2024 @ 7:00 PM PST
by Ryan Haddad 08 Nov '24

08 Nov '24

Due to underlying infrastructure maintenance, merge-queue / commit-queue will be taken offline between Friday November 8, 2024 @ 7:00 PM PST through Saturday November 9, 2024 @ 9:00 AM PST. EWS will remain operational during this time, and anything labeled for merge-queue will be processed as soon as the service comes back online. Ryan

1 0

Read Aloud web pages
by ChandraSekharVarma Dasaraju 05 Nov '24

05 Nov '24

Hi , Are there any plans to support Read Aloud web pages for webkitgtk ? Thanks for your help. Thanks, DCS Varma

1 0

Gerald Squelart is now a reviewer !
by Jean-Yves Avenard 04 Nov '24

04 Nov '24

G’day ! I'm excited to announce that Gerald Squelart is now a WebKit reviewer. 🥳 Gerald joined the WebKit Graphic team a little while back and lately has been working on increasing our HDR support. Gerald has an almost infinite depth of C++ knowledge. Don’t hesitate to throw him questions about convoluted templates :) Thanks, and join me to congratulate Gerald. Jean-Yves

1 0