March 2023 - webkit-dev - lists.webkit.org

InjectedBundle deprecation
by Alex Christensen 01 Aug '25

01 Aug '25

Hello WebKit developers! We are ramping up to do some serious work on Site Isolation which includes putting cross-origin iframes in a different process than the parent frame. Similar efforts have been done in other browser engines and some related work has already been done in WebKit, but not enough. This will do strange things to the InjectedBundle APIs, which have fundamental assumptions that the whole DOM is in one process and that communication only happens with one process at a time. We have never exposed InjectedBundle APIs as public API, but some other distributors of WebKit have. As we make progress on this project, we anticipate that anything in Source/WebKit/WebProcess/InjectedBundle/API is subject to deprecation and removal. This will also allow us to tighten the sandbox on the web process, resolve security and performance issues, and have cleaner code. Would the maintainers of the GTK and WPE APIs be willing to assist in migrating from those APIs and designing replacements in the UI process? Alex Christensen

5 17

Site isolation
by Alex Christensen 01 Aug '25

01 Aug '25

The SiteIsolation feature is beginning to work in the simplest of cases, but I had to do some work in the Source/WebKit/Shared/RemoteLayerTree directory, which is platform-specific. Basically all the use of LayerHostingContextIdentifier in that directory needs an equivalent implementation for other graphics implementations, like in the CoordinatedGraphics directories. There is one layout test in LayoutTests/http/tests/site-isolation/basic-iframe.html that is currently skipped on all non-Cocoa platforms. Is someone willing to collaborate to design and implement the feature in non-Cocoa ports? We are in the early stages of the project and have a long way to go, so I imagine things will continue to come up, like deciding how to implement event handling and other platform dependent features. Alex

3 6

jsc bus error EXC_BAD_ACCESS with jsc-only build on Mac
by Laurence Rowe 29 Mar '23

29 Mar '23

Hi, I’m trying to build jsc on my M1 Mac following the instructions at https://trac.webkit.org/wiki/JSCOnly and https://webkit.org/getting-started/ . However when I run the built binary it exits immediately with a bus error which lldb shows to be EXC_BAD_ACCESS. lrowe@Laurences-MacBook-Air WebKit % git reset --hard origin/main HEAD is now at b2362a5d6b [UI-side compositing] Safari occasionally crashes when scrolling underneath `NSScrollerImpPair` https://bugs.webkit.org/show_bug.cgi?id=254484 rdar://107139674 lrowe@Laurences-MacBook-Air WebKit % git clean -Xf lrowe@Laurences-MacBook-Air WebKit % sudo xcode-select -s /Applications/Xcode.app/Contents/Developer lrowe@Laurences-MacBook-Air WebKit % Tools/Scripts/build-jsc --jsc-only # build log below lrowe@Laurences-MacBook-Air WebKit % ./WebKitBuild/Release/bin/jsc zsh: bus error ./WebKitBuild/Release/bin/jsc lrowe@Laurences-MacBook-Air WebKit % lldb ./WebKitBuild/Release/bin/jsc (lldb) target create "./WebKitBuild/Release/bin/jsc" Current executable set to '/Users/lrowe/scratch/WebKit/WebKitBuild/Release/bin/jsc' (arm64). (lldb) run Process 73062 launched: '/Users/lrowe/scratch/WebKit/WebKitBuild/Release/bin/jsc' (arm64) Process 73062 stopped * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=2, address=0x10d5ac000) frame #0: 0x00000001a1b43f78 libsystem_platform.dylib`_platform_memmove + 168 libsystem_platform.dylib`: -> 0x1a1b43f78 <+168>: stp q2, q3, [x0] 0x1a1b43f7c <+172>: subs x2, x2, #0x40 0x1a1b43f80 <+176>: b.ls 0x1a1b43f9c ; <+204> 0x1a1b43f84 <+180>: stp q0, q1, [x3] Target 0: (jsc) stopped. Versions: - WebKit main (b2362a5d6b) - Xcode 14.2 (14C18) - macOS 13.2.1 - CMake.app 3.26.1 (not mentioned at https://webkit.org/build-tools/ but required) I’ve also tried variously with Xcode command line tools, homebrew cmake, WebKit tag WebKit-7615.1.26.10.23, and adding the —debug flag to the build but I see the same error. Is there anything else I should be doing to build jsc? Thanks, Laurence Rowe # build log + cmake --build /Users/lrowe/scratch/WebKit/WebKitBuild/Release --config Release -- jsc testb3 testair testapi testmasm testdfg -j8 [ 0%] Built target JavaScriptCore_CopyHeaders [ 1%] Built target JavaScriptCoreSharedScripts [ 1%] Built target JSCBuiltins [ 1%] Built target Bytecodes [ 35%] Built target WTF_CopyHeaders [ 38%] Built target bmalloc_CopyHeaders [ 46%] Built target bmalloc [ 53%] Built target WTF [ 53%] Built target LLIntSettingsExtractor [ 53%] Building CXX object Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o [ 53%] Linking CXX executable ../../bin/LLIntOffsetsExtractor [ 53%] Built target LLIntOffsetsExtractor [ 53%] Generating ../../JavaScriptCore/DerivedSources/LLIntAssembly.h [ 53%] Building CXX object Source/JavaScriptCore/CMakeFiles/LowLevelInterpreterLib.dir/llint/LowLevelInterpreter.cpp.o [ 53%] Built target LowLevelInterpreterLib [ 53%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-f0a787a9-7.cpp.o [ 53%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-f0a787a9-11.cpp.o [ 53%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-bfc896e1-4.cpp.o [ 53%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-bfc896e1-3.cpp.o [ 53%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-bfc896e1-9.cpp.o [ 53%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/dfg/DFGSpeculativeJIT.cpp.o [ 54%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/dfg/DFGSpeculativeJIT32_64.cpp.o [ 54%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/dfg/DFGSpeculativeJIT64.cpp.o [ 54%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-bfc896e1-14.cpp.o [ 54%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-02aa2997-1.cpp.o [ 54%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/ftl/FTLLowerDFGToB3.cpp.o [ 54%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-ee8a7a7a-3.cpp.o [ 54%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-0e543b66-1.cpp.o [ 54%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-3a3c4ec0-1.cpp.o [ 54%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-f2e18ffc-21.cpp.o [ 54%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-f2e18ffc-34.cpp.o [ 54%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-f2e18ffc-42.cpp.o [ 54%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmAirIRGenerator32_64.cpp.o [ 54%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmAirIRGenerator64.cpp.o [ 54%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-0284c6ac-1.cpp.o [ 55%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/WasmBBQJIT.cpp.o [ 55%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-15db4ad9-1.cpp.o [ 55%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-15db4ad9-2.cpp.o [ 55%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-15db4ad9-3.cpp.o [ 55%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-15db4ad9-4.cpp.o [ 55%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-15db4ad9-5.cpp.o [ 55%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-15db4ad9-6.cpp.o [ 55%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-15db4ad9-7.cpp.o [ 55%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-15db4ad9-8.cpp.o [ 55%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-15db4ad9-9.cpp.o [ 55%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-15db4ad9-10.cpp.o [ 55%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-15db4ad9-11.cpp.o [ 55%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-15db4ad9-12.cpp.o [ 55%] Linking CXX shared library ../../lib/JavaScriptCore.framework/JavaScriptCore [ 66%] Built target JavaScriptCore [ 66%] Generating ../../JavaScriptCore/PrivateHeaders/JavaScriptCore/WasmCallee.h [100%] Built target JavaScriptCore_CopyPrivateHeaders [100%] Building CXX object Source/JavaScriptCore/shell/CMakeFiles/jsc.dir/__/jsc.cpp.o [100%] Linking CXX executable ../../../bin/jsc [100%] Built target jsc [ 0%] Built target Bytecodes [ 1%] Built target JavaScriptCoreSharedScripts [ 1%] Built target JavaScriptCore_CopyHeaders [ 1%] Built target JSCBuiltins [ 21%] Built target WTF_CopyHeaders [ 38%] Built target bmalloc_CopyHeaders [ 46%] Built target bmalloc [ 53%] Built target WTF [ 53%] Built target LLIntSettingsExtractor [ 53%] Built target LLIntOffsetsExtractor [ 53%] Built target LowLevelInterpreterLib [ 66%] Built target JavaScriptCore [100%] Built target JavaScriptCore_CopyPrivateHeaders [100%] Linking CXX executable ../../../bin/testb3 [100%] Built target testb3 [ 1%] Built target JavaScriptCoreSharedScripts [ 1%] Built target JavaScriptCore_CopyHeaders [ 1%] Built target Bytecodes [ 18%] Built target WTF_CopyHeaders [ 18%] Built target JSCBuiltins [ 38%] Built target bmalloc_CopyHeaders [ 46%] Built target bmalloc [ 53%] Built target WTF [ 53%] Built target LLIntSettingsExtractor [ 53%] Built target LLIntOffsetsExtractor [ 53%] Built target LowLevelInterpreterLib [ 66%] Built target JavaScriptCore [100%] Built target JavaScriptCore_CopyPrivateHeaders [100%] Linking CXX executable ../../../bin/testair [100%] Built target testair [ 0%] Built target Bytecodes [ 0%] Built target JavaScriptCore_CopyHeaders [ 1%] Built target JavaScriptCoreSharedScripts [ 1%] Built target JSCBuiltins [ 37%] Built target WTF_CopyHeaders [ 38%] Built target bmalloc_CopyHeaders [ 45%] Built target bmalloc [ 53%] Built target WTF [ 53%] Built target LLIntSettingsExtractor [ 53%] Built target LLIntOffsetsExtractor [ 53%] Built target LowLevelInterpreterLib [ 65%] Built target JavaScriptCore [ 98%] Built target JavaScriptCore_CopyPrivateHeaders [ 98%] Linking CXX executable ../../../bin/testapi [100%] Built target testapi [ 1%] Built target JavaScriptCoreSharedScripts [ 1%] Built target JavaScriptCore_CopyHeaders [ 1%] Built target JSCBuiltins [ 1%] Built target Bytecodes [ 21%] Built target bmalloc_CopyHeaders [ 38%] Built target WTF_CopyHeaders [ 45%] Built target bmalloc [ 53%] Built target WTF [ 53%] Built target LLIntSettingsExtractor [ 53%] Built target LLIntOffsetsExtractor [ 53%] Built target LowLevelInterpreterLib [ 65%] Built target JavaScriptCore [ 98%] Built target JavaScriptCore_CopyPrivateHeaders [100%] Linking CXX executable ../../../bin/testmasm [100%] Built target testmasm [ 1%] Built target JavaScriptCoreSharedScripts [ 1%] Built target JavaScriptCore_CopyHeaders [ 1%] Built target JSCBuiltins [ 1%] Built target Bytecodes [ 36%] Built target WTF_CopyHeaders [ 38%] Built target bmalloc_CopyHeaders [ 46%] Built target bmalloc [ 53%] Built target WTF [ 53%] Built target LLIntSettingsExtractor [ 53%] Built target LLIntOffsetsExtractor [ 53%] Built target LowLevelInterpreterLib [ 66%] Built target JavaScriptCore [100%] Built target JavaScriptCore_CopyPrivateHeaders [100%] Linking CXX executable ../../../bin/testdfg [100%] Built target testdfg ==================================================================== JavaScriptCore is now built (01m:00s). ====================================================================

4 9

Proposal on retiring JIT on Windows
by Yusuke Suzuki 27 Mar '23

27 Mar '23

Hello, I would like to propose retiring JIT on Windows JavaScriptCore. Recently, Apple Windows EWS bots get removed. As a result, there is no test-running EWS bots on Windows. This can work for the other part of WebKit since other ports EWS bots are running tests. However this does not work well for JSC. Compile-tests is not sufficient for JIT since JIT is dynamically generated. And JIT is very architecture and platform specific. Windows has different ABI, different calling convention, and register usage. JIT on Windows has very specific things. Now, because there is no running EWS bots on Windows, it is not possible to catch Windows specific JIT related issues before landing. Recently, JSC DFG patch has been reverted because Windows gets broken[1]. But this puts high burden to JSC maintenance since there is no way to test it before landing, and it makes DFG changes very hard due to Windows. So, given that there is no active maintainers of Windows JSC JIT and no EWS bots running tests, I propose retiring JIT on Windows. [1]: https://github.com/WebKit/WebKit/commit/58f0d9e4a395e0173e4d3f59888bf0e761c… -Yusuke

4 6

New reviewer: Mike Wyrzykowski
by Dean Jackson 19 Mar '23

19 Mar '23

Congratulations to Mike Wyrzykowski who is now a WebKit reviewer (github username: mwyrzykowski)! Dean

1 0

WebKit Documentation
by Brandon Stewart 16 Mar '23

16 Mar '23

Hi WebKit Developers, Documentation is an important part of any open source project, especially for a larger project like WebKit. Being able to ramp up during the onboarding process, reading up on architectural decisions, and learning how to perform common procedures are all features the documentation should tackle. WebKit has a large set of documentation already, but it is scattered around a wide range of platforms (Trac, GitHub Wiki, markdown files in the code, Git commits, etc...), and some of the information is out of date. A few months ago, I started working on a new documentation solution based on the DocC documentation framework. This provides an easy way to add and edit documentation through markdown files. I have already ported a large section of Trac, all of the GitHub Wiki, and all of the non third party markdown files in the code over to this platform. I have tested this on macOS and Linux and have found it works extremely well. (Windows should be able to use WSL2 at the moment, while a few remaining issues get sorted out). The only dependency for this project is a recent installation of Swift. You can already download the documentation and preview it locally, but we are looking to publish it online for easy viewing. We were looking to get your feedback if we would want to publish the documentation on GitHub Pages or webkit.org. The documentation source can be found at https://github.com/webkit/documentation. - Brandon

13 22

Announcing Login with GitHub on EWS webpages
by Aakash Jain 15 Mar '23

15 Mar '23

Hi Everyone, I am happy to announce a new feature in EWS: "Login with GitHub". In Bugzilla world, we have a feature named "Retry failed builds" which allow us to retry the EWS builds which failed (especially useful when the failure might be due to flakiness or infrastructure issue). However, in GitHub world, there was no way for WebKittens to retry the builds.... until now. From now on, when you visit any ews-build.webkit.org page (e.g.: the page which opens on clicking on any EWS status-bubble), you would be able to login to it using your existing GitHub account. To login, on any ews buildbot page, simply click on "Anonymous" -> "Login with GitHub" (on top-right). You will need to authorize "WebKit EWS" to access your GtiHub account to Login. After login, any WebKit contributor (listed in https://github.com/orgs/WebKit/teams/contributors/members) can press "Rebuild" button on any build. This would provide ability to retry not just the failing builds, but any builds, including failed, cancelled, skipped or even successful builds (for example if last EWS run on a PR was many days back and you want to run EWS again). Please click on this button only when needed, as unnecessary retries might waste resources. If you are not listed in https://github.com/orgs/WebKit/teams/contributors/members and should have been listed there (e.g.: you are in contributors.json and have listed your GitHub account in it), please let me (or any WebKit admin) know. As always, please feel free to let me know if you notice any issue or have any feedback. Thanks Aakash

1 3

Planned Outage: Merge Queue & EWS - March 10 - March 12, 2023
by Ling Ho 12 Mar '23

12 Mar '23

Hello WebKit, A network equipment work in our facility is scheduled to take place during the weekend of March 10, 2023. As a result, our Merge Queue and EWS services will be unavailable during this period: *Begin*: Friday March 10, 2023 - 9pm (PST) *End*: Sunday March 12, 2023 - No later than 9am (PST) Please contact us at admin(a)webkit.org if you have any questions or concerns. Thank you, ... Ling Ho

1 2

Planned Outage: WebKit Bugzilla - Mar 10, 2023
by Ling Ho 10 Mar '23

10 Mar '23

Hello WebKit developers, We are migrating WebKit Bugzilla (https://bugs.webkit.org) next Friday to a new hosting platform and will need to take it offline. *Begin*: Friday March 10, 2023 - 10:30pm (PST) *Duration*: 5 hours Please contact us at admin(a)webkit.org or on Slack if you have any questions or concerns. Thank you, ... Ling Ho

1 1

Tyler Wilcock is now a WebKit Reviewer
by Chris Fleizach 09 Mar '23

09 Mar '23

Hi I’m happy to report that Tyler Wilcock is now a WebKit reviewer! Tyler has great expertise in all things accessibility and is a great contact to discuss the accessible angle of any issue. Thanks!

2 1