May 2022 - webkit-dev - lists.webkit.org

Request for position: MediaTrackSupportedConstraints.suppressLocalAudioPlayback
by Elad Alon 25 May '22

25 May '22

This is a request for WebKit's position on extending getDisplayMedia to also accept DisplayMediaStreamConstraints.systemAudio. The PR that introduced this behavior to the getDisplayMedia spec was approved by Apple engineer Youenn Fablet. Links: * Explainer: https://docs.google.com/document/d/1OmuV1W4f2UvToeNxUVGHv8NcFuL63r94gWwz9i_… * Spec: https://github.com/w3c/mediacapture-screen-share/pull/164/files * ChromeStatus entry: https://chromestatus.com/feature/5201258309746688

1 0

안광림 is out of office.
by 안광림 25 May '22

25 May '22

Period : 2022/05/23 00:00 ~ 2022/07/15 00:00 [Korea Standard Time] 부재중입니다.

1 0

Request for position: DisplayMediaStreamConstraints.selfBrowserSurface
by Elad Alon 23 May '22

23 May '22

This is a request for WebKit's position on extending getDisplayMedia to also accept DisplayMediaStreamConstraints.selfBrowserSurface. The PR that introduced this behavior to the getDisplayMedia spec was approved by Apple engineer Youenn Fablet. Links: * Explainer: https://docs.google.com/document/d/1M63lyDHV-v6LPFzHjfsjBDMfyn075pySa3xfIRS… * Spec: https://github.com/w3c/mediacapture-screen-share/pull/216/files * ChromeStatus entry: https://chromestatus.com/feature/5118675366445056

1 0

안광림 is out of office.
by 안광림 23 May '22

23 May '22

Period : 2022/05/23 00:00 ~ 2022/07/15 00:00 [Korea Standard Time] 부재중입니다.

1 0

Request for position: DisplayMediaStreamConstraints.systemAudio
by Elad Alon 23 May '22

23 May '22

This is a request for WebKit's position on extending getDisplayMedia to also accept DisplayMediaStreamConstraints.systemAudio. The PR that introduced this behavior to the getDisplayMedia spec was approved by Apple engineer Youenn Fablet. Links: * Explainer: https://docs.google.com/document/d/1q3oGy7hLJmdQA4ZK7QG7DnwgtcpL6oB2pqLQJ6M… * Spec: https://github.com/w3c/mediacapture-screen-share/pull/222/files * ChromeStatus entry: https://chromestatus.com/feature/4649448880734208

1 0

Request for position: Web App launch_handler Manifest field
by Alan Cutter 19 May '22

19 May '22

Hi WebKit folks, I'm requesting a standards position on the launch_handler field I've been working on adding to the Web App Manifest ( https://www.w3.org/TR/appmanifest/) This field allows developers to control whether app launches dedupe into existing app instances or not. Explainer: https://github.com/WICG/sw-launch/blob/main/launch_handler.md Happy to answer any questions. - Alan Cutter

1 0

ChangeLogs are Deprecated
by Jonathan Bedard 17 May '22

17 May '22

As outlined in my email yesterday, Commit-Queue and Merge-Queue both now reject any changes that include ChangeLogs. I will be waiting a few days before actually deleting all of the ChangeLog files so that contributors with patches that still contain ChangeLogs can apply those patches without conflicts. Jonathan WebKit Continuous Integration

1 0

Proposal: Immediate Deprecation of ChangeLogs
by Jonathan Bedard 11 May '22

11 May '22

A few weeks ago, I started a discussion about deprecating ChangeLogs. In that time, we’ve had more folks using the pull-request workflow and more folks using newer versions of `git` which break automatic ChangeLog rebasing. I propose that on Monday, May 16th, we implement the following policy changes for the WebKit project: - Commits no longer require ChangeLogs, they instead require commit messages - Commit messages are in the format of `prepare-ChangeLog --no-write` Pull-request workflows based on `git-webkit` already support this workflow well, and `git-webkit setup` creates a `prepare-commit-msg` hook that will appropriately format commit messages. In addition, `git format-patch` allows us to create a patch which contains a commit message. This means that contributors still using patch workflows from a git or git-svn checkout will be able to upload compliant patches to bugzilla. This will, however, break contributors using pure-Subversion checkouts. This is something that’s going to be happening in the very near future as we deprecate Subversion entirely, so I think this is an acceptable cost in exchange for fully supporting native git workflows. The last thing I’d like to note is that a full git-native commit message policy now is something we can modify in the future if we find that reviewing commit messages with “Quote reply” comments is not sufficient, but resolving project disagreements on how or if to address deficiencies in GitHub commit message review don’t seem to be headed towards a resolution quickly. Jonathan WebKit Continuous Integration

5 11

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs
by Ryosuke Niwa 11 May '22

11 May '22

On Tue, May 10, 2022 at 9:27 PM Ryosuke Niwa <rniwa(a)webkit.org> wrote: > > > On Tue, May 10, 2022 at 20:36 Chris Dumez <cdumez(a)apple.com> wrote: >> >> [Not sure why Apple Mail sent Ryosuke’s replies to the Junk folder but I finally noticed.] > > > It's something to do with @webkit.org not being able to send a proper sender ID due to it being a forwarding address. > >> On May 10, 2022, at 3:04 PM, Ryosuke Niwa via webkit-dev <webkit-dev(a)lists.webkit.org> wrote: >> >> On Tue, May 10, 2022 at 3:01 PM Jonathan Bedard via webkit-dev >> <webkit-dev(a)lists.webkit.org> wrote: >> >> >> On May 10, 2022, at 2:46 PM, Geoffrey Garen <ggaren(a)apple.com> wrote: >> >> Do I undertand correctly that the proposal here is >> >> (a) Immediately Deprecate ChangeLogs >> >> >> Yes >> >> (b) Immediately end support for posting patches from Subversion checkouts? >> >> >> We would be immediately ending support for _landing_ patches posted from a Subversion checkout. EWS would continue to accept and test patches posted from Subversion checkouts. >> >> >> Just this week, I landed 2~3 patches using a pure Subversion checkout. >> It's actually my primary method of landing patches in WebKit right >> now. >> >> >> Do you feel like 1 week is not enough time for you to do a git checkout and familiarize yourself enough with GIT to upload patches? Is that the issue? If so, how long do you feel would be reasonable? > > > I already have GitHub clones. The issue I have is with committing directly. I need to be able to commit directly as is since commit queue even fast one is simply way too slow. > >> If you’re not ready to adopt the GitHub workflow for a reason or another, git-svn / bugzilla patches is still a thing and will still work for now. Only committing from pure SVN repositories would go away in a week. > > > Well, that's precisely my use case. I don't even write a patch in a pure Subversion checkout anymore these days. > > - R. Niwa > > -- > - R. Niwa

2 2

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs
by Ryosuke Niwa 11 May '22

11 May '22

On Tue, May 10, 2022 at 10:04 PM Chris Dumez <cdumez(a)apple.com> wrote: > > On May 10, 2022, at 9:27 PM, Ryosuke Niwa <rniwa(a)webkit.org> wrote: >> >> Well, that's precisely my use case. I don't even write a patch in a pure Subversion checkout anymore these days. > > Also, I didn’t fully understand this comment. Did you mean that you are already using git-svn and relying to `git-svn dcommit` for local committing? No, I'm using Github clones to write patches then using Subversion checkout to commit those patches. - R. Niwa

2 1