August 2021 - webkit-dev - lists.webkit.org

Re: [webkit-dev] Identifiers in Log and Blame
by Jonathan Bedard 17 Aug '21

17 Aug '21

GitHub has a native blame viewer, https://github.com/WebKit/WebKit/blame/main/Makefile <https://github.com/WebKit/WebKit/blame/main/Makefile>, which doesn’t display any commit string, but seems to display significantly more useful information than what the equivalent trac view is https://trac.webkit.org/browser/webkit/trunk/Makefile?annotate=blame&rev=28… <https://trac.webkit.org/browser/webkit/trunk/Makefile?annotate=blame&rev=28…>. Given that Trac’s view makes it difficult to copy revision numbers and would instead tend to route a user towards following a link to the blamed commit, just like GitHub, I don’t think trying to integrate this solution to GitHub’s blame UI makes sense. Also, the technical challenges of doing so are likely to be considerable. Jonathan > On Aug 17, 2021, at 11:18 AM, Ryosuke Niwa <ryosuke.niwa(a)gmail.com> wrote: > > Seems like a good improvement but I really don't use command line tools to see my blame. What I need is this getting applied to a online tools like trac and GitHub. > > On Tue, Aug 17, 2021 at 10:57 AM Jonathan Bedard via webkit-dev <webkit-dev(a)lists.webkit.org <mailto:webkit-dev@lists.webkit.org>> wrote: > Hi folks, > > As we move towards using Git as our version control system, more services and scripts will be using identifiers instead of revisions or hashes. Already, build.webkit.org <http://build.webkit.org/>, results.webkit.org <http://results.webkit.org/> and ews-build.webkit.org <http://results.webkit.org/> all display identifiers alongside revisions. Early in the transition process, we added the git-webkit find command, which converts between hashes, revisions and identifiers. Recently, we added the git-webkit log and git-webkit blame commands to better support identifiers and native Git checkouts. > > git-webkit log is a wrapper around git log or svn log (depending on your checkout) and annotates the output of those commands with identifiers and revisions. git-webkit log passes the arguments you provide it to your native source code management system, it’s output looks something like this: > > commit 240602@main (fe5476762fc34d2a5547b7d2d8116faa7275acd7, r281148) > Author: Eric Hutchison <ehutchison(a)apple.com <mailto:ehutchison@apple.com>> > Date: Tue Aug 17 17:46:39 2021 +0000 > > [Monterey wk2 Release] performance-api/paint-timing/paint-timing-with-worker.html is a flaky crash. > rdar://82036119 <>. > ... > > git-webkit blame is a wrapper around git blame or svn blame (again, depending on your checkout) and also annotates the output of these commands with identifiers: > > 230258@main (Keith Rollin 2020-10-08 19:10:32 +0000 1) MODULES = Source Tools > 184786@main (Jonathan Bedard 2017-02-02 18:42:02 +0000 2) > 229628@main (Keith Rollin 2020-09-22 18:37:51 +0000 3) define build_target_for_each_module > 229628@main (Keith Rollin 2020-09-22 18:37:51 +0000 4) for dir in $(MODULES); do \ > 229628@main (Keith Rollin 2020-09-22 18:37:51 +0000 5) ${MAKE} $@ -C $$dir PATH_FROM_ROOT=$(PATH_FROM_ROOT)/$${dir}; \ > 229628@main (Keith Rollin 2020-09-22 18:37:51 +0000 6) exit_status=$$?; \ > 229628@main (Keith Rollin 2020-09-22 18:37:51 +0000 7) [ $$exit_status -ne 0 ] && exit $$exit_status; \ > 229628@main (Keith Rollin 2020-09-22 18:37:51 +0000 8) done; true > 229628@main (Keith Rollin 2020-09-22 18:37:51 +0000 9) endef > ... > > Both commands can switch the commit representation they display with the --identifier, --hash and --revision options. > > Additionally, for those using Git checkouts, the conversion from Subversion revisions to Git hashes no longer requires your checkout to be configured with git-svn. Contributors may find that something like git checkout r281146 satisfies whatever need they have to interact with Subversion from Git. > > All of this has been landed on trunk/main as of r280864/240404@main. > > Jonathan > _______________________________________________ > webkit-dev mailing list > webkit-dev(a)lists.webkit.org <mailto:webkit-dev@lists.webkit.org> > https://lists.webkit.org/mailman/listinfo/webkit-dev <https://lists.webkit.org/mailman/listinfo/webkit-dev>

1 0

Identifiers in Log and Blame
by Jonathan Bedard 17 Aug '21

17 Aug '21

Hi folks, As we move towards using Git as our version control system, more services and scripts will be using identifiers instead of revisions or hashes. Already, build.webkit.org <http://build.webkit.org/>, results.webkit.org <http://results.webkit.org/> and ews-build.webkit.org <http://results.webkit.org/> all display identifiers alongside revisions. Early in the transition process, we added the git-webkit find command, which converts between hashes, revisions and identifiers. Recently, we added the git-webkit log and git-webkit blame commands to better support identifiers and native Git checkouts. git-webkit log is a wrapper around git log or svn log (depending on your checkout) and annotates the output of those commands with identifiers and revisions. git-webkit log passes the arguments you provide it to your native source code management system, it’s output looks something like this: commit 240602@main (fe5476762fc34d2a5547b7d2d8116faa7275acd7, r281148) Author: Eric Hutchison <ehutchison(a)apple.com> Date: Tue Aug 17 17:46:39 2021 +0000 [Monterey wk2 Release] performance-api/paint-timing/paint-timing-with-worker.html is a flaky crash. rdar://82036119. ... git-webkit blame is a wrapper around git blame or svn blame (again, depending on your checkout) and also annotates the output of these commands with identifiers: 230258@main (Keith Rollin 2020-10-08 19:10:32 +0000 1) MODULES = Source Tools 184786@main (Jonathan Bedard 2017-02-02 18:42:02 +0000 2) 229628@main (Keith Rollin 2020-09-22 18:37:51 +0000 3) define build_target_for_each_module 229628@main (Keith Rollin 2020-09-22 18:37:51 +0000 4) for dir in $(MODULES); do \ 229628@main (Keith Rollin 2020-09-22 18:37:51 +0000 5) ${MAKE} $@ -C $$dir PATH_FROM_ROOT=$(PATH_FROM_ROOT)/$${dir}; \ 229628@main (Keith Rollin 2020-09-22 18:37:51 +0000 6) exit_status=$$?; \ 229628@main (Keith Rollin 2020-09-22 18:37:51 +0000 7) [ $$exit_status -ne 0 ] && exit $$exit_status; \ 229628@main (Keith Rollin 2020-09-22 18:37:51 +0000 8) done; true 229628@main (Keith Rollin 2020-09-22 18:37:51 +0000 9) endef ... Both commands can switch the commit representation they display with the --identifier, --hash and --revision options. Additionally, for those using Git checkouts, the conversion from Subversion revisions to Git hashes no longer requires your checkout to be configured with git-svn. Contributors may find that something like git checkout r281146 satisfies whatever need they have to interact with Subversion from Git. All of this has been landed on trunk/main as of r280864/240404@main. Jonathan

2 1

Request for position: supports(<font-technology>) extended syntax for @font-face
by Dominik Röttsches 16 Aug '21

16 Aug '21

Hi @ webkit-dev, hi Myles, we'd like to know your opinion on the extended supports(<font-technology>) syntax of the @font-face src: descriptor. - Specification or proposal URL: https://drafts.csswg.org/css-fonts-4/#font-face-src-parsing, in particular the [ format(<font-format> <https://drafts.csswg.org/css-fonts-4/#font-format-values> [supports <font-technology> <https://drafts.csswg.org/css-fonts-4/#font-technology-values>#]?)]? part of the spec. The changes have originally been approved / developed in the CSS WG process already. As we're considering shipping this feature, we'd like to know if Apple is considering implementing support as well. - CSS WG Resolution for issue #633 <https://github.com/w3c/csswg-drafts/issues/633> initially adding format() and supports() syntax - CSS WG change in issue #6340 <https://github.com/w3c/csswg-drafts/issues/6340> to clarify parsing rules for supports syntax Is this something you're considering developing / shipping in WebKit? As Myles has been an active contributor in the proposal in issue #633, I am hoping we have your support on this matter. Thanks in advance, Dominik

2 2

Position on font-family: emoji (and -webkit-pictograph)
by Frédéric Wang 13 Aug '21

13 Aug '21

Hi, In 2011, a font-family: -webkit-pictograph was implemented in WebKit [1]. However a new "font-family: emoji" value was added in the CSS Fonts Module Level 4 spec [3]. I understand there is backward compat concerns about removing features but do we agree to add "emoji" as an alias for "-webkit-pictograph", similar to what we did in [3] for "system-ui"? Thanks, [1] https://bugs.webkit.org/show_bug.cgi?id=65197 [2] https://drafts.csswg.org/css-fonts/#font-family-prop [3] https://bugs.webkit.org/show_bug.cgi?id=151493 -- Frédéric Wang

2 1

Request for position: Clipboard API SVG support
by Wenson Hsieh 13 Aug '21

13 Aug '21

Hi Darwin! Adding the SVG MIME type ("image/svg+xml") to the list of web-safe clipboard types (currently plain text, URLs, and HTML) seems reasonable, provided that the UA is able to sanitize the SVG payload (similar to what we do for HTML, currently). On Cocoa platforms, this would probably be bridged to and from the OS in the form of (sanitized) data corresponding to the UTTypeSVG universal type identifier on the platform pasteboard. As an aside — since SVG documents are parsed using the XML parser as opposed to the HTML parser, supporting SVG as a web-safe clipboard type will be a bit more involved than simply adding "image/svg+xml" to the list of known UA clipboard types and using the current HTML sanitization algorithm. — Wenson > Looking for a position on adding svg support for the async clipboard API > (ex. `navigator.clipboard.write`), in a similar manner to the HTML support > <https://webkit.org/blog/10855/async-clipboard-api/ <https://webkit.org/blog/10855/async-clipboard-api/>> already added. Thank > you! > > * Base Specification Title: Clipboard API and events > <https://www.w3.org/TR/clipboard-apis/ <https://www.w3.org/TR/clipboard-apis/>> > * Specification or proposal URL: Explainer here > <https://docs.google.com/document/d/1Rx7gi01avpRRNYKSpp3U4WQdjery0H0IkX2XxDt… <https://docs.google.com/document/d/1Rx7gi01avpRRNYKSpp3U4WQdjery0H0IkX2XxDt…>> > Other information: > * https://www.chromestatus.com/feature/5125790490427392 <https://www.chromestatus.com/feature/5125790490427392> has more links > * https://github.com/w3c/editing/issues/305 <https://github.com/w3c/editing/issues/305> may also be relevant > > -- > - Darwin Huang >

1 0

Position on font-family: math
by Frédéric Wang 13 Aug '21

13 Aug '21

Hello WebKittens, I'd like to get opinion about implementing "font-family: math": https://www.w3.org/TR/css-fonts-4/#valdef-font-family-math This is a generic font family name from CSS fonts level 4, which is exactly doing what we need for MathML to get a default user-customizable math font (instead of the hardcoded values we currently have in the mathml.css UA sheet). See also https://webkit-search.igalia.com/webkit/rev/b28eaa8f270a9223d76cc4da9072d42… https://trac.webkit.org/wiki/MathML/Fonts#CustomizingMathFont https://bugs.webkit.org/show_bug.cgi?id=156843 -- Frédéric Wang

1 0

Re: [webkit-dev] Request for position: CSS @font-face descriptor advance-override
by Dominik Röttsches 09 Aug '21

09 Aug '21

As an update to our intent here. as posted by Xiaocheng earlier, we're planning to ship the size-adjust descriptor <https://drafts.csswg.org/css-fonts-5/#size-adjust-desc>. On Mon Feb 22 16:50:28 PST 2021 Xiaocheng Hu xiaochengh(a)chromium.org wrote: Hi webkit-dev, > This is a request for WebKit's position on a new descriptor > 'advance-override' of the CSS @font-face rule. > This is a new feature that the CSSWG just added into CSS Fonts Level 5 for > reducing layout shifting caused by web fonts. Chrome has already > implemented it in M90 behind a flag. > > Explainer: > https://gist.github.com/xiaochengh/3aae8a97d1b0388c8e701819b63e2c49 > Spec: https://drafts.csswg.org/css-fonts-5/#font-metrics-override-desc > May I assume https://github.com/w3c/csswg-drafts/pull/5991, authored by > Myles, as a positive signal? > Thank you!

2 1

2021 WebKit Contributors Meeting - Save the Date
by Jonathan Davis 06 Aug '21

06 Aug '21

Hello WebKit Contributors, You are invited to participate in a virtual WebKit Contributors Meeting hosted online via WebEx on Monday, September 27th from 1 PM to around 6 PM Pacific and Tuesday, September 28th from 8 AM to around noon Pacific. To attend you must be an active contributor to the WebKit open-source project. The meeting will be free of charge, and registration will open soon. The event will feature presentation-led discussions of 10-40 minutes long, followed by queue-moderated discussion. If you have a topic to present for discussion, please email me, or message me on WebKit Slack. There will also be a lightning talk segment if you have a topic you can present in less than 10 minutes. Feel free to reach out to me with ideas or questions on this year’s online event. Thank you, Jon Davis

1 0