August 2019 - webkit-dev - lists.webkit.org

Introducing WTF::makeUnique<T> and WTF::makeUniqueWithoutFastMallocCheck<T>
by Yusuke Suzuki 23 Aug '19

23 Aug '19

Hello WebKit folks! I would like to announce that I’ve just landed the patch which introduces `WTF::makeUnique<T>` and `WTF::makeUniqueWithoutFastMallocCheck<T>` in https://trac.webkit.org/changeset/248846 <https://trac.webkit.org/changeset/248846>. They are drop-in-replacement to std::make_unique<T>, and we should not use std::make_unique<T> after that patch is introduced. I’m planning to add cpplint check for `std::make_unique` to avoid the use of that. The motivation behind this change is the following. 1. Our typical way of allocating heap memory is three-fold. Using containers (Vector etc.), RefCounted, and std::unique_ptr. 2. Containers and RefCounted are covered well by FastMalloc. 3. But std::unique_ptr case, we missed using FastMalloc in many places so far. Even in very recently written code, we missed FastMalloc annotation. For example, we sometimes create a data structure just like a struct, and allocate it with make_unique. struct XXXData { ... }; m_data = std::make_unique<XXXData>(); We missed WTF_MAKE_STRUCT_FAST_ALLOCATED annotation in XXXData so frequently so that the allocation of XXXData ends up being allocated from system-malloc. This WTF::makeUnique adds one `static_assert` over std::make_unique: the static_assert ensures T is FastMalloced or IsoHeap-allocated. Otherwise, we see compile-error. This mechanism surprisingly found so many classes that do not have WTF_MAKE_FAST_ALLOCATED / WTF_MAKE_STRUCT_FAST_ALLOCATED in our code base. If the type T comes from ThirdParty and if we cannot annotate T with FAST_ALLOCATED, we can use WTF::makeUniqueWithoutFastMallocCheck explicitly as a fallback. More detailed explanation behind why we took this design (instead of allocating FastMalloced-memory automatically when using makeUnique<T>() etc.) is described in ChangeLog in https://trac.webkit.org/changeset/248846/webkit <https://trac.webkit.org/changeset/248846/webkit>. I already annotated missed structs / classes with WTF_MAKE_FAST_ALLOCATED in https://trac.webkit.org/changeset/248762 <https://trac.webkit.org/changeset/248762>. So, now I think 99% of allocations in WebKit-itself are handled well by FastMalloc. -Yusuke

4 4

EWS bubbles not loading for some users
by Aakash Jain 22 Aug '19

22 Aug '19

Hi Everyone, There were some DNS changes done yesterday for webkit.org <http://webkit.org/>. It seems to be causing EWS bubbles not to load for some users. For those users, https://ews.webkit.org <https://ews.webkit.org/> is redirecting to bugs.webkit.org <http://bugs.webkit.org/> instead of displaying 'EWS for WebKit.' This issue seems to be affecting new EWS, but not the old EWS (so 'style', 'jsc' and 'win' bubbles might still show up). We are actively looking into it. Thanks Aakash

1 1

PSA: EWS bots aperez-{gtk, wpe}-ews down for the weekend
by Adrian Perez de Castro 19 Aug '19

19 Aug '19

Hi all, A firmware update has left my build machine unusable, but it looks recoverable. I will try to get it back running next Monday when I am back at the office (I will need physical access). Sorry about the inconvenience. Cheers, -Adrián

1 2

Disabling keygen element by default
by Ryosuke Niwa 17 Aug '19

17 Aug '19

Hi all, HTML keygen element had been removed from Chrome since 2017, and Firefox recently removed it in Firefox 69: https://bugzilla.mozilla.org/show_bug.cgi?id=1315460 I've put a patch up to disable keygen element by default on https://bugs.webkit.org/show_bug.cgi?id=200850. - R. Niwa

1 0

John Wilander is a WebKit reviewer
by Alex Christensen 16 Aug '19

16 Aug '19

I’m pleased to announce that John Wilander is now a WebKit reviewer. John has been working on WebKit for several years now, and has done a lot of work on Intelligent Tracking Prevention and other security-related features. Please join me in congratulating him! - Alex Christensen

1 0