August 2010 - webkit-dev - lists.webkit.org

Re: [webkit-dev] Canvas performance and memory usage
by Martin Robinson 14 Sep '10

14 Sep '10

Resent from the proper address: On Tue, Aug 3, 2010 at 6:00 PM, Martin Robinson <martin.james.robinson(a)gmail.com> wrote: >> I notice that Qt added imageForRendering() and felt they could not use >> image() for some reason. I'd be curious if a Qt expert could weigh in on >> that, since maybe with a redesign a separate call would not be needed. I'm not a Qt expert, but just based on a quick look, it seems that imageForRendering avoids the full QPixmap copy. Christophe, when you open a bug for this issue, please CC me, as I have a small patch in my tree which has the same imageForRendering pecialization, but for Cairo. Martin

8 15

SIL Open Font License and WebKit
by Alex Milowski 10 Sep '10

10 Sep '10

We have a licensing issue we need to address for MathML. We need the STIX fonts as they will provide consistent rendering for Mathematics. I highly suspect these fonts will find themselves on our desktops somewhere down the road. Meanwhile, we need them for our testing infrastructure to actually work across all the platforms. The STIX Fonts are available under the SIL Open Font License: http://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&item_id=OFL_web You can see the patch that adds these fonts here: https://bugs.webkit.org/show_bug.cgi?id=41961 I think we need to adjust our licensing policy to include font licenses like the above. It is unlikely that the STIX consortium will change their font licensing. In reality, they don't need to do so. The font license is intended to support "open source" fonts. -- --Alex Milowski "The excellence of grammar as a guide is proportional to the paucity of the inflexions, i.e. to the degree of analysis effected by the language considered." Bertrand Russell in a footnote of Principles of Mathematics

8 20

[svg] rect with invalid stroke value
by Yuzo Fujishima 08 Sep '10

08 Sep '10

Hi, SVG gurus, I have a question regarding LayoutTests/svg/custom/invalid-fill-hex.svg . It contains: <rect width="100" height="100" fill="#ff" stroke="#0"/> From the comment there I understand that the rect should be filled with black. But how about the stroke? I guess black stroke should be rendered, because #0 is also invalid. Is it true? The current test data (expected output) doesn't contain the stroke. I'm asking this https://bugs.webkit.org/show_bug.cgi?id=24742 fixes hex color parsing and as a result, the stroke above starts to be rendered with black. I'd like to find out whether the above test (or test data) is wrong or I am making a mistake. I think we should either: Rewrite <rect width="100" height="100" fill="#ff" stroke="#0"/> to <rect width="100" height="100" fill="#ff"> or rebaseline the test data. Which do you prefer (assuming the test needs to be changed?) Yuzo

5 10

Re: [webkit-dev] Throwing SECURITY_ERR on cross-origin window.location property accesses
by Rob Barreca 07 Sep '10

07 Sep '10

On Mon, Aug 16, 2010 at 2:16 PM, Sam Weinig <sam.weinig at gmail.com> wrote: > I am not sure I agree. Does our behavior actually cause any real bugs in > the places you have tracked down? The log spam really doesn't seem like an > issue, we can remove it if we want to, but have found it useful in the > past. There is definitely a bug and a real-world use case for this for WebKit. At Sprout (http://sproutinc.com) we have a generic platform to design mobile HTML5 ads which are served inside an IFRAME. We allow designers to link elements in top window and new window. If they choose "top window", in Android 2.2 when we do "window.top.location.href = url" instead of going to the URL or just halting code execution, the browser refreshes the current top-level page. We need a way to test for the security exception or at least detect some other property of window.top and then do window.open(url) instead when that security error is trapped or we detect different-origin. -- Rob Barreca Director of Development Sprout, Inc. Mobile: 808.224.1905 Confidential and Proprietary Property of Sprout; Do not distribute. The information contained in this email is confidential. This information is intended for use only by the individual to whom it is addressed. If you are not the intended recipient, you are hereby notified that any use, dissemination, distribution or copying of this communication and its contents is strictly prohibited. If you have received this email in error, please immediately notify the sender by return email and delete this email and attachments, and destroy all copies.

3 4

Access to blog admin page
by Ryosuke Niwa 05 Sep '10

05 Sep '10

Hi, I wrote http://rniwa.wordpress.com/2010/08/31/pushing-inline-styles-in-webkit/ and a lot of my colleagues liked it so I'd like to post it on WebKit blog. I registered myself as rniwa on WordPress but I don't have admin rights. Could appropriate authority give me a permission to post? Ryosuke Niwa Software Engineer Google Inc.

3 2

WebKit2 SharedSecondaryProcess model
by Balazs Kelemen 04 Sep '10

04 Sep '10

Hi all! I am wondering about do you plan for the mac and win to support the shared web process model? Actually, I have played around with that for Qt. I have a working, proof of concept implementation. The visited links and the back-forward list features are broken, but apart from that the browsers are working with the shared web process. I had to rework common parts of the code for achieving that, and I would like to contribute it in small parts. I think if we want to support that model in the future than we should start to implement it as soon as possible to assure that our design fits the needs of that. Cheers! Balazs Kelemen

6 8

Script programming language: Perl, Python, or Ruby?
by TAMURA, Kent 02 Sep '10

02 Sep '10

Do we have any recommendation of programming language for scripts such as WebKitTools/Scripts? It seems new scripts are written by Python and Ruby code is very rare. Is it reasonable to port a Ruby script to Python? I tried to port PrettyPatch.rb to Python in https://bugs.webkit.org/show_bug.cgi?id=43617 in order to remove Ruby dependency for many developers and buildbots. However bdash objected it. -- TAMURA Kent Software Engineer, Google

9 15

Complex and Vector3 classes in WTF?
by Chris Marrin 01 Sep '10

01 Sep '10

I just noticed these classes, added 7 months ago as part of Chris Rogers' audio work. I think it's a mistake to have these in WTF for a few reasons: 1) Complex is just std::complex with a single added function, complexFromMagnitudePhase(), which seems pretty audio specific, so it should go with the audio code 2) Vector3 has a name very similar to Vector, but with completely different functionality. I actually opened wtf/Vector.h thinking I was going to see a 2D Vector class (because I was in that mindset), then I remembered the _other_ meaning of Vector! So I think it's pretty confusing. 3) Vector3 goes along with other classes, like 2D point, matrices and maybe even lines, planes and other geometry related things. Right now we have FloatPoint2D, FloatPoint3D and TransformationMatrix in WebCore/platform/graphics. These should all be together. I think we should move Complex.h over to live with the rest of the Chris' audio code. Vector3 is a more complex ( ! ) issue. Should we move all the geometry related classes to WTF? If we did I think that should include all the Rect and Box classes as well. Or should we get rid of Vector3, added the functionality it needs to FloatPoint3D and use that? Ken Russell already has plans to do add the functions to FloatPoint3D, so I would vote for that. There's one other problem. Vector3 uses doubles, while FloatPoint3D uses floats. Chris, do you need doubles for your use, or would floats suffice? What do others think? ----- ~Chris cmarrin(a)apple.com

6 20

Problems to build WebKit on Windows
by Diego Gonzalez 01 Sep '10

01 Sep '10

Hi folks, I have some problems to build WebKit ToT on my Window Env. I'm using Visual C++ express 2005. I've followed the steps win: http://webkit.org/building/tools.html After it I ran update-webkit and build-wekit script I got this build output: http://pastebin.com/x99zta73 Some build errors like: InspectorStorageAgent.cpp ..\inspector\InspectorStorageAgent.cpp(64) : error C2039: 'sqlTransactionFailed' : is not a member of 'WebCore::InspectorFrontend' C:\cygwin\home\rodribel\webkit\WebKitBuild\obj\WebCore\DerivedSources\InspectorFrontend.h(17) : see declaration of 'WebCore::InspectorFrontend' ..\inspector\InspectorStorageAgent.cpp(98) : error C2039: 'sqlTransactionSucceeded' : is not a member of 'WebCore::InspectorFrontend' C:\cygwin\home\rodribel\webkit\WebKitBuild\obj\WebCore\DerivedSources\InspectorFrontend.h(17) : see declaration of 'WebCore::InspectorFrontend' and SVGCSSStyleSelector.cpp c:\cygwin\home\rodribel\webkit\webcore\css\CSSPrimitiveValueMappings.h(2217) : error C2065: 'CSSValueButt' : undeclared identifier c:\cygwin\home\rodribel\webkit\webcore\css\CSSPrimitiveValueMappings.h(2231) : error C2051: case expression not constant c:\cygwin\home\rodribel\webkit\webcore\css\CSSPrimitiveValueMappings.h(2249) : error C2065: 'CSSValueMiter' : undeclared identifier c:\cygwin\home\rodribel\webkit\webcore\css\CSSPrimitiveValueMappings.h(2255) : error C2065: 'CSSValueBevel' : undeclared identifier c:\cygwin\home\rodribel\webkit\webcore\css\CSSPrimitiveValueMappings.h(2263) : error C2051: case expression not constant c:\cygwin\home\rodribel\webkit\webcore\css\CSSPrimitiveValueMappings.h(2267) : error C2051: case expression not constant c:\cygwin\home\rodribel\webkit\webcore\css\CSSPrimitiveValueMappings.h(2281) : error C2065: 'CSSValueNonzero' : undeclared identifier c:\cygwin\home\rodribel\webkit\webcore\css\CSSPrimitiveValueMappings.h(2284) : error C2065: 'CSSValueEvenodd' : undeclared identifier seems to be related with features disabled (e.g. database, svg) but these featrues were not disabled for the build. As I do not have experience with these Windows build tools, I wonder if someone could give me some directions to get this build ok. Thanks, Diego

4 5

Re: [webkit-dev] Misplaced files
by Jeremy Orlow 31 Aug '10

31 Aug '10

On Tue, Aug 31, 2010 at 5:57 PM, Yaar Schnitman <yaar(a)chromium.org> wrote: > No, the file names. The module part matters when IDLs refer to each other > (typedefs and includes) - but these are easy to fix. Can you give an example of what you're talking about? I can't remember seeing anything like this in the past. Also, is there a reason why they're necessary? > On Tue, Aug 31, 2010 at 9:00 AM, Jeremy Orlow <jorlow(a)chromium.org> wrote: > >> You're talking about the "module" part of the IDL? Is that even used by >> anything or specified anywhere? As far as I can tell, the answer is no. >> >> >> On Tue, Aug 31, 2010 at 4:54 PM, Yaar Schnitman <yaar(a)chromium.org>wrote: >> >>> Regarding renaming files: The .cpp and .h file names need to correspond >>> with .idl names, which in turn correspond with the interfaces specified in >>> these .idl. The later are standard, user-facing strings. >> >> Sure... but the _directories_ are not user facing. That's all we're talking about here. > This means that you can't change them without fixing a lot of generation >>> and build rules. If your goal is reducing complexity, this might not be a >>> good idea. >>> >>> On Tue, Aug 31, 2010 at 3:02 AM, Jeremy Orlow <jorlow(a)chromium.org>wrote: >>> >>>> On Mon, Aug 30, 2010 at 5:17 PM, Darin Fisher <darin(a)chromium.org>wrote: >>>> >>>>> On Mon, Aug 30, 2010 at 9:11 AM, Maciej Stachowiak <mjs(a)apple.com>wrote: >>>>> >>>>>> >>>>>> On Aug 30, 2010, at 8:36 AM, Darin Fisher wrote: >>>>>> >>>>>> On Mon, Aug 30, 2010 at 12:18 AM, Adam Barth <abarth(a)webkit.org>wrote: >>>>>> >>>>>>> On Fri, Aug 27, 2010 at 8:12 PM, Maciej Stachowiak <mjs(a)apple.com> >>>>>>> wrote: >>>>>>> > Yes. The file-related stuff should all be in one directory, I >>>>>>> think. >>>>>>> >>>>>>> Ok. I moved the files from WebCore/html to WebCore/fileapi. >>>>>>> >>>>>>> On Aug 27, 2010, at 6:19 PM, Kinuko Yasuda wrote: >>>>>>> > We have bunch of FileSystem (which is a part of File API) related >>>>>>> files in >>>>>>> > WebCore/storage/. >>>>>>> > Maybe we should move them to the new directory too? >>>>>>> >>>>>>> Are these the files you're talking about? >>>>>>> >>>>>>> WebCore/storage/DOMFilePath.cpp >>>>>>> WebCore/storage/DOMFilePath.h >>>>>>> WebCore/storage/DOMFileSystem.cpp >>>>>>> WebCore/storage/DOMFileSystem.h >>>>>>> WebCore/storage/DOMFileSystem.idl >>>>>>> WebCore/storage/FileEntry.cpp >>>>>>> WebCore/storage/FileEntry.h >>>>>>> WebCore/storage/FileEntry.idl >>>>>>> WebCore/storage/FileSystemCallback.h >>>>>>> WebCore/storage/FileSystemCallback.idl >>>>>>> WebCore/storage/FileSystemCallbacks.cpp >>>>>>> WebCore/storage/FileSystemCallbacks.h >>>>>>> WebCore/storage/LocalFileSystem.cpp >>>>>>> WebCore/storage/LocalFileSystem.h >>>>>>> >>>>>>> I'm happy to move them to WebCore/fileapi, but I'm also happy for you >>>>>>> to do it. >>>>>>> >>>>>>> Thanks, >>>>>>> Adam >>>>>>> >>>>>>> >>>>>> >>>>>> How about just moving everything into WebCore/storage? This is all >>>>>> storage-related stuff. >>>>>> >>>>>> >>>>>> I think the File API is large enough to deserve its own directory. In >>>>>> fact, it might be worth splitting up the remaining contents of the storage >>>>>> directory too. It is confusing to have large but almost entirely separate >>>>>> APIs all piled into one directory. It is true they are all >>>>>> "storage-related", but that is a pretty broad theme, and LocalStorage, SQL >>>>>> Storage, Indexed DB and File API have little or no interaction with each >>>>>> other. >>>>>> >>>>>> Regards, >>>>>> Maciej >>>>>> >>>>>> >>>>>> >>>>>> >>>>> That's fair. Plus, there are a lot of files in there already. >>>>> >>>> >>>> What names should we use? >>>> >>>> WebSQLDatabase: >>>> Like WebSockets, I think the "web" part is pretty important to keep >>>> people from getting confused. 'websqldatabase' seems a bit long though. >>>> 'websqldb' maybe? >>>> >>>> WebStorage: >>>> Currently we call this "Dom Storage" throughout the codebase (including >>>> in the ENABLE macro), so we may want to call it "domstorage". Like >>>> WebSockets and WebSQLDatabase, I think "storage" with no prefix seems like a >>>> generic storage directory so we should probably call it "webstorage" if >>>> "domstorage" isn't acceptable. >>>> >>>> Indexed Database API: >>>> "IndexedDB" is what it's commonly called, so a directory of "indexeddb" >>>> seems like the way to go. >>>> >>>> J >>>> >>>> _______________________________________________ >>>> webkit-dev mailing list >>>> webkit-dev(a)lists.webkit.org >>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >>>> >>>> >>> >> >

1 0