May 2010 - webkit-dev - lists.webkit.org

Is it OK to remove Frame::setIsDisconnected() and isDisconnected() ?
by Sverrir Á. Berg 09 Apr '12

09 Apr '12

Working on a change in FrameTree and noticed that the checks in top() and parent() for 'checkForDisconnectedFrame' rely on a flag in Frame that as far as I can tell is never set.So my naive question is: Can I remove the corresponding code from Frame and FrameTree? If not I would like if somebody could explain how they are used so I don't break anything with my change. More detail: * My search for calls to Frame::setIsDisconnected reveals no callers in WebKit, Chromium or Google code search. * This functionality is disjoint from Frame::disconnectOwnerElement(). Thanks, Sverrir

4 6

ImageLoader class
by Sergiy Byelozyorov 09 Jul '11

09 Jul '11

Hello, I am writing my own class using ImageLoader. Can somebody, please, help me with these questions: 1. How do I know that the image was loaded already? Can I set up callback somehow? 2. What should functions sourceURI() and dispatchLoadEvent() do? 3. What is pixel format for m_imageLoader.image()->image()->data()->data()? Is this the right way to access loaded image raw pixel data? 4. How can I handle animations (e.g. GIF files)? How do I know when the next image in the animation suquence is ready? Another callback? 5. Which image formats are supported? Can I add my own, like HDR? Thank you. Sergiy

1 1

parallel painting
by Zoltan Herczeg 10 Jun '11

10 Jun '11

Hi, I am working on a parallel painting feature for WebKit (bug id: 36883). Basically it records the painting commands on the main thread, and replay them on a painting thread. The gain would be that the recording operation is cheap. Currently it is Qt specific, but I could make it more platform independent if other ports are interested. Zoltan

8 10

New requirement for building on Windows coming
by Chris Marrin 19 Oct '10

19 Oct '10

I've submitted a patch for accelerated compositing support on Windows. I hope to land it today. When I do it will require d3d9.lib to link. The feature will be turned off at first, but the build still needs to find the library. So the build-bots will need to be updated with DirectX 9.0 SDK Update (December 2004): http://www.microsoft.com/downloads/details.aspx?FamilyId=4E825A37-0C94-4421… You'll also need to add a path to this SDK in your MSDev Include and Library paths. The WebKit build-bots have already been updated, but external ones should make the changes in preparation. I'll br adding this info to webkit.org today. ----- ~Chris cmarrin(a)apple.com

6 11

Re: [webkit-dev] Announcing new port: EFL
by haithem rahmani 05 Oct '10

05 Oct '10

Hi, Just a simple question: - It seems that the EFL port of webkit is based on EFL/X11 api. is there plans to support other EFL backends especially directfb ? WebkitGtk is doing that with (--with-target=directfb) option. regards. Haithem. -- Say: He is God, the One and Only; God, the Eternal, Absolute; He begetteth not, nor is He begotten; And there is none like unto Him.

2 2

webkit-patch, check-webkit-style and git now support --squash and --git-commit
by Ojan Vafai 09 Jul '10

09 Jul '10

The behavior of git and webkit-patch changed with http://trac.webkit.org/changeset/58261. Many webkit-patch commands (e.g. upload and land) and check-webkit-style now take --squash and --git-commit arguments. --git-commit: upload, commit, check-style, etc on the given git commit(s). Commits can be specified as single commits (e.g. HEAD^) or mulitiple (e.g. HEAD~2..HEAD). check-webkit-style's sense of --git-commit is no longer all patches since the commit and --git-since is removed. The equivalent to the old check-webkit-style behavior is "--git-commit=HEAD~2.." instead of just using HEAD~2. --squash: Treat all changes in the local branch as a single patch (local commits + working copy changes). Doesn't actually modify your tree until you land, at which point it squashes all local changes into a single local commit and then lands that. --no-squash: Treat all changes as separate. This is essentially just "git svn dcommit". Each local change is committed separately. If you leave out --squash and --no-squash, then something resembling the old behavior is used. old-behavior: upload, diff, create-patch, etc. only considered working-copy changes and land will commit working-copy changes and then commit each local commit separately. new-behavior: is roughly like the above, except if there's only a single local commit and no working-copy changes, then the commands will work on that single local commit and otherwise raise an error. Eventually, I'd like to make --squash the default, but I want this to bake and get some usage before flipping that switch. Finally, if you get sick of typing --squash or --no-squash, you can set the webkit-patch.squash git config parameter to true/false. Ojan

8 17

On adding 'console.memory' API (and about the whole 'console' object.)
by Mikhail Naganov 07 Jul '10

07 Jul '10

Greetings, WebKit deveopers, As a response to requests from web apps developers, I was intended to add a simple API for accessing web app's memory consumption, see https://bugs.webkit.org/show_bug.cgi?id=39646 The scenario of using this API is as follows: - a builbot runs web app's common usage scenarios tests; - inside tests, memory usage is recorded via the API proposed; - the results are sent to a server (using XHR or a CGI request); - server plots nice graphs of memory usage status, bound to the changes made to the web app; - thus, if someone does a change that blows up memory usage, developers will notice. As Sam points out, this change may be fine, but he suggests to make it accessible only when a browser runs in a special "developer" mode. This can also be applied to the whole 'console' object. Please, share your thoughts on this.

9 19

Directory upload experimental feature
by John Gregg 21 Jun '10

21 Jun '10

Hi WebKit, I recently proposed adding directory upload support to HTML via a new <input> attribute to whatwg@, and the discussion arrived at "try it out". Having written some code I think I have something that works pretty well, and I'd like to land it on an experimental basis in WebKit, but want to reach out early before trying to put any code in the tree. The plan that comes to mind is a new ENABLE_DIRECTORY_UPLOAD flag, but I'm completely open to other options. Background (cf. the whatwg thread http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2010-April/025764.html ): - The use case for this is a photo album or file manager web application, which wants the user to easily choose an entire directory to recursively upload, while preserving the sub-directory structure. - The reason for the new attribute is to signal the UA to show a native folder-picker rather than a file-picker, which on most OSs are two distinct dialogs. The approach I'm using has 2 parts and is a small amount of WebCore code (about 200 lines). - Extend HTMLInputElement to support the directory attribute, which is passed up via FileChooser allowing the UA to display a folder-picker. UA enumerates all the files and returns them in the normal way. - Extend File to have a File.path property, which contains the path information starting from the chosen directory as the root. HTMLInputElement is responsible for generating these values from the list of files when the directory attribute is set. Thoughts? Thanks, -John

4 7

Table hit testing
by Fady Samuel 19 Jun '10

19 Jun '10

Hi all, I'm looking at table hit testing, and in all the simple test cases I've tried, it seems to show that RenderTable never has the flag m_hasOverflowClip set to true. What this means is that all the table's children are ALWAYS checked on all mouse events. For large tables, or pages with many tables, this sounds awfully taxing on the processor for no good reason. See RenderTable::nodeAtPoint in third_party/WebKit/WebCore/rendering/RenderTable.cpp . It seems "hasOverflowClip()" is always false. Can we not compute a bounding box for the table on layout? Are there any complications here that I should be aware of that resulted in this inefficient solution? Thanks, Fady Samuel

4 21

beforeinput and input events for contenteditable/designMode
by Ojan Vafai 17 Jun '10

17 Jun '10

We'd like to implement this event and want to make sure there's no opposition before moving forward. I don't expect this to require huge rewrites to current webkit code, but it will definitely require some plumbing to make it so that all user-gestures that modify the DOM go through this codepath. The proposal is that the input event be fired for any user-gesture that results in a modification to the DOM. This matches the input event for text controls. We'd like to add an 'action' property (open to better names) that indicates what the user-gesture was (e.g. paste, deleteword, undo, inserttext, etc). The goal is to simplify monitoring of changes to rich-text regions and to enable use-cases where the data is stored in a different model than HTML. This is needed so that, for example, an undo operation can be applied correctly on the model as well as the DOM. The beforeinput event would fire before the DOM is modified and is cancelable. I don't think this should be too much more work than adding the input event, an exception might need to be made for IME input here though. Specifically, it might be hard to make IME events cancelable. More details: https://bugs.webkit.org/show_bug.cgi?id=26526 Initial whatwg thread: http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-June/020553.html Hixie's response: http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-July/021101.html Ojan

2 3