August 2009 - webkit-dev - lists.webkit.org

Calling All Reviewers
by Eric Seidel 09 Aug '09

09 Aug '09

The queue is out of control again. :( https://bugs.webkit.org/buglist.cgi?field0-0-0=flagtypes.name&type0-0-0=equ… I've tried. But I just can't bring it down alone. :( It's full of lots of port and other fringe related patches. Many of which need to be r-'d. -eric

6 8

checking style for patches automatically [was: Calling All Reviewers]
by David Levin 07 Aug '09

07 Aug '09

Running check-webkit-style automatically as an fyi -- maybe during prepare-ChangeLog -- would be cool. Personally, I thought it would be good to let it have a little more time to bake before doing this. dave On Fri, Aug 7, 2009 at 3:37 PM, Joe Mason <joe.mason(a)torchmobile.com> wrote: > Adam Treat wrote: > >> On Friday 07 August 2009 05:51:57 pm Eric Seidel wrote: >> >>> We also definitely need to fix our tools to make it impossible to post a >>> patch w/o a ChangeLog, and impossible to post a patch that doesn't pass >>> check-webkit-style. >>> >> >> This is a bad idea. check-webkit-style still has false positives and is >> very new. It has been designed to never be free of false positives in fact. >> > > Not to mention there will always be places where human judgement overrides > the guidelines. > > > Joe > > _______________________________________________ > webkit-dev mailing list > webkit-dev(a)lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >

2 1

What level of CSS selectors does WebKit support?
by Piotr Dobrogost 07 Aug '09

07 Aug '09

Hi What level of CSS selectors does WebKit support? Thanks in advance. -- Piotr Dobrogost *** curlpp.org - c++ wrapper for libcurl ***

2 1

undefined reference to findXXXX functions
by Yin Xiaobing 07 Aug '09

07 Aug '09

i am building webkit under archlinux using latest source package. it's pop errors when do: CCLD Programs/GtkLauncher ./.libs/libwebkit-1.0.so: undefined reference to `findEntity(char const*, unsigned int)' ./.libs/libwebkit-1.0.so: undefined reference to `findColor(char const*, unsigned int)' ./.libs/libwebkit-1.0.so: undefined reference to `findProp(char const*, unsigned int)' ./.libs/libwebkit-1.0.so: undefined reference to `findValue(char const*, unsigned int)' ./.libs/libwebkit-1.0.so: undefined reference to `findDoctypeEntry(char const*, unsigned int)' can anyone gove some hints.

1 0

WebKit port to Sony Ericsson phones in progress
by Pileryd, Björn 07 Aug '09

07 Aug '09

Hello everybody! We are a team of developers at Sony Ericsson Mobile Communications, creating a new port of WebKit. This port is using the OPA platform from ST Ericsson as operating-system and toolkit-level dependencies. The underlying operating system is OSE from Enea. In short we will call it "the OPA port". This port is still under development and is not yet ready for release. However we are making good progress and are very impressed with WebKit. We would like to introduce some members of our team that may be asking questions and joining discussions on this mailing list in the future. Björn Pileryd (bjorn.pileryd(a)sonyericsson.com) - My responsibility is the software module at SEMC that contains the WebKit library for the OPA based phones. I am involved in the design and implementation of stuff all the way from WebCore up to our UI. Henrik Baard (henrik.baard(a)sonyericsson.com) - Have done work on the OPA port, now investigating WebKit Browser on the Android platform. More members will introduce themselves as they get back to office from their vacations. If you have any questions about this port, we will do our best to answer them. Best regards, The WebKit team at Sony Ericsson

1 0

Why WAP?
by Eric Seidel 07 Aug '09

07 Aug '09

Why do we have patches for WAP support? WAP is big in asian markets, yes? Can someone provide some data as to how big? Is the market for WAP growing? It seems that the various posted -wap- patches have limited utility for the rest of WebKit. It seems to me (although I am the first to admit ignorance here!) that WAP is a dying technology and I don't see why we would want to add the complexity to WebKit. I worry the proposed WAP support patches violate some of our non-goals. http://webkit.org/projects/goals.html WebKit is an engineering project not a science project.*WebKit is not the solution to every problem. * -eric

3 2

strange problem when inserting nodes to DOM tree
by Luka Napotnik 06 Aug '09

06 Aug '09

Hello. I have strange problems when HTMLParser tries to insert new nodes. And as a result, the HTML page isn't rendered correctly. The ContainerNode::addChild() returns NULL on "#text" and "HTML" nodes. The second problem is in HTMLParser::parseToken(). There's a token that gets into the parseToken() method which contains basically the whole HTML page without the HTML tag elements. So it looks parsed and includes javascript code that is a part of the HTML page. Any ideas on what's going on or what could cause this action? Greets, Luka

1 0

WebKit[] Webpage Font and image rendering issues
by Veerabhadra Sheelavant 06 Aug '09

06 Aug '09

Hi , I have ported WebKit to ARM board. The web pages are not rendering properly...I am using pango fonts . I have noticed two issues.... 1. When I open google page ... These appear extermely small.. Web Images Videos Maps News Shopping Gmail more ▼ I have put some prints and noted that In the function FontPlatformData::FontPlatformData() fontDescription.computedSize calculated as 6.0. and another case it calculated as computedSize=1000000.000000. Let me know if these values are OK .. Note : I hard coded to 16.0 and the fonts appear correctly... 2. When I open the google page google image does not appear. but when I give $Gtklauncher http://www.google.com/intl/en_ALL/images/logo.gif the image appears. What can be the cause for the above issues...any pointers... thanks in advance rgds, Veer "DISCLAIMER: This message is proprietary to Aricent and is intended solely for the use of the individual to whom it is addressed. It may contain privileged or confidential information and should not be circulated or used for any purpose other than for what it is intended. If you have received this message in error,please notify the originator immediately. If you are not the intended recipient, you are notified that you are strictly prohibited from using, copying, altering, or disclosing the contents of this message. Aricent accepts no responsibility for loss or damage arising from the use of the information transmitted by this email including damage from virus."

1 0

WinCE Font work
by Dan Bernstein 05 Aug '09

05 Aug '09

Hi, Today while looking at the patch at <https://bugs.webkit.org/show_bug.cgi?id=28021 > I noticed that the WinCE version of FontCustomPlatformData includes CachedFont.h and uses CachedFont. It is incorrect for classes in the platform layer to have any knowledge of higher WebCore layers (essentially, anything outside the platform hierarchy). In this case, it also necessitated a platform difference in the createFontCustomPlatformData call site in CachedFont::ensureCustomFontData(), which is how I noticed it. I think once you should correct this and any other layering violations in the WinCE platform layer, and only then submit patches with changes to cross-platform code, if any such changes are still deemed necessary. I don’t think <https://bugs.webkit.org/show_bug.cgi? id=27734> and <https://bugs.webkit.org/show_bug.cgi?id=28021> should be reviewed until then. Thanks, —Dan

2 1

useless mov instructions
by Ágoston Róbert 05 Aug '09

05 Aug '09

hi! I just experiment with squirrelfish bytecode generating, and I think I find something strange. After each mov instruction, where the source is a constant register, there is an other mov instruction, which moves the previous destination to r0. I think these instructions are useless. Is there any reason why are they generated? There is an example: js: var r_15; var r_16; var r_17; var r_18; r_15 = 1; r_16 = 2; r_17 = 3; r_17 = 4; generated: [ 0] enter [ 1] mov r-15, r1073741824 [ 4] mov r-16, r1073741824 [ 7] mov r-17, r1073741824 [ 10] mov r-18, r1073741824 [ 13] mov r0, r1073741824 [ 16] mov r-15, r1073741825 [ 19] mov r0, r-15 [ 22] mov r-16, r1073741826 [ 25] mov r0, r-16 [ 28] mov r-17, r1073741827 [ 31] mov r0, r-17 [ 34] mov r-17, r1073741828 [ 37] mov r0, r-17 [ 40] end r0 -Robert

2 1