June 2009 - webkit-dev - lists.webkit.org

Is it OK to remove Frame::setIsDisconnected() and isDisconnected() ?
by Sverrir Á. Berg 09 Apr '12

09 Apr '12

Working on a change in FrameTree and noticed that the checks in top() and parent() for 'checkForDisconnectedFrame' rely on a flag in Frame that as far as I can tell is never set.So my naive question is: Can I remove the corresponding code from Frame and FrameTree? If not I would like if somebody could explain how they are used so I don't break anything with my change. More detail: * My search for calls to Frame::setIsDisconnected reveals no callers in WebKit, Chromium or Google code search. * This functionality is disjoint from Frame::disconnectOwnerElement(). Thanks, Sverrir

4 6

debug the webkit with visual studio 2005
by 赵经纬 05 Feb '10

05 Feb '10

HI: I am an neebie, i want to debug the webkit with visual studio 2005.now i have finished the steps: 1、 *Installing the Developer Tools* <http://webkit.org/building/tools.html> 2、*Getting WebKit* <http://webkit.org/building/checkout.html> 3、*Building WebKit* <http://webkit.org/building/build.html> now i want to run webkit, i open a Cygwin Shell and type this command in the shell WebKit/WebKitTools/Scripts/run-safari --debug but the result is: ERROR:couldn't determine installed safari path setting enviroments for using microsoft visual studio 2005 x86 tools How can i debug the webkit step by step? thank you!

4 3

Should we put the webkit.org mailing lists on Gmane?
by Adam Roben 15 Dec '09

15 Dec '09

Gmane (<http://gmane.org>) provides a few features that could be useful for thewebkit.org mailing lists, including: * a nicer web interface than Mailman's * indexed search (maybe better than Mailman's, certainly at least as good, and with a better interface) * a mail-to-news gateway (good for people who like news readers) I think it would be good to put our mailing lists on Gmane (including importing the archives of the lists). If we do this, I'd suggest using the names gmane.comp.web.webkit. {dev,changes,unassigned,etc.}. This matches what other similar projects (like Chromium) have done. Getting the lists posted and imported just requires filling out a web form (for posting the lists) and sending an email (to request the import). I'm happy to take responsibility for doing this if people are in favor of it. -Adam

5 8

Sharing code between WebCore/bindings/js and WebCore/bindings/v8
by Adam Barth 03 Dec '09

03 Dec '09

I've been doing some work recently in our JavaScript bindings. As part of this work, I've noticed that WebCore/bindings/js and WebCore/bindings/v8 have drifted apart in some details. It's kind of ridiculous that we have so much duplicated code in these two folders. We should try to re-organize our bindings to share as much code as possible. 1) Where should the common code live? One option is to have: WebCore/bindings/js <--- common code WebCore/bindings/jsc <--- JSC specific WebCore/bindings/v8 <--- V8 specific 2) How much should we try to share? For example, we could have an abstracted notion of ArgList that works for both engines, or we could be happy to factor out common routines like createWindow <http://trac.webkit.org/browser/trunk/WebCore/bindings/js/JSDOMWindowCustom.…>. I presume Sam is a good contact for the JSC bindings. Who's a good contact for the V8 bindings? Thanks, Adam

4 5

Hi All (Windows WebKit through COM, focus issue)
by Mike 12 Aug '09

12 Aug '09

I just joined this list, so hopefully I'm not intruding... I recently started work on making a lightweight browser for WebKit on Windows through COM+.NET, which actually has been a great success. I'm happy to report that I'm able to use the latest nightly build (r39553) from within a .NET Windows Form. I don't mind publishing the wrapper in the future to help further the development of WebKit, but I'm having an issue which is preventing me from moving forward... To sum it up the best I can, if I have a WebView on a form, and I call "setHostWindow" with that form's handle, I experience no behavioral issues. If I create a panel on the form, and I use that as the host handle, the WebView works as designed. But, if I create a tab control and add multiple tab pages, and use panels on those tabs to host the control, when the form is active, the WebView does not act as if it is active (it doesn't display the cursor for text boxes and other fields, and the safari theme for the scroll bar does not light up). The first tab page works properly, but the other tab pages display this behavior. Example of appropriate behavior on the first tab... form is active, control shows proper focus http://img49.imageshack.us/img49/9758/example1rc5.jpg The second tab, when it's active (and the form is active), the WebView control doesn't show proper focus, and the text box does not show the focus ring correctly either... http://img530.imageshack.us/img530/4653/example2tg6.jpg I think the easiest way to fix this problem, would be to allow manual control of the "active state" of the WebView control through the COM interface. Manually setting the state through events that fire on the Windows forms would be an incredibly easy task. But, I'm not sure how difficult it is to change the base code (if there's a lot of hoops to jump through), or whether or not it's actually appropriate to solve this problem in that manner... Either way, I would appreciate it a lot if someone got back to me. I've been trying to figure out how to get around this issue for the last couple days (even tried manually sending signals to the control via the windows API), but I haven't been able to get anything working yet. Thanks for reading, Mike

3 3

HTML5 Web Socket Design Doc
by Fumitoshi Ukai (鵜飼文敏) 13 Jul '09

13 Jul '09

Hi, yuzo, tyoshino and ukai @chromium.org start working to implement HTML5 Web Socket and write design doc. http://docs.google.com/View?id=dfm7gfvg_0fpjg22gh Any comments? We'd welcome if you could give us feedback on our design doc. Thanks! Fumitoshi Ukai

2 3

WebCore architecture for persistent cache
by Jeremy Serdin 08 Jul '09

08 Jul '09

Hi all I'm trying to implement a persistent cache for WebCore with libcurl. I'm looking for some documents about webcore architecture in order to implement it in a right way. Can somebody help me? Thx, jserdin(a)gmail.com

2 1

Question about Constructors in WebKit JS Bindings
by Drew Wilson 08 Jul '09

08 Jul '09

I notice that this is a fairly common idiom in the WebKit JS bindings: 1) Storing away a pointer to the JSDOMGlobalObject in the constructor JSOptionConstructor::JSOptionConstructor(ExecState* exec, JSDOMGlobalObject* globalObject) : DOMObject(JSOptionConstructor::createStructure(exec->lexicalGlobalObject()->objectPrototype())) * , m_globalObject(globalObject)* { 2) Manually marking that JSDOMGlobalObject as in-use: void JSOptionConstructor::mark() { DOMObject::mark(); if (!m_globalObject->marked()) m_globalObject->mark(); } 3) Using that stored-away JSDOMGlobalObject to get a reference to the parent ScriptExecutionContext/Document: Document* JSOptionConstructor::document() const { return static_cast<Document*>(m_globalObject->scriptExecutionContext()); } static JSObject* constructHTMLOptionElement(ExecState* exec, JSObject* constructor, const ArgList& args) { * Document* document = static_cast<JSOptionConstructor*>(constructor)->document();* * * * * I'm trying to understand why this is necessary - an alternative would be to just do the following, as JSWorkerConstructor does: static JSObject* constructHTMLOptionElement(ExecState* exec, JSObject* constructor, const ArgList& args) { * DOMWindow* window = asJSDOMWindow(exec->lexicalGlobalObject())->impl(); * * Document* document = window->document();* * * This avoids having to keep around a reference, have a custom mark() function, etc. This also tightly ties a given constructor to a specific Document object - in this particular example, my javascript code could pass a reference to window.Option into a child iframe, but executing the constructor within that iframe would still reference the original Document object. What's the motivation for storing away the original Document object in these constructors? I'm writing a constructor for SharedWorker now and I'm trying to figure out which is the correct behavior... -atw

5 30

Browser application, how to serialize
by Nitin Mahajan 02 Jul '09

02 Jul '09

HI! I am running a example browser application on an ARM cpu on QtWebKit. I have implemented keyPressEvent() in WebView(derived from QWebView) class like this 239 void WebView::keyPressEvent(QKeyEvent *key) 240 { 241 switch(key->key()) 242 { 243 case Qt::Key_F10: 244 QWebFrame *frame = page()->mainFrame(); 245 const qreal scaleFactor = 1.2000; 246 qDebug() << "Zoom Begin"; 247 myLabel->show(); 248 frame->setZoomFactor(scaleFactor); 249 qDebug() << "Zoom end"; 250 break; 251 } 252 } myLabel is a Label widget constructed in constructor of WebView class. The problem is after the setZoomFactor() has finished zooming the frame, we get to see the label widget. The qDebug() statements however get displayed on console in s sequence they are written in code. I want to display the label before starting to zoom and hide the label after the frame has been zoomed. Can you please help me in knowing how can I serialize these functionalities? regards -Nitin New Email addresses available on Yahoo! Get the Email name you've always wanted on the new @ymail and @rocketmail. Hurry before someone else does! http://mail.promotions.yahoo.com/newdomains/aa/

2 2

Using memcmp
by Patrick Hanna 01 Jul '09

01 Jul '09

I have noticed that rather than using memcmp for comparing strings, webkit likes to cast to uint32_t* and compare in a for loop. For example, WebCore::equal in AtomicString.cpp and StringHash::equal in StringHash.h. Is there any reason not to memcmp? I am assuming that most implementations of memcmp will do the word alignment and basically do the same thing. The reason I ask is because StringHash::equal does not check for PLATFORM(ARM) or PLATFORM(SH4) so I was going to submit a patch to use memcmp for ARM/SH4 but didn't know if that was frowned upon (and WebCore::equal does a loop for ARM/SH4 as well). Thanks, Patrick

4 6