July 2008 - webkit-dev - lists.webkit.org

Qt's default webkit user agent
by Benjamin Meyer 01 Dec '08

01 Dec '08

As it is today Qt's default user agent (in qwebpage.cpp) is hard coded to: "Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en) AppleWebKit/523.15 (KHTML, like Gecko) Safari/419.3 Qt" Seeing as this library will be used inside of many other applications it makes sense to include by default at least the application name/version when they are set. QCoreApplication gives us several strings which can be used. applicationName, applicationVersion, organizationDomain, organizationName But at a bigger question, what should be included (or not included) with the default user agent? Is there docs anywhere that suggest what webkit library users should use as their user agent string? -Benjamin Meyer

7 6

proxying thru curl
by Giri Rao 01 Dec '08

01 Dec '08

Hello, I have set up curl to go through a simple http proxy that I have written. I have a .curlrc with the following line in it: --proxy=http://<myhost>:<myport>/ When I invoke curl on command line, it goes thru the set proxy. However, when I launch webkit through GtkLauncher, it does not seem to go through the proxy at all. Is my understanding wrong in that webkit uses curl to fetch content? How do I make webkit go through my proxy? Any help is appreciated. Thanks Giri

2 2

webkit documentation
by Jack Wootton 25 Nov '08

25 Nov '08

Hi all, I am mainly interested in S60 WebKit, however due to the project seeming to be in complete disarray to those not working for Nokia, I've decided to focus my efforts on the WebKit branch from which S60 WebKit started. I understand this to be Tiger 10.4.7 (it was one of the few pieces of information about S60 WebKit that I could actually find - although it will almost certainly turn out to be incorrect :p): http://trac.webkit.org/browser/releases/Apple/Tiger/Mac%20OS%20X%20Update%2… Where can I find documentation for this code? The question here is, other than trawling through code, where can I find documentation that explain it's implementation? Cheers, Jack

3 7

Re: [webkit-changes] [24723] trunk/WebCore
by Darin Adler 11 Sep '08

11 Sep '08

I'm not happy with the code organization here. XMLTokenizer now has tons of ifdefs and two separate implementations. It's fine to have a QXmlStream implementation, but the two implementations should be in separate files, side by side, as we do in the platform layer. Or the XML parser should be abstracted out so we have a single XMLTokenizer built on a single parser abstraction. I think this is also the type of patch that should be reviewed by at least one person other than the folks concentrating on the Qt port. With the huge number of check-ins today, I'm sure there are other interesting things like this that I missed. -- Darin

8 17

Query on running the test scripts
by Gargi Varun-DFXR46 04 Aug '08

04 Aug '08

Hi All We are trying to test javascriptcore using the scripts that we have in Dir \WebKit\WebKitTools\Scripts. We have build the webkit on Symbian UIQ. when we try running a script "run-javascriptcore-tests" from command prompt it gives some errors as follows The system cannot find the path specified. The system cannot find the path specified. Building not defined for this platform! Compiling testkjs failed! Is there any thing more needed to make these scripts run. We tried it on Cygwin also still the same errors. Thanks Varun

5 5

Re: [webkit-dev] [webkit-changes] [35474] trunk/JavaScriptCore
by Justin Haygood 01 Aug '08

01 Aug '08

> >On Jul 31, 2008, at 11:30 PM, Brent Fulgham wrote: > >> Since WebKit has its own threading abstraction layer, I think it is >> unwise for code outside this layer to make use of the special >> knowledge that pthreads is in use. Whatever you want to be doing via >> calls to pthreads primitives should instead be handled using one of >> the WTF/Thread methods. If no such method exists, it should be added >> so that proper variants for the specific platforms are used. > > >Well, what I'm saying is that maintaining our own abstraction layer is >a large and unnecessary burden. > >- WBR, Alexey Proskuryakov > We already do maintain it... WebCore uses it quite heavily. Why not use it? It uses the platform's native threading APIs (gthread on glib, QThread on Qt, pthread on OS X, Win32 threads on Win32) >_______________________________________________ >webkit-dev mailing list >webkit-dev(a)lists.webkit.org >http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Justin Haygood jhaygood(a)reaktix.com Reaktix. Reality Redefined.

3 6

WebKit/GTK+ and N810
by Afonso Costa 01 Aug '08

01 Aug '08

Hi all, I'd like to do some tests using WebKit/GTK+ in my N810. I've built it using some information listed here [1] and here [2]. Fortunately I got to build it in my Scratchbox environment and I've installed it in my N810. But when I open http://www.gtk.org in GtkLauncher, for my surprise, I get this result [3]. When I open the same site in my desktop Linux, I can get other different result [4]. It's missing a blue background... Am I missing anything in my build process? Is there other patch related to ARM? I'm configuring WebKit with: configure --enable-video --with-hildon. I've already tested it with --disable-xslt, but I didn't get any success. My scratchbox environment is: Chinook - cs2005q3.2-glibc2.5-arm #gcc --version: sbox-arm-linux-gcc (GCC) 3.4.4 (release) (CodeSourcery ARM 2005q3-2) Thanks in advance. Afonso [1] http://maemo.webkit.org/ [2] https://lists.webkit.org/pipermail/webkit-dev/2008-January/003114.html [3] http://www.flickr.com/photos/28823089@N02/2690042373/ [4] http://www.flickr.com/photos/28823089@N02/2690042377/

2 5

Windows desktop application powered by webkit
by rich.client 31 Jul '08

31 Jul '08

Hi All, I have a requirement to build a desktop application that will run on windows XP (initially anyway) which is to use web technologies (HTML/CSS/javascript) for the presentation layer as opposed to a traditional desktop GUI toolkit. I am looking for feedback from anyone with regard to 1. the suitability of webkit for this requirement 2. where I can get help/advice/documention Thanks rc

4 3

Re: [webkit-dev] [webkit-changes] [35474] trunk/JavaScriptCore
by Alexey Proskuryakov 31 Jul '08

31 Jul '08

On Jul 31, 2008, at 10:38 AM, eric(a)webkit.org wrote: > Try to clean up our usage of USE(MULTIPLE_THREADS) vs. > USE(PTHREADS) a little. There is indeed some confusion between MULTIPLE_THREADS and PTHREADS in JSC now. One of the reasons is that some of the threading code can be used in WebCore even if JSC is not threaded, and vice versa. The former macro enables JSC multithreading, while the latter in not as clear cut. > > It looks like JSC assumes that if MULTIPLE_THREADS is > defined, then pthreads will always be available > I'm not sure that's always the case for gtk, certainly not > for Windows. We should eventually go back > and fix wtf/Threading.h to cover all these cases some day. Yes, JSC currently assumes that pthreads is available for MULTIPLE_THREADS. It is not at all obvious to me that this is a wrong assumption - we'd need a compatibility layer for platforms that don't have native pthreads anyway, so why not use existing pthreads implementations for these platforms? We do that on Windows, for example. Let's discuss this before declaring it wrong at least. > Modified: trunk/JavaScriptCore/kjs/collector.h (35473 => 35474) > --- trunk/JavaScriptCore/kjs/collector.h 2008-07-31 06:14:13 UTC > (rev 35473) > +++ trunk/JavaScriptCore/kjs/collector.h 2008-07-31 06:38:54 UTC > (rev 35474) > @@ -28,9 +28,6 @@ > #include <wtf/Noncopyable.h> > #include <wtf/OwnPtr.h> > #include <wtf/Threading.h> > -#if USE(MULTIPLE_THREADS) > -#include <pthread.h> > -#endif This change in particular seems wrong to me - the file uses pthread_key_t under #if USE(MULTIPLE_THREADS), but pthread.h is only included in Threading.h under #if USE(PTHREADS). - WBR, Alexey Proskuryakov

3 5

Leak in plugin management
by Kelemen Balázs 31 Jul '08

31 Jul '08

I find a leak with valgrind when running QtLauncher and load pages that requires plugins. It is that the m_module member in WebCore::PluginPackage class is not freed. I took a look at the code and realized that this member must freed with a delay through freeLibrarySoon method that is callen from the destructor. I debuged QtLauncher and discovered that this member is not freed anyway. The destructor runs many times but the unloadModule function that should free the member had never been reached. I tested it though load pages like youtube and "http://szotar.sztaki.hu/index.hu.jhtml" in QtLauncher when it was run under gdb (these pages require flash, mplayer and java plugins). Then I load simple html pages and local files but the member had been still unfreed. I use the Qt port of Webkit under linux. It is a real leak, or I just misunderstood the logic of plugin management? Regards Kelemen Balázs ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program.

1 0