September 2007 - webkit-dev - lists.webkit.org

Re: [webkit-changes] [24723] trunk/WebCore
by Darin Adler 11 Sep '08

11 Sep '08

I'm not happy with the code organization here. XMLTokenizer now has tons of ifdefs and two separate implementations. It's fine to have a QXmlStream implementation, but the two implementations should be in separate files, side by side, as we do in the platform layer. Or the XML parser should be abstracted out so we have a single XMLTokenizer built on a single parser abstraction. I think this is also the type of patch that should be reviewed by at least one person other than the folks concentrating on the Qt port. With the huge number of check-ins today, I'm sure there are other interesting things like this that I missed. -- Darin

8 17

Threading issues regarding Netscape API plugins in WebKit
by Song Yuan 01 Oct '07

01 Oct '07

Hi, Are plugins implemented by using Netscape APIs in WebKit thread safe? Does Netscape APIs in WebKit have similar APIs like NPN_PluginThreadAsyncCall (refer to <http://developer.mozilla.org/en/docs/NPN_PluginThreadAsyncCall> http://developer.mozilla.org/en/docs/NPN_PluginThreadAsyncCall) in Gecko SDK in Mozilla? Will a new thread pawned from plugin main thread be able to invoke any JavaScript methods in browser? Thanks in advance! /Song

3 3

help: webkit build error on linux
by lan liu 29 Sep '07

29 Sep '07

Hello webkit-dev, i check out the source code of version 25773 from http://svn.webkit.org/repository/webkit/trunk, try to build it, then i got following error: g++ -c -o obj-gnu/webcore_gdk_CSSGrammar.o -I../../../JavaScriptCore -I../.. -I../../bindings/js -I../../bridge -I../../css -I../../DerivedSources/WebCore -I../../dom -I../../editing -I../../ForwardingHeaders/kjs -I../../history -I../../html -I../../include -I../../loader -I../../loader/gdk -I../../loader/icon -I../../page -I../../platform -I../../platform/graphics -I../../platform/graphics/gdk -I../../platform/image-decoders -I../../platform/image-decoders/bmp -I../../platform/image-decoders/gif -I../../platform/image-decoders/ico -I../../platform/image-decoders/jpeg -I../../platform/image-decoders/png -I../../platform/image-decoders/xbm -I../../platform/image-decoders/zlib -I../../platform/network -I../../platform/network/gdk -I../../rendering -I../../xml -DENABLE_XSLT=1 -DLINUX -DUSE_CONSERVATIVE_GC=0 -DHAVE_FUNC_ISNAN -D_THREAD_SAFE -pthread -g -I../../platform/gdk -I../../platform/network/gdk -DBUILDING_GDK__ -DBUILDING_CAIRO__ -Iplatform/gdk -Iplatform/graphics/cairo -DENABLE_XPATH -I/usr/include/libxml2 -I/usr/include/libxml2 -g -O2 -I/usr/include/freetype2 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0-I/usr/include/glib- 2.0 -I/usr/lib/glib-2.0/include -I/usr/include/cairo -fPIC -DPIC -fno-rtti -fno-exceptions -MTobj-gnu/webcore_gdk_CSSGrammar.o -MF`echo obj-gnu/webcore_gdk_CSSGrammar.o | sed -e 's,\.o$,.d,'` -MD ../../DerivedSources/WebCore/CSSGrammar.cpp /home/michelle/Study/Webkit/trunk/WebCore/css/CSSGrammar.y: In function 'int WebCore::getPropertyID(const char*, int)': /home/michelle/Study/Webkit/trunk/WebCore/css/CSSGrammar.y:86: error：'findProp': identifier not found /home/michelle/Study/Webkit/trunk/WebCore/css/CSSGrammar.y:90: error：invalid use of undefined type 'const struct WebCore::props' /home/michelle/Study/Webkit/trunk/WebCore/css/CSSGrammar.y:86: error：forward declaration of 'const struct WebCore::props' /home/michelle/Study/Webkit/trunk/WebCore/css/CSSGrammar.y: In function 'int getValueID(const char*, int)': /home/michelle/Study/Webkit/trunk/WebCore/css/CSSGrammar.y:111: error：'findValue' identifier not found /home/michelle/Study/Webkit/trunk/WebCore/css/CSSGrammar.y:115: error：invalid use of undefined type 'const struct css_value' /home/michelle/Study/Webkit/trunk/WebCore/css/CSSGrammar.y:111: error：forward declaration of 'const struct css_value' make: *** [obj-gnu/webcore_gdk_CSSGrammar.o] error1 and i tried to find the definition of 'findProp' and 'findValue' in the entitre directory, but i failed to find it. also i have found that similiar bugs already reported, with the bug id 9340 and 14841, but no solution found. could you tell me how to fix this problem or how to avoid it? i really appreciate if you could give me some hint. thank you! PS , my building step is like this cd WebKitTools/Scripts sudo ./install-unix-extras cd JavaScriptCore make cd .. cd WebCore/Projects/gdk/ make thank you and regards! michelle

3 5

A newBie question about compilation
by Eva Madrazo 27 Sep '07

27 Sep '07

Hello, I am very new in this, including C++, symbian and webkit. So, apologize for my questions if they are so basic... I was trying to compile webKit in a Windows XP proffesional. I have installed cygwin and Qt (for qmake command). I have download source code from subversion repository. Then, I access to Scripts directory and execute build-webkit and the result is: $ webkit/webkittools/scripts/build-webkit --debug Checking mod-date of WebKitSupportLibrary.zip... Current WebKitSupportLibrary is up to date Calling 'qmake -r OUTPUT_DIR=/cygdrive/d/webkit/WebKitBuild/Debug CONFIG+=qt-port /cygdrive/d/webkit/WebKit.pro CONFIG-=release CO NFIG+=debug' in /cygdrive/d/webkit/WebKitBuild/Debug ... Cannot find file: \cygdrive\d\webkit\WebKit.pro. Failed to setup build environment using qmake! But indeed the file exists!! $ ls /cygdrive/d/webkit/WebKit.pro /cygdrive/d/webkit/WebKit.pro ¿What's the matter? .. By the way, I have not installed Visual C++ 2005 Express because I would like to use Carbide C++ ... ¿Is this possible? Thank you very much, Eva

2 1

FCKeditor + ( Safari || Opera ) = Yeah!
by Frederico Caldeira Knabben 26 Sep '07

26 Sep '07

Hi, It is a pleasure to announce that, from now on, FCKeditor is officially compatible with Safari 3 and Opera 9.50: http://dev.fckeditor.net/changeset/882 http://dev.fckeditor.net/changeset/883 The first compatible release, FCKeditor 2.5, is coming soon. These browsers are still in Beta, so there are still some things to be fixed, but we are confident that we'll have wonderful results as soon as the browsers go on stable. Many thanks to Opera and WebKit to the wonderful job done on their browsers, doing their best to provide the features needed to bring FCKeditor under their platforms. Keep up the good work! Fred Frederico Caldeira Knabben Project Manager, FCKeditor ---- http://www.fckeditor.net

1 0

Editable selection inside empty element
by Frederico Caldeira Knabben 22 Sep '07

22 Sep '07

Hi, It is a pleasure to say that FCKeditor is almost completely working with Safari. There are still some issues, but we'll be able to finally declare official support for Safari 3. Thanks for the hard work at WebKit's side. Now, back to the point... For the few big issues we are having with Safari, I'm going almost crazy, trying to find a way to place the caret inside an empty element for editing. To understand the problem, just try the following page: http://www.fredck.com/bugs/safari/collapsed_select_test.html This page works well with Firefox 2 and Opera 9.5 (minor issues with this one). Before opening a bug report for it, I'm coming to the mailing list for a desperate call for help. Does anyone know any weird hack to make the magic happen with Safari too? I've tried hundreds of combinations, but none worked correctly. Thanks for any help in this sense. Fred Frederico Caldeira Knabben Project Manager, FCKeditor ---- http://www.fckeditor.net

5 8

RE: [webkit-dev] Editable selection inside empty element
by Frederico Caldeira Knabben 22 Sep '07

22 Sep '07

> There are various different ways to test whether features work not so > well. Not in the TC case... anyway, I'm not really here to advocate the best way to do so. I'm sorry that the focus has been moved to the browser detection. I really hope some nice workaround suggestion could be found for the selection problem instead. Thanks for your comments Mike. Fred > -----Original Message----- > From: Mike Hommey [mailto:mh@glandium.org] > Sent: 22 September 2007 12:17 > To: Frederico Caldeira Knabben > Cc: 'Mark Rowe'; webkit-dev(a)lists.webkit.org > Subject: Re: [webkit-dev] Editable selection inside empty element > > On Sat, Sep 22, 2007 at 12:11:27PM +0200, Frederico Caldeira Knabben > <fredck(a)fckeditor.net> wrote: > > Thanks for the reply Mark. I've filled the following bug for it: > > > > http://bugs.webkit.org/show_bug.cgi?id=15256 > > > > > > > On an unrelated note, > > > // For Safari and Opera, we must ensure the focus. > > > if ( (/safari/i).test( navigator.userAgent ) ) > > > > > > It is almost never correct to test for "Safari" specifically. WebKit > is > > > what you should be aiming to detect. This will ensure that your code > > > functions correctly in other WebKit-based browsers, such as OmniWeb, > > > Shiira, NetNewsWire, etc. > > > > That was just useful for the TC. But you are right; I'll take care of > using > > the recommended way: > > > > (/ AppleWebKit\//).test( navigator.userAgent ) > > Actually, this is as bad as testing for safari. You should test > features, not user agents. > > Mike

1 0

Extending the multipart support
by Sachin Puranik 22 Sep '07

22 Sep '07

HI , As I checked there is no support for the multipart contents(multipart/mixed, multipart/related, multipart/alternate) in the WebKit. What shall be ideal way to extend this support. There are two approach in my mind. 1)parsing the content's other than HTML and Store as cached obkjects in Cache manager. But if Cache is disable it will be a problem. 2)Deriving new class HTMLMultipartDocument from HTMLDocument /Document. Is there any other way to do it. Thanks and Regards Sachin

1 0

Re: [webkit-dev] Extending the multipart support
by David D. Kilzer 21 Sep '07

21 Sep '07

WebKit supports multipart/x-mixed-replace as long as the content type doesn't change (14149) or as long as it's not used through an XMLHttpRequest (14392): http://bugs.webkit.org/show_bug.cgi?id=14149 http://bugs.webkit.org/show_bug.cgi?id=14392 The multipart/related (7168), multipart/mixed (9389) and multipart/alternate (no bug filed; please consider filing one) content types are not supported yet. http://bugs.webkit.org/show_bug.cgi?id=7168 http://bugs.webkit.org/show_bug.cgi?id=9389 I'm not sure the best way to implement support. At minimum you will need a MIME parser. I would take a look at how .webarchive files are loaded and mimic that. In theory, you shouldn't have to worry about the cache as long as all of the resources fit into memory. However, I think there may be an issue with subresources (such as CSS files) on the page not being cached properly for future reloads when coming from a webarchive (12605). http://bugs.webkit.org/show_bug.cgi?id=12605 Dave Sachin Puranik <sachin.puranik(a)celunite.com> wrote: > HI , > > As I checked there is no support for the multipart contents(multipart/mixed, > multipart/related, multipart/alternate) in the WebKit. What shall be ideal > way to extend this support. > > There are two approach in my mind. > > 1)parsing the content's other than HTML and Store as cached obkjects in > Cache manager. But if Cache is disable it will be a problem. > > 2)Deriving new class HTMLMultipartDocument from HTMLDocument /Document. > > Is there any other way to do it. > > Thanks and Regards > > Sachin

2 2

Re: [webkit-dev] Extending the multipart support
by Andre-John Mas 21 Sep '07

21 Sep '07

On 22-Sep-07, at 02:14 , Sachin Puranik wrote: > HI , > > As I checked there is no support for the multipart contents > (multipart/mixed, multipart/related, multipart/alternate) in the > WebKit. What shall be ideal way to extend this support. > > There are two approach in my mind. > > 1)parsing the content’s other than HTML and Store as cached > obkjects in Cache manager. But if Cache is disable it will be a > problem. > > 2)Deriving new class HTMLMultipartDocument from HTMLDocument / > Document. > > Is there any other way to do it. > Firefox already provides multipart support, as can be witnessed from using the Bugzilla search page. Maybe you could have a look to see how they do it for ideas? Andre PS I trimmed the webkitsdk-dev list from the responses since I am not subscribed there.

1 0