August 2007 - webkit-dev - lists.webkit.org

Re: [webkit-changes] [24723] trunk/WebCore
by Darin Adler 11 Sep '08

11 Sep '08

I'm not happy with the code organization here. XMLTokenizer now has tons of ifdefs and two separate implementations. It's fine to have a QXmlStream implementation, but the two implementations should be in separate files, side by side, as we do in the platform layer. Or the XML parser should be abstracted out so we have a single XMLTokenizer built on a single parser abstraction. I think this is also the type of patch that should be reviewed by at least one person other than the folks concentrating on the Qt port. With the huge number of check-ins today, I'm sure there are other interesting things like this that I missed. -- Darin

8 17

Window::isSafeScript: which URLs to use in the error message
by Anyang Ren 31 Aug '07

31 Aug '07

In kjs_window.cpp, Window::isSafeScript(ExecState *exec), we have: KURL actURL = activeFrame->loader()->url(); WebCore::String actDomain = actURL.host(); ... KURL thisURL = frame->loader()->url(); ... WebCore::String thisDomain = thisURL.host(); if (actDomain == thisDomain && actURL.protocol() == thisURL.protocol() && actURL.port() == thisURL.port()) return true; if (Interpreter::shouldPrintExceptions()) { printf("Unsafe JavaScript attempt to access frame with URL %s from frame with URL %s. Domains, protocols and ports must match.\n", thisDocument->URL().latin1(), actDocument->URL().latin1()); } String message = String::format("Unsafe JavaScript attempt to access frame with URL %s from frame with URL %s. Domains, protocols and ports must match.\n", thisDocument->URL().latin1(), actDocument->URL().latin1()); Since thisURL and actURL are the URLs used in the test, why are we using thisDocument->URL() and actDocument->URL() in the error messages? In fact, actDocument could be NULL. Earlier in this function, we have: WebCore::Document* actDocument = activeFrame->document(); if (actDocument) { if (thisDocument->domainWasSetInDOM() && actDocument->domainWasSetInDOM()) { if (thisDocument->domain() == actDocument->domain()) return true; } } The if (actDocument) test suggests that actDocument could be NULL. -- Anyang Ren Open source developer

2 2

Re: [webkit-dev] disable scroll bars in webView....
by David D. Kilzer 31 Aug '07

31 Aug '07

If you're going to build your own custom version of WebKit, you could modify WebCore/css/html4.css and WebCore/css/quirks.css to include the "overflow: hidden;" style on the body tag. This would have essentially the same effect. I'm not aware of any "switch" to disable scroll bars completely (although that doesn't mean there isn't one). Dave Kathryn Tate <kathryntate(a)comcast.net> wrote: > Actually, yes, I see what you are doing, but I meant something > entirely different--kind of strange. > > Is it possible to disable the scrolling bars WebView in Xcode? (I am > asking WebKit group as you have > produced the bridge to making browsers). > > What I am trying to do is create a web browser that is tiny and has > no scroll bars--the images > would be thumbnails. > > Thanks, Kathryn > > > > On Aug 31, 2007, at 9:54 AM, David D. Kilzer wrote: > > > Hi Kathryn, > > > > Are you wanting to do this using HTML? If so: > > > > <img src="http://webkit.org/images/icon-gold.png" style="top: > > 200px; left: > > 200px; position: absolute;"> > > > > To make a containing element not scroll, use the "overflow: hidden" > > style (e.g. > > to disable scroll bars for the entire page): > > > > <body style="overflow: hidden;"> > > <img src="http://webkit.org/images/icon-gold.png" style="top: > > 1000px; left: > > 200px; position: absolute;"> > > </body> > > > > BTW, if you have questions about HTML, neither the webkit-dev list > > nor the > > xcode-users list is appropriate. I would suggest the web-dev > > mailing list for > > that: > > > > http://lists.apple.com/mailman/listinfo/web-dev > > > > Dave > > > > > > Kathryn Tate <kathryntate(a)comcast.net> wrote: > > > >> Guys, > >> Is there a way to disable the scroll bars in WebView so that the > >> image is fixed? > >> > >> Thanks > > > >

2 1

build QTwebkit errors on windows
by pj_wh120＠sina.com 31 Aug '07

31 Aug '07

hi,all Is there anybody knows this error : ./tmp\HTMLFormElement.o:HTMLFormElement.cpp:(.text+0x41d7): undefined reference to `_imp__PathFindFileNameW@4' collect2: ld returned 1 exit status mingw32-make[2]: *** [..\lib\QtWebKit.dll] Error 1 mingw32-make[2]: Leaving directory `C:/cygwin/home/en/WebKit/WebKitBuild/Release /WebCore' mingw32-make[1]: *** [release] Error 2 mingw32-make[1]: Leaving directory `C:/cygwin/home/en/WebKit/WebKitBuild/Release /WebCore' mingw32-make: *** [sub-WebCore-make_default-ordered] Error 2 Your vendor has not defined POSIX macro WEXITSTATUS, used at build-webkit line 1 41 Build Instructions for the QtWebKit build on Windows http://trac.webkit.org/projects/webkit/wiki/BuildingQtOnWindows thanks! Jeff ------------------------------------------------------------------- 彩铃制作全过程大揭秘！( http://d1.sina.com.cn/sina/limeng3/mail_zhuiyu/2007/mail_zhuiyu_20070820.ht… ) =================================================================== 注册新浪2G免费邮箱（http://mail.sina.com.cn/）

5 4

disable scroll bars in webView....
by Kathryn Tate 31 Aug '07

31 Aug '07

Guys, Is there a way to disable the scroll bars in WebView so that the image is fixed? Thanks

2 1

Regarding error in building WebKit Gdk
by Shriram Bhat 30 Aug '07

30 Aug '07

Hi All, I have downloaded the WebKit code from http://webkit.org/building/checkout.html<http://193.164.132.164/servlet/redirect.srv/p5.p1.pbkisrd.paeu/building/che…> To build WebKit Gdk, i am using the build instructions as given in http://trac.webkit.org/projects/webkit/wiki/BuildingGdk while building, i got the following error. ld: Undefined symbols: __ZN7WebCore9CSSParser3lexEv /usr/bin/libtool : internal link edit command failed make[1]: *** [../lib/libWebKitGdk.1.0.0.dylib] Error 1 make: *** [sub-WebCore-make-default-ordered] Error 2 However inside the file, *WebCore/css/CSSParser.cpp*, in function *int CSSParser::lex(void *yylvalWithoutType)* if i comment the line *int token = lex()* and assign some value, say int token = 1; then it is building... Can anyone please help me in figuring out the correct way to overcome this error? Thanks, Shriram

2 1

Why is port 8080 hard-coded in LayoutTests/http/conf/*httpd.conf?
by Anyang Ren 30 Aug '07

30 Aug '07

In r24746, the three *httpd.conf files in LayoutTests/http/conf were changed to listen on port 8080 as well. The relevant section in those files looks like this now: # # Listen: Allows you to bind Apache to specific IP addresses and/or # ports, instead of the default. See also the <VirtualHost> # directive. # # Configured from the httpd command line for WebKit layout tests. # Port 8443 is hard-coded as it is needed for the HTTPS configuration later on. # #Listen 3000 Listen 127.0.0.1:8080 Listen 127.0.0.1:8443 Should we add a comment to explain why port 8080 is hard-coded? Why don't we pass -C 'Listen 127.0.0.1:8080' to httpd on the command line? Thanks. -- Anyang Ren Open source developer

3 2

Serious problems with latest build.....
by Kathryn Tate 30 Aug '07

30 Aug '07

Downloaded the build for today, Aug. 29. (I am brand new to gui programming). I was trying to access /System/Library/WebKit and got a text file alias leading to my text editor which displayed garbled text. Where does the WebKit Framework now reside? Please advise, Kathryn

3 2

QtWebKit build issue: pathGetFilename
by KC Jones 29 Aug '07

29 Aug '07

Newbie first post here. I really, really did not want to open with a "I can't build it" post, but c'est la vie. I am attempting to complete the QtWebKit build as described on the Wiki. It was humming along when it bombed out on a UDEF link error of PathFindFileName referenced by pathGetFilename in HTMLFormElement.cpp. The exact error message is below. When I look at /WebKit/WebCore/html/HTMLFormElement.cpp it looks fine. The problem code appears to have been introduce in Rev 25067 on 8/13. I don't yet know the build scripts well enough to suggest where the missing lib needs to be added, but the missing symbol comes from shlwapi.lib. Any suggestions on how to fix this? Cheers, KC Jones link /LIBPATH:"c:\Qt\4.3.1\lib" /NOLOGO /DEBUG /DLL /MANIFESTFILE:"tmp\QtWebKit.intermediate.manifest" /OUT:..\lib\QtWebKit.dll @C:\DOCUME~1\KJones\LOCALS~1\Temp\nm5B.tmp Creating library ..\lib\QtWebKit.lib and object ..\lib\QtWebKit.exp HTMLFormElement.obj : error LNK2019: unresolved external symbol __imp__PathFindFileNameW@4 referenced in function "class WebCore::String __cdecl WebCore::pathGetFilename(class WebCore::String)" (?pathGetFilename@WebCore@@ YA?AVString@1@V21@@Z) ..\lib\QtWebKit.dll : fatal error LNK1120: 1 unresolved externals NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio 8\VC\BIN\link.EXE"' : return code '0x460' Stop. NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio 8\VC\BIN\nmake.exe"' : return code '0x2' Stop. NMAKE : fatal error U1077: 'cd' : return code '0x2' Stop. WEXITSTATUS is not a valid POSIX macro at WebKitTools\Scripts\build-webkit line 141

2 1

Error while building WebKit Gdk on Mac OS X
by Shriram Bhat 29 Aug '07

29 Aug '07

Hi All, I am trying to build WebKit Gdk on Mac OS 10.4.9 (Tiger) PowerPC with Gcc version 4.0.1 I have downloaded the WebKit code from http://webkit.org/building/checkout.html To build WebKit Gdk, i am using the build instructions as given in http://trac.webkit.org/projects/webkit/wiki/BuildingGdk I have installed the listed dependent packages and Qmake. I am using the command WebKit/WebKitTools/Scripts$ ./build-webkit --gdk to build Gdk. While building i am getting the following error... ld: Undefined symbols: __ZN7WebCore9CSSParser3lexEv /usr/bin/libtool : internal link edit command failed make[1]: *** [../lib/libWebKitGdk.1.0.0.dylib] Error 1 make: *** [sub-WebCore-make-default-ordered] Error 2 Can anyone please help me in resolving this error and building Gdk? Thanks, Shriram

2 2