April 2006 - webkit-dev - lists.webkit.org

Re: [webkit-dev] Optimizing DOMNode _nodeWith
by Matt Gough 02 May '06

02 May '06

On 24 Apr 2006, at 20:58, Maciej Stachowiak wrote: > I think a better approach would be to make a hash table of function > pointers, that will be faster than the log chain of if's. This is > what is used to generate the elements in the first place. On 24 Apr 2006, at 19:24, Timothy Hatcher wrote: > I would like to see before and after numbers when you have > everything changed over. OK, so I implemented this as a hashmap. Unfortunately my results show only marginal improvement. (i.e only a 1 - 3% reduction in time for the various sites I have tested. Investigating further it seems that my original assertion that 'For a medium sized DOM (e.g news.google.com - just over 4000 nodes) this code takes over one tenth of a second on an 867MHz G4. A third of that time is down to the calls to hasLocalName' was wrong. I suspect those timings were being done with a debug build of WebKit. On the largest page I could find (by node count) my changes made about 5ms improvement (http:// whatwg.org/specs/web-apps/current-work/) Anyway, I have put my work on this at the end of the email, but I am not convinced it is worth changing to this without there being a noticeable benefit. I guess the multiple calls to hasLocalName don't have as much impact as we might think. Maybe if someone could test this on different hardware it might make a bigger difference. Matt Index: WebCore/bindings/objc/DOM.mm =================================================================== --- WebCore/bindings/objc/DOM.mm (revision 14055) +++ WebCore/bindings/objc/DOM.mm (working copy) @@ -44,10 +44,13 @@ #import "Range.h" #import "dom_xmlimpl.h" #import "HTMLNames.h" +#import "QualifiedName.h" #import "RenderImage.h" #import <JavaScriptCore/WebScriptObjectPrivate.h> #import <objc/objc-class.h> +using WebCore::AtomicString; +using WebCore::AtomicStringImpl; using WebCore::Attr; using WebCore::CharacterData; using WebCore::Document; @@ -69,6 +72,7 @@ using WebCore::NodeIterator; using WebCore::NodeList; using WebCore::Notation; using WebCore::ProcessingInstruction; +using WebCore::QualifiedName; using WebCore::Range; using WebCore::RenderImage; using WebCore::RenderObject; @@ -454,6 +458,218 @@ static ListenerMap *listenerMap; @end +typedef HashMap<AtomicStringImpl*, Class> ObjcClassMap; + +static ObjcClassMap *objcClassMap; + +static void addObjcClassForTag(const QualifiedName& tag, Class objcClass) +{ + objcClassMap->set(tag.localName().impl(), objcClass); +} + + +static void createObjcClassMap() +{ + // Create the table. + objcClassMap = new ObjcClassMap; + + // Populate it with DOM Element classes. + addObjcClassForTag(htmlTag, [DOMHTMLHtmlElement class]); + addObjcClassForTag(headTag, [DOMHTMLHeadElement class]); + addObjcClassForTag(linkTag, [DOMHTMLLinkElement class]); + addObjcClassForTag(titleTag, [DOMHTMLTitleElement class]); + addObjcClassForTag(metaTag, [DOMHTMLMetaElement class]); + addObjcClassForTag(baseTag, [DOMHTMLBaseElement class]); + addObjcClassForTag(isindexTag, [DOMHTMLIsIndexElement class]); + addObjcClassForTag(styleTag, [DOMHTMLStyleElement class]); + addObjcClassForTag(bodyTag, [DOMHTMLBodyElement class]); + addObjcClassForTag(formTag, [DOMHTMLFormElement class]); + addObjcClassForTag(selectTag, [DOMHTMLSelectElement class]); + addObjcClassForTag(optgroupTag, [DOMHTMLOptGroupElement class]); + addObjcClassForTag(optionTag, [DOMHTMLOptionElement class]); + addObjcClassForTag(inputTag, [DOMHTMLInputElement class]); + addObjcClassForTag(textareaTag, [DOMHTMLTextAreaElement class]); + addObjcClassForTag(buttonTag, [DOMHTMLButtonElement class]); + addObjcClassForTag(labelTag, [DOMHTMLLabelElement class]); + addObjcClassForTag(fieldsetTag, [DOMHTMLFieldSetElement class]); + addObjcClassForTag(legendTag, [DOMHTMLLegendElement class]); + addObjcClassForTag(ulTag, [DOMHTMLUListElement class]); + addObjcClassForTag(olTag, [DOMHTMLOListElement class]); + addObjcClassForTag(dlTag, [DOMHTMLDListElement class]); + addObjcClassForTag(dirTag, [DOMHTMLDirectoryElement class]); + addObjcClassForTag(menuTag, [DOMHTMLMenuElement class]); + addObjcClassForTag(liTag, [DOMHTMLLIElement class]); + addObjcClassForTag(divTag, [DOMHTMLDivElement class]); + addObjcClassForTag(pTag, [DOMHTMLParagraphElement class]); + addObjcClassForTag(h1Tag, [DOMHTMLHeadingElement class]); + addObjcClassForTag(h2Tag, [DOMHTMLHeadingElement class]); + addObjcClassForTag(h3Tag, [DOMHTMLHeadingElement class]); + addObjcClassForTag(h4Tag, [DOMHTMLHeadingElement class]); + addObjcClassForTag(h5Tag, [DOMHTMLHeadingElement class]); + addObjcClassForTag(h6Tag, [DOMHTMLHeadingElement class]); + addObjcClassForTag(qTag, [DOMHTMLQuoteElement class]); + addObjcClassForTag(preTag, [DOMHTMLPreElement class]); + addObjcClassForTag(listingTag, [DOMHTMLPreElement class]); + addObjcClassForTag(brTag, [DOMHTMLBRElement class]); + addObjcClassForTag(basefontTag, [DOMHTMLBaseFontElement class]); + addObjcClassForTag(fontTag, [DOMHTMLFontElement class]); + addObjcClassForTag(hrTag, [DOMHTMLHRElement class]); + addObjcClassForTag(aTag, [DOMHTMLAnchorElement class]); + addObjcClassForTag(imgTag, [DOMHTMLImageElement class]); + addObjcClassForTag(canvasTag, [DOMHTMLImageElement class]); + addObjcClassForTag(objectTag, [DOMHTMLObjectElement class]); + addObjcClassForTag(paramTag, [DOMHTMLParamElement class]); + addObjcClassForTag(appletTag, [DOMHTMLAppletElement class]); + addObjcClassForTag(mapTag, [DOMHTMLMapElement class]); + addObjcClassForTag(areaTag, [DOMHTMLAreaElement class]); + addObjcClassForTag(scriptTag, [DOMHTMLScriptElement class]); + addObjcClassForTag(tableTag, [DOMHTMLTableElement class]); + addObjcClassForTag(theadTag, [DOMHTMLTableSectionElement class]); + addObjcClassForTag(tbodyTag, [DOMHTMLTableSectionElement class]); + addObjcClassForTag(tfootTag, [DOMHTMLTableSectionElement class]); + addObjcClassForTag(tdTag, [DOMHTMLTableCellElement class]); + addObjcClassForTag(trTag, [DOMHTMLTableRowElement class]); + addObjcClassForTag(colTag, [DOMHTMLTableColElement class]); + addObjcClassForTag(colgroupTag, [DOMHTMLTableColElement class]); + addObjcClassForTag(captionTag, [DOMHTMLTableCaptionElement class]); + addObjcClassForTag(framesetTag, [DOMHTMLFrameSetElement class]); + addObjcClassForTag(frameTag, [DOMHTMLFrameElement class]); + addObjcClassForTag(iframeTag, [DOMHTMLIFrameElement class]); +} + +Class objcClassForTag(const AtomicString& tagName) +{ + if (!objcClassMap) + createObjcClassMap(); + + Class objcClass = objcClassMap->get(tagName.impl()); + if (!objcClass) + objcClass = [DOMHTMLElement class]; + return objcClass; +} + +Class objcClassForHTMLElement(HTMLElement* htmlElt) +{ + // The old way for testing purposes + Class wrapperClass; + if (htmlElt->hasLocalName(htmlTag)) + wrapperClass = [DOMHTMLHtmlElement class]; + else if (htmlElt->hasLocalName(headTag)) + wrapperClass = [DOMHTMLHeadElement class]; + else if (htmlElt->hasLocalName(linkTag)) + wrapperClass = [DOMHTMLLinkElement class]; + else if (htmlElt->hasLocalName(titleTag)) + wrapperClass = [DOMHTMLTitleElement class]; + else if (htmlElt->hasLocalName(metaTag)) + wrapperClass = [DOMHTMLMetaElement class]; + else if (htmlElt->hasLocalName(baseTag)) + wrapperClass = [DOMHTMLBaseElement class]; + else if (htmlElt->hasLocalName(isindexTag)) + wrapperClass = [DOMHTMLIsIndexElement class]; + else if (htmlElt->hasLocalName(styleTag)) + wrapperClass = [DOMHTMLStyleElement class]; + else if (htmlElt->hasLocalName(bodyTag)) + wrapperClass = [DOMHTMLBodyElement class]; + else if (htmlElt->hasLocalName(formTag)) + wrapperClass = [DOMHTMLFormElement class]; + else if (htmlElt->hasLocalName(selectTag)) + wrapperClass = [DOMHTMLSelectElement class]; + else if (htmlElt->hasLocalName(optgroupTag)) + wrapperClass = [DOMHTMLOptGroupElement class]; + else if (htmlElt->hasLocalName(optionTag)) + wrapperClass = [DOMHTMLOptionElement class]; + else if (htmlElt->hasLocalName(inputTag)) + wrapperClass = [DOMHTMLInputElement class]; + else if (htmlElt->hasLocalName(textareaTag)) + wrapperClass = [DOMHTMLTextAreaElement class]; + else if (htmlElt->hasLocalName(buttonTag)) + wrapperClass = [DOMHTMLButtonElement class]; + else if (htmlElt->hasLocalName(labelTag)) + wrapperClass = [DOMHTMLLabelElement class]; + else if (htmlElt->hasLocalName(fieldsetTag)) + wrapperClass = [DOMHTMLFieldSetElement class]; + else if (htmlElt->hasLocalName(legendTag)) + wrapperClass = [DOMHTMLLegendElement class]; + else if (htmlElt->hasLocalName(ulTag)) + wrapperClass = [DOMHTMLUListElement class]; + else if (htmlElt->hasLocalName(olTag)) + wrapperClass = [DOMHTMLOListElement class]; + else if (htmlElt->hasLocalName(dlTag)) + wrapperClass = [DOMHTMLDListElement class]; + else if (htmlElt->hasLocalName(dirTag)) + wrapperClass = [DOMHTMLDirectoryElement class]; + else if (htmlElt->hasLocalName(menuTag)) + wrapperClass = [DOMHTMLMenuElement class]; + else if (htmlElt->hasLocalName(liTag)) + wrapperClass = [DOMHTMLLIElement class]; + else if (htmlElt->hasLocalName(divTag)) + wrapperClass = [DOMHTMLDivElement class]; + else if (htmlElt->hasLocalName(pTag)) + wrapperClass = [DOMHTMLParagraphElement class]; + else if (htmlElt->hasLocalName(h1Tag) || + htmlElt->hasLocalName(h2Tag) || + htmlElt->hasLocalName(h3Tag) || + htmlElt->hasLocalName(h4Tag) || + htmlElt->hasLocalName(h5Tag) || + htmlElt->hasLocalName(h6Tag)) + wrapperClass = [DOMHTMLHeadingElement class]; + else if (htmlElt->hasLocalName(qTag)) + wrapperClass = [DOMHTMLQuoteElement class]; + else if (htmlElt->hasLocalName(preTag) || htmlElt->hasLocalName (listingTag)) + wrapperClass = [DOMHTMLPreElement class]; + else if (htmlElt->hasLocalName(brTag)) + wrapperClass = [DOMHTMLBRElement class]; + else if (htmlElt->hasLocalName(basefontTag)) + wrapperClass = [DOMHTMLBaseFontElement class]; + else if (htmlElt->hasLocalName(fontTag)) + wrapperClass = [DOMHTMLFontElement class]; + else if (htmlElt->hasLocalName(hrTag)) + wrapperClass = [DOMHTMLHRElement class]; + else if (htmlElt->hasLocalName(aTag)) + wrapperClass = [DOMHTMLAnchorElement class]; + else if (htmlElt->hasLocalName(imgTag) || + htmlElt->hasLocalName(canvasTag)) + wrapperClass = [DOMHTMLImageElement class]; + else if (htmlElt->hasLocalName(objectTag)) + wrapperClass = [DOMHTMLObjectElement class]; + else if (htmlElt->hasLocalName(paramTag)) + wrapperClass = [DOMHTMLParamElement class]; + else if (htmlElt->hasLocalName(appletTag)) + wrapperClass = [DOMHTMLAppletElement class]; + else if (htmlElt->hasLocalName(mapTag)) + wrapperClass = [DOMHTMLMapElement class]; + else if (htmlElt->hasLocalName(areaTag)) + wrapperClass = [DOMHTMLAreaElement class]; + else if (htmlElt->hasLocalName(scriptTag)) + wrapperClass = [DOMHTMLScriptElement class]; + else if (htmlElt->hasLocalName(tableTag)) + wrapperClass = [DOMHTMLTableElement class]; + else if (htmlElt->hasLocalName(theadTag) || + htmlElt->hasLocalName(tbodyTag) || + htmlElt->hasLocalName(tfootTag)) + wrapperClass = [DOMHTMLTableSectionElement class]; + else if (htmlElt->hasLocalName(tdTag)) + wrapperClass = [DOMHTMLTableCellElement class]; + else if (htmlElt->hasLocalName(trTag)) + wrapperClass = [DOMHTMLTableRowElement class]; + else if (htmlElt->hasLocalName(colTag) || + htmlElt->hasLocalName(colgroupTag)) + wrapperClass = [DOMHTMLTableColElement class]; + else if (htmlElt->hasLocalName(captionTag)) + wrapperClass = [DOMHTMLTableCaptionElement class]; + else if (htmlElt->hasLocalName(framesetTag)) + wrapperClass = [DOMHTMLFrameSetElement class]; + else if (htmlElt->hasLocalName(frameTag)) + wrapperClass = [DOMHTMLFrameElement class]; + else if (htmlElt->hasLocalName(iframeTag)) + wrapperClass = [DOMHTMLIFrameElement class]; + else + wrapperClass = [DOMHTMLElement class]; + + return wrapperClass; +} + + @implementation DOMNode (WebCoreInternal) - (id)_initWithNode:(Node *)impl @@ -482,122 +698,12 @@ static ListenerMap *listenerMap; case Node::ELEMENT_NODE: if (impl->isHTMLElement()) { // FIXME: Reflect marquee once the API has been determined. - // FIXME: We could make the HTML classes hand back their class names and then use that to make - // the appropriate Obj-C class from the string. HTMLElement* htmlElt = static_cast<HTMLElement*> (impl); - if (htmlElt->hasLocalName(htmlTag)) - wrapperClass = [DOMHTMLHtmlElement class]; - else if (htmlElt->hasLocalName(headTag)) - wrapperClass = [DOMHTMLHeadElement class]; - else if (htmlElt->hasLocalName(linkTag)) - wrapperClass = [DOMHTMLLinkElement class]; - else if (htmlElt->hasLocalName(titleTag)) - wrapperClass = [DOMHTMLTitleElement class]; - else if (htmlElt->hasLocalName(metaTag)) - wrapperClass = [DOMHTMLMetaElement class]; - else if (htmlElt->hasLocalName(baseTag)) - wrapperClass = [DOMHTMLBaseElement class]; - else if (htmlElt->hasLocalName(isindexTag)) - wrapperClass = [DOMHTMLIsIndexElement class]; - else if (htmlElt->hasLocalName(styleTag)) - wrapperClass = [DOMHTMLStyleElement class]; - else if (htmlElt->hasLocalName(bodyTag)) - wrapperClass = [DOMHTMLBodyElement class]; - else if (htmlElt->hasLocalName(formTag)) - wrapperClass = [DOMHTMLFormElement class]; - else if (htmlElt->hasLocalName(selectTag)) - wrapperClass = [DOMHTMLSelectElement class]; - else if (htmlElt->hasLocalName(optgroupTag)) - wrapperClass = [DOMHTMLOptGroupElement class]; - else if (htmlElt->hasLocalName(optionTag)) - wrapperClass = [DOMHTMLOptionElement class]; - else if (htmlElt->hasLocalName(inputTag)) - wrapperClass = [DOMHTMLInputElement class]; - else if (htmlElt->hasLocalName(textareaTag)) - wrapperClass = [DOMHTMLTextAreaElement class]; - else if (htmlElt->hasLocalName(buttonTag)) - wrapperClass = [DOMHTMLButtonElement class]; - else if (htmlElt->hasLocalName(labelTag)) - wrapperClass = [DOMHTMLLabelElement class]; - else if (htmlElt->hasLocalName(fieldsetTag)) - wrapperClass = [DOMHTMLFieldSetElement class]; - else if (htmlElt->hasLocalName(legendTag)) - wrapperClass = [DOMHTMLLegendElement class]; - else if (htmlElt->hasLocalName(ulTag)) - wrapperClass = [DOMHTMLUListElement class]; - else if (htmlElt->hasLocalName(olTag)) - wrapperClass = [DOMHTMLOListElement class]; - else if (htmlElt->hasLocalName(dlTag)) - wrapperClass = [DOMHTMLDListElement class]; - else if (htmlElt->hasLocalName(dirTag)) - wrapperClass = [DOMHTMLDirectoryElement class]; - else if (htmlElt->hasLocalName(menuTag)) - wrapperClass = [DOMHTMLMenuElement class]; - else if (htmlElt->hasLocalName(liTag)) - wrapperClass = [DOMHTMLLIElement class]; - else if (htmlElt->hasLocalName(divTag)) - wrapperClass = [DOMHTMLDivElement class]; - else if (htmlElt->hasLocalName(pTag)) - wrapperClass = [DOMHTMLParagraphElement class]; - else if (htmlElt->hasLocalName(h1Tag) || - htmlElt->hasLocalName(h2Tag) || - htmlElt->hasLocalName(h3Tag) || - htmlElt->hasLocalName(h4Tag) || - htmlElt->hasLocalName(h5Tag) || - htmlElt->hasLocalName(h6Tag)) - wrapperClass = [DOMHTMLHeadingElement class]; - else if (htmlElt->hasLocalName(qTag)) - wrapperClass = [DOMHTMLQuoteElement class]; - else if (htmlElt->hasLocalName(preTag) || htmlElt- >hasLocalName(listingTag)) - wrapperClass = [DOMHTMLPreElement class]; - else if (htmlElt->hasLocalName(brTag)) - wrapperClass = [DOMHTMLBRElement class]; - else if (htmlElt->hasLocalName(basefontTag)) - wrapperClass = [DOMHTMLBaseFontElement class]; - else if (htmlElt->hasLocalName(fontTag)) - wrapperClass = [DOMHTMLFontElement class]; - else if (htmlElt->hasLocalName(hrTag)) - wrapperClass = [DOMHTMLHRElement class]; - else if (htmlElt->hasLocalName(aTag)) - wrapperClass = [DOMHTMLAnchorElement class]; - else if (htmlElt->hasLocalName(imgTag) || - htmlElt->hasLocalName(canvasTag)) - wrapperClass = [DOMHTMLImageElement class]; - else if (htmlElt->hasLocalName(objectTag)) - wrapperClass = [DOMHTMLObjectElement class]; - else if (htmlElt->hasLocalName(paramTag)) - wrapperClass = [DOMHTMLParamElement class]; - else if (htmlElt->hasLocalName(appletTag)) - wrapperClass = [DOMHTMLAppletElement class]; - else if (htmlElt->hasLocalName(mapTag)) - wrapperClass = [DOMHTMLMapElement class]; - else if (htmlElt->hasLocalName(areaTag)) - wrapperClass = [DOMHTMLAreaElement class]; - else if (htmlElt->hasLocalName(scriptTag)) - wrapperClass = [DOMHTMLScriptElement class]; - else if (htmlElt->hasLocalName(tableTag)) - wrapperClass = [DOMHTMLTableElement class]; - else if (htmlElt->hasLocalName(theadTag) || - htmlElt->hasLocalName(tbodyTag) || - htmlElt->hasLocalName(tfootTag)) - wrapperClass = [DOMHTMLTableSectionElement class]; - else if (htmlElt->hasLocalName(tdTag)) - wrapperClass = [DOMHTMLTableCellElement class]; - else if (htmlElt->hasLocalName(trTag)) - wrapperClass = [DOMHTMLTableRowElement class]; - else if (htmlElt->hasLocalName(colTag) || - htmlElt->hasLocalName(colgroupTag)) - wrapperClass = [DOMHTMLTableColElement class]; - else if (htmlElt->hasLocalName(captionTag)) - wrapperClass = [DOMHTMLTableCaptionElement class]; - else if (htmlElt->hasLocalName(framesetTag)) - wrapperClass = [DOMHTMLFrameSetElement class]; - else if (htmlElt->hasLocalName(frameTag)) - wrapperClass = [DOMHTMLFrameElement class]; - else if (htmlElt->hasLocalName(iframeTag)) - wrapperClass = [DOMHTMLIFrameElement class]; - else - wrapperClass = [DOMHTMLElement class]; + + // Do it both ways to simplify comparing the two ways in Shark + // Obviously only the first one should used if we go with this patch + wrapperClass = objcClassForTag(htmlElt->localName()); + wrapperClass = objcClassForHTMLElement(htmlElt); } else { wrapperClass = [DOMElement class]; }

3 3

Slow page loading question
by Craig Daniels 26 Apr '06

26 Apr '06

I'm trying to figure out why certain sites have started taking several minutes to load and others load normally. I'm running 10.4.6 (8I127) on a Quad G5 with Safari 2.0.3 connecting to the Internet via the corporate LAN. For a few weeks now, MyYahoo, Google (the customized home page), Slashdot and MacNN are all taking two to six minutes to load. Other sites like MacInTouch, CNet and internal sites load normally. It doesn't appear to be a corporate LAN issue because all the sites load normally in Firefox (1.5.0.2). Using the WebKit nightly build (r14071), Slashdot and MacNN load normally but not MyYahoo or Google. There are no errors in the Console. Also, all the sites load correctly in Safari if I proxy through an SSH tunnel to Delegate running on my PowerBook at home. Any suggestions on what to look for to fix this would be appreciated. Craig

1 0

Stay out of WebTextRenderer and WebTextRendererFactory.
by David Hyatt 25 Apr '06

25 Apr '06

These files are going to be moving into WebCore and then undergoing heavy surgery. For now stay out of these files if you can. dave (hyatt(a)apple.com)

1 0

Optimizing DOMNode _nodeWith
by Matt Gough 24 Apr '06

24 Apr '06

I have some Obj-c code which steps through all of the nodes in the DOM. For a medium sized DOM (e.g news.google.com - just over 4000 nodes) this code takes over one tenth of a second on an 867MHz G4. A third of that time is down to the calls to hasLocalName inside of: +(DOMNode *) _nodeWith:(Node* *) e.g. HTMLElement* htmlElt = static_cast<HTMLElement*>(impl); if (htmlElt->hasLocalName(htmlTag)) wrapperClass = [DOMHTMLHtmlElement class]; else if (htmlElt->hasLocalName(headTag)) etc etc Now there is already a comment there that says: // FIXME: We could make the HTML classes hand back their class names and then use that to make // the appropriate Obj-C class from the string. I am guessing that this would go something like this, but before I go to the trouble of doing this for every class could someone make sure I am pondering the right thing. e.g For each element type: String HTMLElement::objcClassName() const { return String("DOMHTMLElement"); } String HTMLDivElement::objcClassName() const { return String("DOMHTMLDivElement"); } etc.. and then replace the all those tests in _nodeWith with: if (impl->isHTMLElement()) { // FIXME: Reflect marquee once the API has been determined. HTMLElement* htmlElt = static_cast<HTMLElement*>(impl); String className(htmlElt->objcClassName()); NSString* asNSString = ?? How do I convert a String to an NSString? wrapperClass = NSClassFromString(asNSString); } Does this all make sense? Matt Gough

4 4

Why no version 418.x in Bugzilla?
by Matt Gough 24 Apr '06

24 Apr '06

Since the current release version of WebKit is 418, why is there no option for this when specifying a version number for a bug? Matt Gough

2 1

[DOMHTMLDocument doctype] always returning nil.
by Matt Gough 24 Apr '06

24 Apr '06

Sometime since 418, the implementation of HTMLDocument::doctype was changed to: DocumentType *HTMLDocument::doctype() const { // According to a comment in dom_doc.cpp, doctype is null for HTML documents. return 0; } Firstly, where is dom_doc.cpp? It doesn't seem a part of WebKit/Core. What is the comment and why is it deemed correct that doctype should be null for HTML documents? Why do I care: Well, I am writing some code to take a DOM (or portions thereof) and convert it back into a fairly self-contained HTML file. Without being able to reconstitute the correct <!DOCTYPE ...> I have no way of ensuring that quirks mode is set correctly when displaying the resulting html. Is there any other way to determine this? Matt Gough

2 4

Build system for ports
by Kevin Ollivier 23 Apr '06

23 Apr '06

Hi all, As Mike Emmel and I have both decided to use Bakefile for our ports, we decided to work together and create a build system that works for both our ports. As a start, my focus has been on taking Mike's project files and creating a basic project that builds the cross- platform WebCore sources on Win, Mac and Linux that any port would need. This way any new ports that are created can actually just "derive" from the webcore_base project and only have to add includes/ sources/etc. specific to their platform or port. I've mostly completed that step. For those interested, here's some brief docs on the system: How to build using Bakefile: http://kevino.theolliviers.com/webkit/bakefile-build.txt (Most of those steps will eventually be scripted, hopefully as part of build-webkit, but I wanted to give people an overview of the process.) Here are the changes I needed to make to WebCore for this to work, and also any unresolved issues on various ports: http://kevino.theolliviers.com/webkit/bakefile-changes.txt Using the Bakefile-generated projects, I've built the cross-platform sources (excluding Cairo, which won't build on OS X...) successfully on Intel Mac OS X 10.4.6 and WinXP SP2/MSVS8, and hopefully once a few more changes are made, Linux (FC4) will build fine as well. But there's still one major question before I can put together a draft to show people. How exactly should build systems for ports be incorporated into the webkit tree? For example, when you think of Win32, wx, etc. there may be multiple MSVS7/8 project files. So do we create one project file and allow people to select a port when they build (with an intelligent default, of course) or do we put project files for ports in separate files/dirs? If the latter (which I'm personally leaning towards), what should the directory scheme for ports be? Do we do, for example, <WebCore>/ports/wx/WebCore.dsw Or just: <WebCore>/wxwebcore.dsw Or a combination, like: <WebCore>/ports/wxwebcore.dsw Ideas? Thoughts? Thanks, Kevin

6 20

Opening files from Safari
by Luc Potron 22 Apr '06

22 Apr '06

Hello, I¹m not sure this is the correct list. We are developping software on mac that use a web browser to navigate within a database. When a user select something (ie a quark xpress or indesign document) we wish to open it on his/her mac using the correct application. The url we place in the web page is something like: file:///Volumes/server/.../document.qxd In the past (2 months ago) we¹ve been able to have it working with Safari by installing a ³com.apple.DownloadAssessment.plist² file in the ~/Library/Preferences folder. This file contains the following: <!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.comProperty-List-1.0.dtd"> <plist version="1.0"> <dict> <key>LSRiskCategorySafe</key> <dict> <key>LSRiskCategoryExtensions</key> <array> <string>qxd</string> <string>qxt</string> <string>indd</string> </array> </dict> </dict> </plist> Since the last OsX Update, the file do not open anymore. What happens is the folder containing the file is opened and the file is selected by the finder. Is there¹s a way to have Safari launch the application and open the file? I understand this is probably a security problem but it would be great to have a solution. Otherwise our web based solution will not work anymore and we are stuck with InternetExplorer which is the only one to work as expected. Maybe some Safari gurus can help on this point. Thanks in adavance Luc Potron Trias Développement

1 0

Bakefile patch (for wx and GDK ports) in Bugzilla
by Kevin Ollivier 22 Apr '06

22 Apr '06

Hi all, I've finally been able to finish up my edits to the Bakefile-based build system that Mike and I have been talking about for some time now. ;-) I don't want to submit it for review yet, as I'd like Mike E. to take a closer look at it first and see how well my changes meet his needs, but I'd of course welcome any comments, suggestions, testing, etc. on the patch. The patch currently does include already generated makefiles based on TOT so you should be able to build without first generating the Makefiles. (Unless TOT has already had JSCore/WebCore build files added/removed by the time you read this... ;-) Anyways, more info about how to get started can be found in the Bugzilla item here: http://bugzilla.opendarwin.org/show_bug.cgi?id=8528 Also, thanks to Darin for being so quick in landing my compilation fixes patch, as it definitely makes the process of testing this smoother. :-) Thanks, Kevin

1 0

Some useful bugs that should be very easy to fix
by Maciej Stachowiak 21 Apr '06

21 Apr '06

Hi everyone, Have you always yearned to be a browser hacker? Well here's some bugs that look super easy to fix, and which were specifically requested by a major web site. I put a likely guess of the very simple cause for each in the bug, including where to look in the code. Any of these would be a good way to get your feet wet in the code: http://bugzilla.opendarwin.org/show_bug.cgi?id=8509 http://bugzilla.opendarwin.org/show_bug.cgi?id=8510 http://bugzilla.opendarwin.org/show_bug.cgi?id=8511

1 0