December 2005 - webkit-dev - lists.webkit.org

Leaks
by Eric Seidel 07 Dec '05

07 Dec '05

It looks like we've had a few leaks slip into TOT! To check, run: run-webkit-tests --leaks fast Process 8941: 94983 nodes malloced for 12691 KB Process 8941: 30043 leaks for 1474576 total leaked bytes. Maciej is investigating some of this right now. -eric

1 0

WebCore Code Cleanup
by Eric Seidel 07 Dec '05

07 Dec '05

Hi all- I've been attempting to do some code cleanup in WebCore as of late. I've removed several dead (and rotted) sections of #ifdef'd code, and am about make patches to remove some more #ifdef'd sections and I wanted to make sure there were no complaints. CACHE_DEBUG PARSER_DEBUG TOKEN_DEBUG DEBUG_LAYOUT FORMS_DEBUG KJS_VERBOSE CSS_DEBUG CSS_STYLESHEET_DEBUG is the list of ifdefs (and associated code) which I plan to post patches to remove. kdWarning, kdDebug, kdError are all noops in WebCore, thus these #ifdefs are useless (without defining your own local kdDebug, etc.) Any complaints? Any ifdefs which I haven't listed there which you'd like to make sure we don't remove? -eric

4 8

Subversion Migration
by Eric Seidel 07 Dec '05

07 Dec '05

Hi all- This weekend we will be migrating our source repository from using CVS to Subversion. This migration will take place starting Friday evening at 5PM and continue through Saturday. More details will follow. After the migration is complete, in order to check out the WebKit sources you will be required to have a Subversion client on your machine. Since we know you'll all be anxious to checkout the sources once complete, this is an early reminder to start downloading your subversion client. :) Subversion Manual: http://svnbook.red-bean.com/ Mac OS X Subversion Client Packages: http://www.codingmonkeys.de/mbo/ http://subversion.tigris.org/project_packages.html -eric

5 8

New rules for code submission
by Maciej Stachowiak 05 Dec '05

05 Dec '05

Hi everyone, To make life easier on committers, and to maintain the legal integrity of the WebKit code base, we're asking WebKit contributors to include a few more things with their code submissions. Copyright notice and license - For existing files where you have made your own changes, please include your own copyright notice at the top, and make sure you are ok with the existing license terms. For new files, please also make sure to add the appropriate license. If you have included changes from anyone else, or from another project, such as the KDE version of khtml, please make sure to also include the appropriate copyright notices and licenses from that project. Test cases - Test cases and expected results should be included in the patch, and not just attached as separate files. This makes life easier for commiters. ChangeLog entry - Please include an appropriate ChangeLog entry with your patch, mentioning the bug number and describing the change. That way the commiter won't have to write one for you. Those submitting code, please make sure to include these things. Reviewers and submitters, make sure to check for these new requirements. The copyright notices are especially important. For brand new code changes, we need them to indicate that the author agrees to distribute the code under the same license, and for code copied from other projects it is essential that we do not violate their licenses. Therefore, we'd like to ask you to find the time to give us copyright information for any past contributions, with a brief note that you agree to the license on the affected files. If you've submitted a lot of different changes, we can probably find what files you have modified from the ChangeLog. But we still need to know how you would like to be listed on the copyright notice. Regards, Maciej

1 0

WebKit+SVG ready for mainline
by Eric Seidel 05 Dec '05

05 Dec '05

Greetings: I have some good news: SVG is ready to be rolled into the main WebKit development builds. My proposal is to do so next week. This will affect all WebKit developers, as you will soon be pulling extra source code from CVS, and building a slighting larger set of sources (by default). I'm writing this email to propose my plan of action, and solicit feedback and answer any concerns you might have. My plan of action, in brief: 1. This early next week I plan to move the ksvg2 and kcanvas directories, as well as the SVGLayout tests out of SVGSupport and into the main WebCore and LayoutTests modules (this mean's everyone will check out more code). 2. Over the course of next week discuss with several other Safari engineers the "tie-in" points which SVG has to the rest of WebKit, and re-verify the sanity of said tie-ins. :) 3. Finally, by next weekend, "flip the switch" and make WebKit+SVG the default build target for WebCore. If you have any questions, comments, concerns, please drop me a line. -eric

2 1

Fwd: [webkit-dev] WebKit+SVG ready for mainline
by Joost de Valk 04 Dec '05

04 Dec '05

Somehow i replied to Eric instead of the list... Kind regards, Joost -- Joost de Valk #: AlthA on #webkit @ irc.freenode.net @: webkit(a)joostdevalk.nl W: http://www.joostdevalk.nl "The only people who find what they are looking for in life are the fault finders." - Foster's Law Begin forwarded message: > Hi Eric, > > first of all: great news, and a job well done from you and the > other SVG-guys (no girls in there are there?). Secondly: WebKit is > a development build by default, so i think this is a good plan. > Small problems that may rise will be fixed soon enough once > everybody uses the same WebKit. > > Kind regards, > Joost

1 0

Disabled rendering of <Input type = image />
by Mark Thomas 02 Dec '05

02 Dec '05

Hi, Does anybody know what the correct behavior of an input item of type=image should do e.g. <input type="image" onclick="alert();" ...etc... /> As I get the right click behavior i.e. Not responding to clicks, but the item doesn't render as disabled, also the accessibility also doesn't report correctly. Presently googles imply should render disabled, although it's not clear cut it seems. http://www.w3.org/TR/REC-html40/interact/forms.html#h-17.12 Thanks Mark.

1 0