<html>
    <head>
      <base href="https://bugs.webkit.org/">
    </head>
    <body><span class="vcard"><a class="email" href="mailto:msaboff@apple.com" title="Michael Saboff <msaboff@apple.com>"> <span class="fn">Michael Saboff</span></a>
</span> changed
          <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - test262/Runner.pm: minor updates"
   href="https://bugs.webkit.org/show_bug.cgi?id=186399">bug 186399</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #342183 Flags</td>
           <td>review?
           </td>
           <td>review-
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - test262/Runner.pm: minor updates"
   href="https://bugs.webkit.org/show_bug.cgi?id=186399#c5">Comment # 5</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - test262/Runner.pm: minor updates"
   href="https://bugs.webkit.org/show_bug.cgi?id=186399">bug 186399</a>
              from <span class="vcard"><a class="email" href="mailto:msaboff@apple.com" title="Michael Saboff <msaboff@apple.com>"> <span class="fn">Michael Saboff</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=342183&action=diff" name="attach_342183" title="Patch">attachment 342183</a> <a href="attachment.cgi?id=342183&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=342183&action=review">https://bugs.webkit.org/attachment.cgi?id=342183&action=review</a>

Basically fine after addressing a few issues.

<span class="quote">> Tools/ChangeLog:7
> +        - If harness files cannot be found in a custom, supplies
> +        test262 path, then default to webkit's test262 harness files.</span >

I don't quite understand "in a custom, supplies test262 path,"

<span class="quote">> Tools/Scripts/test262/Runner.pm:96
>  my $expectationsFile = abs_path("$Bin/../../../JSTests/test262/expectations.yaml");
>  my $configFile = abs_path("$Bin/../../../JSTests/test262/config.yaml");</span >

It seems to make sense to have these paths be based on $webkitTest262Dir.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are on the CC list for the bug.</li>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>